[jira] [Commented] (FLINK-14926) Make sure no resource leak of RocksObject
[
https://issues.apache.org/jira/browse/FLINK-14926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999315#comment-16999315
]
Yu Li commented on FLINK-14926:
---
We also need to merge the changes of FLINK-15199 into release-1.10 to prevent
compilation issue when running flink-benchmark against release-1.10, and I
guess the plan was to include all related commits here when closing it. But yes
I think we could also update FLINK-15199 to indicate the merging into
release-1.10.
Let me add some comments about changes for this JIRA and close it. Thanks for
the reminder [~gjy].
> Make sure no resource leak of RocksObject
> -
>
> Key: FLINK-14926
> URL: https://issues.apache.org/jira/browse/FLINK-14926
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / State Backends
>Affects Versions: 1.6.4, 1.7.2, 1.8.2, 1.9.1
>Reporter: Yu Li
>Assignee: Yu Li
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When investigating FLINK-14484 to allow setting {{WriteBufferManager}} via
> options, we find it necessary to supply a {{close}} method in
> {{OptionsFactory}} to make sure resources configured in options like
> {{WriteBufferManager}} could/would be released.
> What's more, we're having potential risk of resource leak in
> {{PredefinedOptions}} such as the created [BloomFilter
> instance|https://github.com/apache/flink/blob/e14bd50fed42e89674ba9d01a231d5c5e59f490c/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java#L155]
> is never closed (regression caused by FLINK-7220 changes), and we should
> also fix this and add a {{close}} method in {{PredefinedOptions}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14926) Make sure no resource leak of RocksObject
[
https://issues.apache.org/jira/browse/FLINK-14926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999082#comment-16999082
]
Gary Yao commented on FLINK-14926:
--
What's the state here? There are already commits in release-1.10, e.g.,
208de7c29f2ca71b526f98f603cf4a55103c5520.
> Make sure no resource leak of RocksObject
> -
>
> Key: FLINK-14926
> URL: https://issues.apache.org/jira/browse/FLINK-14926
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / State Backends
>Affects Versions: 1.6.4, 1.7.2, 1.8.2, 1.9.1
>Reporter: Yu Li
>Assignee: Yu Li
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When investigating FLINK-14484 to allow setting {{WriteBufferManager}} via
> options, we find it necessary to supply a {{close}} method in
> {{OptionsFactory}} to make sure resources configured in options like
> {{WriteBufferManager}} could/would be released.
> What's more, we're having potential risk of resource leak in
> {{PredefinedOptions}} such as the created [BloomFilter
> instance|https://github.com/apache/flink/blob/e14bd50fed42e89674ba9d01a231d5c5e59f490c/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java#L155]
> is never closed (regression caused by FLINK-7220 changes), and we should
> also fix this and add a {{close}} method in {{PredefinedOptions}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
