[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749106#comment-17749106 ] Vladislav Keda commented on FLINK-15358: [~autophagy] [~huwh] hi! This bug is a blocker for our tasks. Is it possible to increase its priority? > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Assignee: Mika Naylor >Priority: Minor > Labels: auto-deprioritized-major, stale-assigned > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[
https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631139#comment-17631139
]
Maximilian Michels commented on FLINK-15358:
Apologies for getting the YAML spec wrong, I meant we will use whatever is the
standard YAML way to escape #. I agree with Chesnay that our config file is
actually meant to be {{key: value}} and not proper YAML at all.
> [configuration] the global configuration will trim the rest of value after a
> `#` comment sign
> -
>
> Key: FLINK-15358
> URL: https://issues.apache.org/jira/browse/FLINK-15358
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Configuration
>Affects Versions: 1.9.1
>Reporter: BlaBlabla
>Assignee: Mika Naylor
>Priority: Minor
> Labels: auto-deprioritized-major, stale-assigned
>
> Hello,
> I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however
> the password contains a # sign, then the flink will skip the rest part of the
> password after #, eg:
> *metrics.reporter.influxdb.password: xxpasssxx#blabla*
>
> *#blabla* is parsed as an end line comment.
> Can you guys fix it?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630787#comment-17630787 ] Weihua Hu commented on FLINK-15358: --- [~chesnay] [~mxm] As[ https://yaml.org/spec/1.2.2/#66-comments|https://yaml.org/spec/1.2.2/#66-comments] shows, "Comments must be separated from other tokens by white space characters". Both current parser in flink and _escaping # via \backlash#_ are not the standard YAML behavior. IMO, solve this issue by migrate to standard yaml is better than introduce a new not-compliant escaping, may be we can discuss how to resolve the scripts problems in FLINK-23620. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Assignee: Mika Naylor >Priority: Minor > Labels: auto-deprioritized-major, stale-assigned > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630427#comment-17630427 ] Chesnay Schepler commented on FLINK-15358: -- It's not "easy" at all. Various scripts in Flink rely on the file containing key-value pairs for parsing/modifications. See FLINK-23620. ??We could at least support escaping # via \backlash# even without moving to a full-blown parser.?? Is that YAML-compliant? Let's not introduce another problem we have to fix down the line. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Assignee: Mika Naylor >Priority: Minor > Labels: auto-deprioritized-major, stale-assigned > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630422#comment-17630422 ] Maximilian Michels commented on FLINK-15358: We could at least support escaping # via \# even without moving to a full-blown parser. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Assignee: Mika Naylor >Priority: Minor > Labels: auto-deprioritized-major, stale-assigned > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630414#comment-17630414 ] Maximilian Michels commented on FLINK-15358: We could easily replace the parsing logic with a standard YAML parser, we even have Jackson with YAML support built into flink-core. However, I think we worry that this might be breaking some applications which rely on the lenient behavior of the existing parser. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Assignee: Mika Naylor >Priority: Minor > Labels: auto-deprioritized-major, stale-assigned > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630314#comment-17630314 ] Weihua Hu commented on FLINK-15358: --- [~wangyang0918] [~chesnay] How about using snakeYaml or Jackson to parse flink-conf? I can fix this issue if the solution works > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Assignee: Mika Naylor >Priority: Minor > Labels: auto-deprioritized-major, stale-assigned > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435864#comment-17435864 ] zlzhang0122 commented on FLINK-15358: - [~chesnay] what the progress of this ticket? We have encounter the similar problem, I think maybe we can choose using the third part of the yaml parser plugin such as snakeyaml, etc. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Priority: Minor > Labels: auto-deprioritized-major > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17336350#comment-17336350 ] Flink Jira Bot commented on FLINK-15358: This issue was labeled "stale-major" 7 ago and has not received any updates so it is being deprioritized. If this ticket is actually Major, please raise the priority and ask a committer to assign you the issue or revive the public discussion. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Priority: Major > Labels: stale-major > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17328137#comment-17328137 ] Flink Jira Bot commented on FLINK-15358: This major issue is unassigned and itself and all of its Sub-Tasks have not been updated for 30 days. So, it has been labeled "stale-major". If this ticket is indeed "major", please either assign yourself or give an update. Afterwards, please remove the label. In 7 days the issue will be deprioritized. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Priority: Major > Labels: stale-major > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007427#comment-17007427 ] Yang Wang commented on FLINK-15358: --- [~chesnay] Exactly, using a common yaml parser is more powerful and stable. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Priority: Major > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006817#comment-17006817 ] Chesnay Schepler commented on FLINK-15358: -- This could be a good opportunity to switch to a YAML-compliant parser instead of having our own basic version. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Priority: Major > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002161#comment-17002161 ] BlaBlabla commented on FLINK-15358: --- [~fly_in_gis] , Actually , I changed the influx password to the one that doesn't include a comment (#) sign. :D > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Priority: Major > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-15358) [configuration] the global configuration will trim the rest of value after a `#` comment sign
[ https://issues.apache.org/jira/browse/FLINK-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002053#comment-17002053 ] Yang Wang commented on FLINK-15358: --- [~blablabla123], I think you are right. Currently, all the string after # will be treated as comments. I agree with you that this is bug and need to be fixed. > [configuration] the global configuration will trim the rest of value after a > `#` comment sign > - > > Key: FLINK-15358 > URL: https://issues.apache.org/jira/browse/FLINK-15358 > Project: Flink > Issue Type: Bug > Components: Runtime / Configuration >Affects Versions: 1.9.1 >Reporter: BlaBlabla >Priority: Major > > Hello, > I have to config influx metrics reporter in _conf/flink-conf.yaml_ ,however > the password contains a # sign, then the flink will skip the rest part of the > password after #, eg: > *metrics.reporter.influxdb.password: xxpasssxx#blabla* > > *#blabla* is parsed as an end line comment. > Can you guys fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
