[jira] [Commented] (FLINK-1544) Extend streaming aggregation tests to include POJOs

2015-03-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379541#comment-14379541
 ] 

ASF GitHub Bot commented on FLINK-1544:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/517


 Extend streaming aggregation tests to include POJOs
 ---

 Key: FLINK-1544
 URL: https://issues.apache.org/jira/browse/FLINK-1544
 Project: Flink
  Issue Type: Improvement
  Components: Streaming
Reporter: Gyula Fora
Assignee: Péter Szabó
  Labels: starter

 Currently the streaming aggregation tests don't test pojo aggregations which 
 makes newly introduced bugs harder to detect.
 New tests should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-1544) Extend streaming aggregation tests to include POJOs

2015-03-24 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378059#comment-14378059
 ] 

ASF GitHub Bot commented on FLINK-1544:
---

Github user mbalassi commented on the pull request:

https://github.com/apache/flink/pull/517#issuecomment-85578193
  
Pushed it to my master, merging as soon as travis comes  in green.


 Extend streaming aggregation tests to include POJOs
 ---

 Key: FLINK-1544
 URL: https://issues.apache.org/jira/browse/FLINK-1544
 Project: Flink
  Issue Type: Improvement
  Components: Streaming
Reporter: Gyula Fora
Assignee: Péter Szabó
  Labels: starter

 Currently the streaming aggregation tests don't test pojo aggregations which 
 makes newly introduced bugs harder to detect.
 New tests should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-1544) Extend streaming aggregation tests to include POJOs

2015-03-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375959#comment-14375959
 ] 

ASF GitHub Bot commented on FLINK-1544:
---

Github user mbalassi commented on the pull request:

https://github.com/apache/flink/pull/517#issuecomment-85020206
  
LGTM, will merge in the evening.


 Extend streaming aggregation tests to include POJOs
 ---

 Key: FLINK-1544
 URL: https://issues.apache.org/jira/browse/FLINK-1544
 Project: Flink
  Issue Type: Improvement
  Components: Streaming
Reporter: Gyula Fora
Assignee: Péter Szabó
  Labels: starter

 Currently the streaming aggregation tests don't test pojo aggregations which 
 makes newly introduced bugs harder to detect.
 New tests should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-1544) Extend streaming aggregation tests to include POJOs

2015-03-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375897#comment-14375897
 ] 

ASF GitHub Bot commented on FLINK-1544:
---

GitHub user szape opened a pull request:

https://github.com/apache/flink/pull/517

[FLINK-1544] [streaming] POJO types added to AggregationFunctionTest

Testing aggragation functions with POJO types.
The AggregationFunctionTest covered min, max, sum, minBy and maxBy 
aggregations for tuples. I added the same tests for POJOs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mbalassi/flink FLINK-1544

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #517


commit 2def2d98f502487e548adf24406ecf2f2489e71e
Author: szape nemderogator...@gmail.com
Date:   2015-03-11T14:36:15Z

[FLINK-1544] [streaming] POJO types added to AggregationFunctionTest




 Extend streaming aggregation tests to include POJOs
 ---

 Key: FLINK-1544
 URL: https://issues.apache.org/jira/browse/FLINK-1544
 Project: Flink
  Issue Type: Improvement
  Components: Streaming
Reporter: Gyula Fora
Assignee: Péter Szabó
  Labels: starter

 Currently the streaming aggregation tests don't test pojo aggregations which 
 makes newly introduced bugs harder to detect.
 New tests should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)