[jira] [Commented] (FLINK-1561) Improve build server robustness by not reusing JVMs in integration tests
[
https://issues.apache.org/jira/browse/FLINK-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325760#comment-14325760
]
ASF GitHub Bot commented on FLINK-1561:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/412
> Improve build server robustness by not reusing JVMs in integration tests
>
>
> Key: FLINK-1561
> URL: https://issues.apache.org/jira/browse/FLINK-1561
> Project: Flink
> Issue Type: Improvement
> Components: Build System
>Affects Versions: 0.9
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
> Fix For: 0.9
>
>
> Right now, JVM forks are reused across unit and integration tests. While it
> makes a lot of sense for the very quick unit tests, the integration tests
> benefit less.
> We also see spurious JVM failures in the integration tests that are most
> likely related to JVM issues. An example is the trace below:
> {code}
> java.io.IOException: Cannot allocate memory
> at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
> at sun.nio.ch.FileDispatcherImpl.write(FileDispatcherImpl.java:60)
> at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
> at sun.nio.ch.IOUtil.write(IOUtil.java:65)
> at sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:205)
> at
> org.apache.flink.runtime.io.disk.iomanager.SegmentWriteRequest.write(AsynchronousFileIOChannel.java:270)
> at
> org.apache.flink.runtime.io.disk.iomanager.IOManagerAsync$WriterThread.run(IOManagerAsync.java:440)
> {code}
> I think we can improve reliability of Travis tests by not reusing forks for
> integration tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1561) Improve build server robustness by not reusing JVMs in integration tests
[
https://issues.apache.org/jira/browse/FLINK-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324424#comment-14324424
]
ASF GitHub Bot commented on FLINK-1561:
---
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/412#issuecomment-74700668
+1
> Improve build server robustness by not reusing JVMs in integration tests
>
>
> Key: FLINK-1561
> URL: https://issues.apache.org/jira/browse/FLINK-1561
> Project: Flink
> Issue Type: Improvement
> Components: Build System
>Affects Versions: 0.9
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
> Fix For: 0.9
>
>
> Right now, JVM forks are reused across unit and integration tests. While it
> makes a lot of sense for the very quick unit tests, the integration tests
> benefit less.
> We also see spurious JVM failures in the integration tests that are most
> likely related to JVM issues. An example is the trace below:
> {code}
> java.io.IOException: Cannot allocate memory
> at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
> at sun.nio.ch.FileDispatcherImpl.write(FileDispatcherImpl.java:60)
> at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
> at sun.nio.ch.IOUtil.write(IOUtil.java:65)
> at sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:205)
> at
> org.apache.flink.runtime.io.disk.iomanager.SegmentWriteRequest.write(AsynchronousFileIOChannel.java:270)
> at
> org.apache.flink.runtime.io.disk.iomanager.IOManagerAsync$WriterThread.run(IOManagerAsync.java:440)
> {code}
> I think we can improve reliability of Travis tests by not reusing forks for
> integration tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1561) Improve build server robustness by not reusing JVMs in integration tests
[
https://issues.apache.org/jira/browse/FLINK-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324134#comment-14324134
]
ASF GitHub Bot commented on FLINK-1561:
---
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/412#issuecomment-74660789
Looks good to me. +1
> Improve build server robustness by not reusing JVMs in integration tests
>
>
> Key: FLINK-1561
> URL: https://issues.apache.org/jira/browse/FLINK-1561
> Project: Flink
> Issue Type: Improvement
> Components: Build System
>Affects Versions: 0.9
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
> Fix For: 0.9
>
>
> Right now, JVM forks are reused across unit and integration tests. While it
> makes a lot of sense for the very quick unit tests, the integration tests
> benefit less.
> We also see spurious JVM failures in the integration tests that are most
> likely related to JVM issues. An example is the trace below:
> {code}
> java.io.IOException: Cannot allocate memory
> at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
> at sun.nio.ch.FileDispatcherImpl.write(FileDispatcherImpl.java:60)
> at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
> at sun.nio.ch.IOUtil.write(IOUtil.java:65)
> at sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:205)
> at
> org.apache.flink.runtime.io.disk.iomanager.SegmentWriteRequest.write(AsynchronousFileIOChannel.java:270)
> at
> org.apache.flink.runtime.io.disk.iomanager.IOManagerAsync$WriterThread.run(IOManagerAsync.java:440)
> {code}
> I think we can improve reliability of Travis tests by not reusing forks for
> integration tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1561) Improve build server robustness by not reusing JVMs in integration tests
[
https://issues.apache.org/jira/browse/FLINK-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324027#comment-14324027
]
ASF GitHub Bot commented on FLINK-1561:
---
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/412
[FLINK-1561] [build system] Use a fresh fork for each integration test run
Helps the build stability on Travis for integration tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink flink1561
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/412.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #412
commit a8c99d5a8fc6a700a670da5443d9a808ac5eaaa0
Author: Stephan Ewen
Date: 2015-02-17T10:10:48Z
[FLINK-1561] [build system] Use a fresh fork for each integration test run
> Improve build server robustness by not reusing JVMs in integration tests
>
>
> Key: FLINK-1561
> URL: https://issues.apache.org/jira/browse/FLINK-1561
> Project: Flink
> Issue Type: Improvement
> Components: Build System
>Affects Versions: 0.9
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
> Fix For: 0.9
>
>
> Right now, JVM forks are reused across unit and integration tests. While it
> makes a lot of sense for the very quick unit tests, the integration tests
> benefit less.
> We also see spurious JVM failures in the integration tests that are most
> likely related to JVM issues. An example is the trace below:
> {code}
> java.io.IOException: Cannot allocate memory
> at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
> at sun.nio.ch.FileDispatcherImpl.write(FileDispatcherImpl.java:60)
> at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
> at sun.nio.ch.IOUtil.write(IOUtil.java:65)
> at sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:205)
> at
> org.apache.flink.runtime.io.disk.iomanager.SegmentWriteRequest.write(AsynchronousFileIOChannel.java:270)
> at
> org.apache.flink.runtime.io.disk.iomanager.IOManagerAsync$WriterThread.run(IOManagerAsync.java:440)
> {code}
> I think we can improve reliability of Travis tests by not reusing forks for
> integration tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
