[jira] [Commented] (FLINK-15791) Don't use ForkJoinPool#commonPool() for executing asynchronous operations in Fabric8FlinkKubeClient

2020-03-05 Thread Zili Chen (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052067#comment-17052067
 ] 

Zili Chen commented on FLINK-15791:
---

[~fly_in_gis] Yes it is the case.

> Don't use ForkJoinPool#commonPool() for executing asynchronous operations in 
> Fabric8FlinkKubeClient
> ---
>
> Key: FLINK-15791
> URL: https://issues.apache.org/jira/browse/FLINK-15791
> Project: Flink
>  Issue Type: Sub-task
>  Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Yang Wang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.1, 1.11.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We should not use the {{ForkJoinPool#commonPool()}} in order to run 
> asynchronous operations in the {{Fabric8FlinkKubeClient}} as it is done 
> [here|https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L315].
>  Since we don't know which other component is using this pool, it can be 
> quite dangerous to use it as there might be congestion.
> Instead, I propose to provide an explicit I/O {{Executor}} which is used for 
> running asynchronous operations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15791) Don't use ForkJoinPool#commonPool() for executing asynchronous operations in Fabric8FlinkKubeClient

2020-03-05 Thread Yang Wang (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052057#comment-17052057
 ] 

Yang Wang commented on FLINK-15791:
---

[~trohrmann], since the #FLINK-16194(Refactor the Kubernetes decorator design) 
has remove the action watcher by design. I will close this PR and moving the 
explicit I/O Executor implementation to #FLINK-15790(Make FlinkKubeClient and 
its implementations asynchronous).

> Don't use ForkJoinPool#commonPool() for executing asynchronous operations in 
> Fabric8FlinkKubeClient
> ---
>
> Key: FLINK-15791
> URL: https://issues.apache.org/jira/browse/FLINK-15791
> Project: Flink
>  Issue Type: Sub-task
>  Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Yang Wang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.1, 1.11.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should not use the {{ForkJoinPool#commonPool()}} in order to run 
> asynchronous operations in the {{Fabric8FlinkKubeClient}} as it is done 
> [here|https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L315].
>  Since we don't know which other component is using this pool, it can be 
> quite dangerous to use it as there might be congestion.
> Instead, I propose to provide an explicit I/O {{Executor}} which is used for 
> running asynchronous operations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15791) Don't use ForkJoinPool#commonPool() for executing asynchronous operations in Fabric8FlinkKubeClient

2020-01-30 Thread Yang Wang (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027133#comment-17027133
 ] 

Yang Wang commented on FLINK-15791:
---

[~trohrmann] thanks. It's my bad. I will always wait for the assignee next time.

> Don't use ForkJoinPool#commonPool() for executing asynchronous operations in 
> Fabric8FlinkKubeClient
> ---
>
> Key: FLINK-15791
> URL: https://issues.apache.org/jira/browse/FLINK-15791
> Project: Flink
>  Issue Type: Sub-task
>  Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Yang Wang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should not use the {{ForkJoinPool#commonPool()}} in order to run 
> asynchronous operations in the {{Fabric8FlinkKubeClient}} as it is done 
> [here|https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L315].
>  Since we don't know which other component is using this pool, it can be 
> quite dangerous to use it as there might be congestion.
> Instead, I propose to provide an explicit I/O {{Executor}} which is used for 
> running asynchronous operations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15791) Don't use ForkJoinPool#commonPool() for executing asynchronous operations in Fabric8FlinkKubeClient

2020-01-30 Thread Till Rohrmann (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026861#comment-17026861
 ] 

Till Rohrmann commented on FLINK-15791:
---

Before opening PRs it would be good to wait for a committer to assign you to 
the issue [~fly_in_gis]. Otherwise we cannot ensure that the PRs get reviewed 
and merged in a timely manner.

> Don't use ForkJoinPool#commonPool() for executing asynchronous operations in 
> Fabric8FlinkKubeClient
> ---
>
> Key: FLINK-15791
> URL: https://issues.apache.org/jira/browse/FLINK-15791
> Project: Flink
>  Issue Type: Sub-task
>  Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should not use the {{ForkJoinPool#commonPool()}} in order to run 
> asynchronous operations in the {{Fabric8FlinkKubeClient}} as it is done 
> [here|https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L315].
>  Since we don't know which other component is using this pool, it can be 
> quite dangerous to use it as there might be congestion.
> Instead, I propose to provide an explicit I/O {{Executor}} which is used for 
> running asynchronous operations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15791) Don't use ForkJoinPool#commonPool() for executing asynchronous operations in Fabric8FlinkKubeClient

2020-01-29 Thread Yang Wang (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026474#comment-17026474
 ] 

Yang Wang commented on FLINK-15791:
---

I think your concern is on point. I will fix it.

> Don't use ForkJoinPool#commonPool() for executing asynchronous operations in 
> Fabric8FlinkKubeClient
> ---
>
> Key: FLINK-15791
> URL: https://issues.apache.org/jira/browse/FLINK-15791
> Project: Flink
>  Issue Type: Sub-task
>  Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should not use the {{ForkJoinPool#commonPool()}} in order to run 
> asynchronous operations in the {{Fabric8FlinkKubeClient}} as it is done 
> [here|https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L315].
>  Since we don't know which other component is using this pool, it can be 
> quite dangerous to use it as there might be congestion.
> Instead, I propose to provide an explicit I/O {{Executor}} which is used for 
> running asynchronous operations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)