[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422825#comment-17422825
]
Till Rohrmann commented on FLINK-15816:
---
I agree that implicit behaviour, such as truncating the configured cluster-id,
is not desirable because it makes the system harder to understand. On the other
hand, the failure happens rather late and it is also some internal value that
the user will probably not interact with. Hence, I could see two possible
improvements:
a) Check the validity of all values when creating the K8s HA services and fail
fast if some constraints are violated (e.g. cluster id is too long)
b) Truncate the labels we write into the config maps and state this behaviour
in the documentation
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0, 1.14.1
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422570#comment-17422570
]
Chesnay Schepler commented on FLINK-15816:
--
I don't think we should truncate anything; this will just cause surprises to
users.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0, 1.14.1
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422565#comment-17422565
]
Robert Metzger commented on FLINK-15816:
Yes, I'm using standalone K8s HA.
What's the best way of solving this? Shall we enforce a limit on the cluster
id? or truncate the label length at 63 characters?
I guess a limit on the cluster id is better.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0, 1.14.1
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419070#comment-17419070
]
Yang Wang commented on FLINK-15816:
---
The labels in Kubernetes must be 63 characters or less[1]. I guess you are
using the standalone K8s mode with K8s HA. The cluster id is not checked with
the characters limitation.
[1].
https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0, 1.14.1
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417129#comment-17417129
]
Robert Metzger commented on FLINK-15816:
Oh, you are right!
I misread the error message. This is the original error I got:
{code}
io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: PUT
at:
https://172.20.0.1/api/v1/namespaces/robert/configmaps/1f68c84c-7c13-47fa-aa33-c799512f358c-troubleshoot-throughput0-fork0-resourcemanager-leader.
Message: ConfigMap
"1f68c84c-7c13-47fa-aa33-c799512f358c-troubleshoot-throughput0-fork0-resourcemanager-leader"
is invalid: metadata.labels: Invalid value:
"1f68c84c-7c13-47fa-aa33-c799512f358c-troubleshoot-throughput0-fork0": must be
no more than 63 characters.
{code}
The problem is not the configmap name, but the label Flink is putting.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0, 1.14.1
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417096#comment-17417096
]
Yang Wang commented on FLINK-15816:
---
[~rmetzger] Thanks for sharing your concerns. But it seems that the configMap
name is not limited to 64 characters. IIRC, only the pod name and service name
have such limitation.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0, 1.14.1
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416020#comment-17416020
]
Robert Metzger commented on FLINK-15816:
I reopened the issue, because I believe the "MAXIMUM_CHARACTERS_OF_CLUSTER_ID"
is wrong.
The longest string Flink appends is "-resourcemanager-leader" for the K8s HA
config maps, which is 24 characters long.
63 - 24 = 39
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0, 1.14.1
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072349#comment-17072349
]
Yang Wang commented on FLINK-15816:
---
Thanks. Sounds great.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071611#comment-17071611
]
Canbin Zheng commented on FLINK-15816:
--
[~fly_in_gis] Seems that we have enough time before releasing 1.11. I would
like to fix it once I have time, and fix in 1.11 should be enough.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Minor
> Fix For: 1.10.1, 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071484#comment-17071484
]
Yang Wang commented on FLINK-15816:
---
[~felixzheng] Are you still working on this? I think it is easy to fix and hope
it could get merged in 1.11. Moreover, i think the fixed version of 1.11 is
enough. WDYT?
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Minor
> Fix For: 1.10.1, 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029601#comment-17029601
]
Yang Wang commented on FLINK-15816:
---
[~trohrmann] [~felixzheng] Thanks for your explanation. The limitation of 63
characters in Kubernetes is by design[1]. It seems that the limitation will
never change in the future. Even though i think the current exception message
is clear enough, i am not against with the pre-check way.
[1].
[https://github.com/kubernetes/community/blob/master/contributors/design-proposals/architecture/identifiers.md#identifiers-and-names-in-kubernetes]
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0, 1.10.1
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029491#comment-17029491
]
Canbin Zheng commented on FLINK-15816:
--
Hi [~fly_in_gis] I think it would be good to prevent the bad thing before it
happens.
I agree with [~trohrmann] that we throw a meaningful exception message telling
users that the value of \{{kubernetes.cluster-id}} must be no more than xxx
characters, and also, we should add limitation doc description for the
\{{kubernetes.cluster-id}} option.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0, 1.10.1
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028941#comment-17028941
]
Till Rohrmann commented on FLINK-15816:
---
What we should make sure (independent of the chosen approach) is that the user
sees a meaningful exception message telling him what's wrong. Additionally, we
should of course clean up all created resources in case of a failure.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0, 1.10.1
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028648#comment-17028648
]
Yang Wang commented on FLINK-15816:
---
[~felixzheng] I think the Flink client will throw a
{{ClusterDeploymentException}} caused by {{KubernetesClientException}}. Do we
really need to check this limitation additionally? I think what we need to do
is to clean up the residual resources when the Flink client failed.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0, 1.10.1
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027466#comment-17027466
]
Canbin Zheng commented on FLINK-15816:
--
[~trohrmann] More rigorously it's the constrait for the Kubernetes field
{{metadata.name}} which could be defered from the Exception info in the screen
capture appendix, I will take other components such as ConfigMap into
consideration when start working on it.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0, 1.10.1
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027449#comment-17027449
]
Till Rohrmann commented on FLINK-15816:
---
Thanks for reporting this issue [~felixzheng]. It would be good to link a
reference which states this limitation. A part from that, you can add a
constraint to Flink which checks and fails early if this condition is violated.
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0, 1.10.1
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option
[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027126#comment-17027126
]
Canbin Zheng commented on FLINK-15816:
--
cc [~yangwang166] @[~trohrmann]
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0, 1.10.1
>
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
