[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636828#comment-14636828 ] ASF GitHub Bot commented on FLINK-1658: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/929 > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Assignee: Matthias J. Sax >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636621#comment-14636621 ] ASF GitHub Bot commented on FLINK-1658: --- Github user mxm commented on the pull request: https://github.com/apache/flink/pull/929#issuecomment-123646781 +1 > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Assignee: Matthias J. Sax >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636520#comment-14636520 ] ASF GitHub Bot commented on FLINK-1658: --- Github user uce commented on the pull request: https://github.com/apache/flink/pull/929#issuecomment-123620462 No, +1. > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Assignee: Matthias J. Sax >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636513#comment-14636513 ] ASF GitHub Bot commented on FLINK-1658: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/929#issuecomment-123619095 Any objections to merging this? > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Assignee: Matthias J. Sax >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635862#comment-14635862 ] ASF GitHub Bot commented on FLINK-1658: --- GitHub user mjsax opened a pull request: https://github.com/apache/flink/pull/929 [FLINK-1658] Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent - deleted AbstractEvent in org.apache.flink.runtime.event.job (see comment section in https://issues.apache.org/jira/browse/FLINK-1658) You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/flink flink-1658-AbstractEvent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/929.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #929 commit 3cc8e3427fbfb61690417d6d1ee62745e2018662 Author: mjsax Date: 2015-07-21T19:54:08Z [FLINK-1658] Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent - deleted AbstractEvent in org.apache.flink.runtime.event.job (see comment section in https://issues.apache.org/jira/browse/FLINK-1658) > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Assignee: Matthias J. Sax >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635028#comment-14635028 ] Matthias J. Sax commented on FLINK-1658: I prefer to name abstract classes "AbstractCLASSNAME", but it was your commit renaming it. And I don't insist on (back-)renaming them. I will open a PR to remove org.apache.flink.runtime.event.job.AbstractEvent and to resolve this issue. > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635016#comment-14635016 ] Ufuk Celebi commented on FLINK-1658: Regarding org.apache.flink.runtime.event.job.AbstractEvent: Exactly. The TaskEvent and RuntimeEvent classes are for tagging only. Therefore it's fine to not have the prefix imo. > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635006#comment-14635006 ] Matthias J. Sax commented on FLINK-1658: I still see `org.apache.flink.runtime.event.job.AbstractEvent`. However, there is no sub-class for it. I guess, it can be deleted. However, there is: - `org.apache.flink.runtime.event.task.AbstractEvent` - `org.apache.flink.runtime.event.task.TaskEvent` (which is actually abstract) - `org.apache.flink.runtime.event.task.RuntimeEvent` (which is actually abstract) Maybe, TaskEvent and RuntimeEvent should be renamed into AbstractTaskEvent and AbstractRuntimeEvent ? > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634887#comment-14634887 ] Ufuk Celebi commented on FLINK-1658: org.apache.flink.runtime.event.job.AbstractEvent is not used any more (if IntelliJ is to be trusted) since the Akka rewrite. I guess it can be removed completely and hence there is no need for the renaming. :) > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634847#comment-14634847 ] Matthias J. Sax commented on FLINK-1658: Can this issue be tackled now? > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1658) Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
[ https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350469#comment-14350469 ] Ufuk Celebi commented on FLINK-1658: I agree. Please wait with the renaming till after the blocking result PR is merged. > Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent > -- > > Key: FLINK-1658 > URL: https://issues.apache.org/jira/browse/FLINK-1658 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, Local Runtime >Reporter: Gyula Fora >Priority: Trivial > > The same name is used for different event classes in the runtime which can > cause confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
