[jira] [Commented] (FLINK-17303) Return TableResult for Python TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-17303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088516#comment-17088516
]
godfrey he commented on FLINK-17303:
cc [~jincheng] [~hequn8128]
> Return TableResult for Python TableEnvironment
> --
>
> Key: FLINK-17303
> URL: https://issues.apache.org/jira/browse/FLINK-17303
> Project: Flink
> Issue Type: Improvement
> Components: API / Python
>Reporter: godfrey he
>Priority: Major
> Fix For: 1.11.0
>
>
> [FLINK-16366|https://issues.apache.org/jira/browse/FLINK-16366] supports
> executing a statement and returning a {{TableResult}} object, which could get
> {{JobClient}} (to associates the submitted Flink job), collect the execution
> result, or print the execution result. In Python, we should also introduce
> python TableResult class to make sure consistent with Java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-17303) Return TableResult for Python TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-17303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107326#comment-17107326
]
Hequn Cheng commented on FLINK-17303:
-
Resolved in 1.11.0 via 381131a785700a7d07b822d6db4eaa72d2daab61
> Return TableResult for Python TableEnvironment
> --
>
> Key: FLINK-17303
> URL: https://issues.apache.org/jira/browse/FLINK-17303
> Project: Flink
> Issue Type: Improvement
> Components: API / Python
>Reporter: godfrey he
>Assignee: Nicholas Jiang
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
>
> [FLINK-16366|https://issues.apache.org/jira/browse/FLINK-16366] supports
> executing a statement and returning a {{TableResult}} object, which could get
> {{JobClient}} (to associates the submitted Flink job), collect the execution
> result, or print the execution result. In Python, we should also introduce
> python TableResult class to make sure consistent with Java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-17303) Return TableResult for Python TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-17303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107957#comment-17107957
]
Hequn Cheng commented on FLINK-17303:
-
Changes were reverted in master due to FLINK-17710 via
70346b2c7ee8e449cc597ab4f19bc02cf6117f86
> Return TableResult for Python TableEnvironment
> --
>
> Key: FLINK-17303
> URL: https://issues.apache.org/jira/browse/FLINK-17303
> Project: Flink
> Issue Type: Improvement
> Components: API / Python
>Reporter: godfrey he
>Assignee: Nicholas Jiang
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
>
> [FLINK-16366|https://issues.apache.org/jira/browse/FLINK-16366] supports
> executing a statement and returning a {{TableResult}} object, which could get
> {{JobClient}} (to associates the submitted Flink job), collect the execution
> result, or print the execution result. In Python, we should also introduce
> python TableResult class to make sure consistent with Java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-17303) Return TableResult for Python TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-17303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114639#comment-17114639
]
Hequn Cheng commented on FLINK-17303:
-
Resolved in 1.12.0 via 6186069e22dd60757942968a41322f55bce4cbfb
> Return TableResult for Python TableEnvironment
> --
>
> Key: FLINK-17303
> URL: https://issues.apache.org/jira/browse/FLINK-17303
> Project: Flink
> Issue Type: Improvement
> Components: API / Python
>Reporter: godfrey he
>Assignee: Nicholas Jiang
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
>
> [FLINK-16366|https://issues.apache.org/jira/browse/FLINK-16366] supports
> executing a statement and returning a {{TableResult}} object, which could get
> {{JobClient}} (to associates the submitted Flink job), collect the execution
> result, or print the execution result. In Python, we should also introduce
> python TableResult class to make sure consistent with Java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-17303) Return TableResult for Python TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-17303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116405#comment-17116405
]
Dian Fu commented on FLINK-17303:
-
[~hequn8128] Could we also backport this to 1.11.0 as:
- It was originally in 1.11.0 and we just revert it because the added tests are
not stable and so I think it should be fine to add it back to 1.11.0 after we
fixed the test stability issue [~zjwang] What's your thought?
- It affects the usability of a few APIs such as "execute_sql" a lot without
this PR as they will have to return a Java TableResult object instead of a
Python TableResult object. Python users are not aware of this and they have to
lookup the Java docs to know how to use these Python APIs. Besides, it
introduces potential backward compatibility issues between 1.11 and 1.12.
What's your thought?
> Return TableResult for Python TableEnvironment
> --
>
> Key: FLINK-17303
> URL: https://issues.apache.org/jira/browse/FLINK-17303
> Project: Flink
> Issue Type: Improvement
> Components: API / Python
>Reporter: godfrey he
>Assignee: Nicholas Jiang
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
>
> [FLINK-16366|https://issues.apache.org/jira/browse/FLINK-16366] supports
> executing a statement and returning a {{TableResult}} object, which could get
> {{JobClient}} (to associates the submitted Flink job), collect the execution
> result, or print the execution result. In Python, we should also introduce
> python TableResult class to make sure consistent with Java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-17303) Return TableResult for Python TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-17303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116464#comment-17116464
]
Hequn Cheng commented on FLINK-17303:
-
[~dian.fu] I do not have strong opinions on this. The feature is not stable
enough at that time and misses the 1.11 deadline when it is ready, so I had not
ported it into 1.11. I would ok to port it into 1.11 if there are no objections
from our release managers [~zjwang] [~pnowojski].
> Return TableResult for Python TableEnvironment
> --
>
> Key: FLINK-17303
> URL: https://issues.apache.org/jira/browse/FLINK-17303
> Project: Flink
> Issue Type: Improvement
> Components: API / Python
>Reporter: godfrey he
>Assignee: Nicholas Jiang
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
>
> [FLINK-16366|https://issues.apache.org/jira/browse/FLINK-16366] supports
> executing a statement and returning a {{TableResult}} object, which could get
> {{JobClient}} (to associates the submitted Flink job), collect the execution
> result, or print the execution result. In Python, we should also introduce
> python TableResult class to make sure consistent with Java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-17303) Return TableResult for Python TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-17303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118588#comment-17118588
]
Dian Fu commented on FLINK-17303:
-
Hi [~hequn8128], I have discussed with [~pnowojski] offline about this issue
and he has agreed to back-port this PR to 1.11. Thanks [~pnowojski] for your
support!
> Return TableResult for Python TableEnvironment
> --
>
> Key: FLINK-17303
> URL: https://issues.apache.org/jira/browse/FLINK-17303
> Project: Flink
> Issue Type: Improvement
> Components: API / Python
>Reporter: godfrey he
>Assignee: Nicholas Jiang
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
>
> [FLINK-16366|https://issues.apache.org/jira/browse/FLINK-16366] supports
> executing a statement and returning a {{TableResult}} object, which could get
> {{JobClient}} (to associates the submitted Flink job), collect the execution
> result, or print the execution result. In Python, we should also introduce
> python TableResult class to make sure consistent with Java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-17303) Return TableResult for Python TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-17303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119287#comment-17119287
]
Hequn Cheng commented on FLINK-17303:
-
Resolved in 1.11.0 via 386cea7beccf10fd5893ab2d960ec886a8acfdd0
> Return TableResult for Python TableEnvironment
> --
>
> Key: FLINK-17303
> URL: https://issues.apache.org/jira/browse/FLINK-17303
> Project: Flink
> Issue Type: Improvement
> Components: API / Python
>Reporter: godfrey he
>Assignee: Nicholas Jiang
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
>
> [FLINK-16366|https://issues.apache.org/jira/browse/FLINK-16366] supports
> executing a statement and returning a {{TableResult}} object, which could get
> {{JobClient}} (to associates the submitted Flink job), collect the execution
> result, or print the execution result. In Python, we should also introduce
> python TableResult class to make sure consistent with Java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
