[jira] [Commented] (FLINK-17521) Remove `com.ibm.icu` dependency from table-common
[ https://issues.apache.org/jira/browse/FLINK-17521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17336201#comment-17336201 ] Flink Jira Bot commented on FLINK-17521: This issue was labeled "stale-major" 7 ago and has not received any updates so it is being deprioritized. If this ticket is actually Major, please raise the priority and ask a committer to assign you the issue or revive the public discussion. > Remove `com.ibm.icu` dependency from table-common > - > > Key: FLINK-17521 > URL: https://issues.apache.org/jira/browse/FLINK-17521 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Reporter: Timo Walther >Priority: Major > Labels: stale-major > > The `com.ibm.icu` dependency has been added recently to the `table-common` > module. > Since this module is used by many connectors and libraries, we should discuss > to remove it again. > Especially, because now there is also another `Row.of()` in the classpath of > the API. Which can be very confusing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17521) Remove `com.ibm.icu` dependency from table-common
[ https://issues.apache.org/jira/browse/FLINK-17521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327851#comment-17327851 ] Flink Jira Bot commented on FLINK-17521: This major issue is unassigned and itself and all of its Sub-Tasks have not been updated for 30 days. So, it has been labeled "stale-major". If this ticket is indeed "major", please either assign yourself or give an update. Afterwards, please remove the label. In 7 days the issue will be deprioritized. > Remove `com.ibm.icu` dependency from table-common > - > > Key: FLINK-17521 > URL: https://issues.apache.org/jira/browse/FLINK-17521 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Reporter: Timo Walther >Priority: Major > Labels: stale-major > > The `com.ibm.icu` dependency has been added recently to the `table-common` > module. > Since this module is used by many connectors and libraries, we should discuss > to remove it again. > Especially, because now there is also another `Row.of()` in the classpath of > the API. Which can be very confusing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17521) Remove `com.ibm.icu` dependency from table-common
[ https://issues.apache.org/jira/browse/FLINK-17521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104026#comment-17104026 ] Jark Wu commented on FLINK-17521: - I found that `com.ibm.icu` contains some classes with the same name with JDK, e.g. BigDecimal, TimeZone. I think we should get rid of it (at least from the table-common). > Remove `com.ibm.icu` dependency from table-common > - > > Key: FLINK-17521 > URL: https://issues.apache.org/jira/browse/FLINK-17521 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Timo Walther >Priority: Major > > The `com.ibm.icu` dependency has been added recently to the `table-common` > module. > Since this module is used by many connectors and libraries, we should discuss > to remove it again. > Especially, because now there is also another `Row.of()` in the classpath of > the API. Which can be very confusing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17521) Remove `com.ibm.icu` dependency from table-common
[ https://issues.apache.org/jira/browse/FLINK-17521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100888#comment-17100888 ] godfrey he commented on FLINK-17521: It's just a utility which is used by TableResultImpl#print() in `table-api-java` and `CliTableauResultView` in `sql-client` now. In `table-common`, there is a `utils` package which contains utility classes used by other modules. while in `table-api-java`, I think only APIs and must-have implementations should be there. > Remove `com.ibm.icu` dependency from table-common > - > > Key: FLINK-17521 > URL: https://issues.apache.org/jira/browse/FLINK-17521 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Timo Walther >Priority: Major > > The `com.ibm.icu` dependency has been added recently to the `table-common` > module. > Since this module is used by many connectors and libraries, we should discuss > to remove it again. > Especially, because now there is also another `Row.of()` in the classpath of > the API. Which can be very confusing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17521) Remove `com.ibm.icu` dependency from table-common
[ https://issues.apache.org/jira/browse/FLINK-17521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100520#comment-17100520 ] Timo Walther commented on FLINK-17521: -- If we need a lot of code from this dependency, I guess we have to keep it there. But why is it in `table-common`? It is an API thing and should be in `table-api-java`, no? > Remove `com.ibm.icu` dependency from table-common > - > > Key: FLINK-17521 > URL: https://issues.apache.org/jira/browse/FLINK-17521 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Timo Walther >Priority: Major > > The `com.ibm.icu` dependency has been added recently to the `table-common` > module. > Since this module is used by many connectors and libraries, we should discuss > to remove it again. > Especially, because now there is also another `Row.of()` in the classpath of > the API. Which can be very confusing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17521) Remove `com.ibm.icu` dependency from table-common
[ https://issues.apache.org/jira/browse/FLINK-17521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100414#comment-17100414 ] godfrey he commented on FLINK-17521: [~twalthr], This dependency aims to solve the problem which reported in [FLINK-16464|https://issues.apache.org/jira/browse/FLINK-16464]. When I implement [FLINK-16366|https://issues.apache.org/jira/browse/FLINK-16366], I discussed offline with the author of whether we need this dependency or we do the similar work by ourself. We find there's a lot of lines of code. So I introduce `com.ibm.icu` dependency in table-common. I mark the scope of the dependency as provided to avoid packaging `com.ibm.icu` into table-common.jar. If we really want to remove this dependency, I agree we can copy some utility methods into table-common. > Remove `com.ibm.icu` dependency from table-common > - > > Key: FLINK-17521 > URL: https://issues.apache.org/jira/browse/FLINK-17521 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Timo Walther >Priority: Major > > The `com.ibm.icu` dependency has been added recently to the `table-common` > module. > Since this module is used by many connectors and libraries, we should discuss > to remove it again. > Especially, because now there is also another `Row.of()` in the classpath of > the API. Which can be very confusing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17521) Remove `com.ibm.icu` dependency from table-common
[ https://issues.apache.org/jira/browse/FLINK-17521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099692#comment-17099692 ] Timo Walther commented on FLINK-17521: -- [~godfreyhe] could you investigate this? What do we actually need from this dependency? Can we just copy some utility methods instead? > Remove `com.ibm.icu` dependency from table-common > - > > Key: FLINK-17521 > URL: https://issues.apache.org/jira/browse/FLINK-17521 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Timo Walther >Priority: Major > > The `com.ibm.icu` dependency has been added recently to the `table-common` > module. > Since this module is used by many connectors and libraries, we should discuss > to remove it again. > Especially, because now there is also another `Row.of()` in the classpath of > the API. Which can be very confusing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
