[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201894#comment-17201894 ] Di Xu commented on FLINK-17613: --- [~rmetzger] and [~fly_in_gis] I would like to take this ticket. Here is the proposed solution: 1. Determine kubernetes version range to test against minikube follows[1] the Kubernetes Version and Version Skew Support Policy[2] which indicates that the most recent three minor releases are maintained. At the time of writing, v1.19.2, v1.18.9 and v1.17.12 are versions we should test against according to the release page[3]. I am not aware any API to obtain the versions so my plan is to put them into common_kubernetes.sh. If you know better ways please suggest here. 2. Modify test_kubernetes_*.sh to loop over the versions and tests like before. Moreover, * in case of Linux, add --kubernetes-version=<> to minikube command to start specific kubernetes version * in case of Non-Linux, check the pre-started kubernetes version by 'kubectl version --short' (follows the minikube status check) and ensure it matches the version we want to test against, otherwise fails the test and give hint to user. [1] [https://minikube.sigs.k8s.io/docs/handbook/config/#selecting-a-kubernetes-version] [2] [https://kubernetes.io/docs/setup/release/version-skew-policy/] [3] [https://github.com/kubernetes/kubernetes/releases] > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Priority: Major > Labels: starter > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201928#comment-17201928 ] Yang Wang commented on FLINK-17613: --- Make sense to me. [~rmetzger] Could you assign this ticket to [~xudi] so that he could start to work on this ticket? I am glad to help with the review. > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Priority: Major > Labels: starter > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177653#comment-17177653 ] Robert Metzger commented on FLINK-17613: I still think it makes sense to test against multiple versions. [~fly_in_gis] are you interested in addressing this? Or should we mark this as a "starter" task, and hope an external contributor is fixing this? > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Priority: Major > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178692#comment-17178692 ] Yang Wang commented on FLINK-17613: --- Hi [~rmetzger], i think this ticket could be marked with "starter" for some new contributors. And i am glad to help with review. Moreover, if no contributors are going to do this task, i could take over and finish it. > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Priority: Major > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203766#comment-17203766 ] Robert Metzger commented on FLINK-17613: Thanks for working on this [~xudi]. I've assigned you. > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Priority: Major > Labels: starter > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210844#comment-17210844 ] Di Xu commented on FLINK-17613: --- PR is ready and CI has passed. [~fly_in_gis] could you help to review the code? Please note one minor change to the initial solution: - for non-linux os (normally it is the developer's environment), just test against user-installed k8s cluster no matter what version it is. > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Assignee: Di Xu >Priority: Major > Labels: pull-request-available, starter > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211509#comment-17211509 ] Yang Wang commented on FLINK-17613: --- [~xudi] Thanks a lot for working on this. I will have a look before next Monday. > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Assignee: Di Xu >Priority: Major > Labels: pull-request-available, starter > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216494#comment-17216494 ] Di Xu commented on FLINK-17613: --- [~fly_in_gis] Just a kindly reminder that this PR is still waiting for review. A merge conflict has been resolved during waiting. To prevent further re-work, would you mind to review this sooner? Thanks a lot! > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Assignee: Di Xu >Priority: Major > Labels: pull-request-available, starter > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17323021#comment-17323021 ] Flink Jira Bot commented on FLINK-17613: This issue is assigned but has not received an update in 7 days so it has been labeled "stale-assigned". If you are still working on the issue, please give an update and remove the label. If you are no longer working on the issue, please unassign so someone else may work on it. In 7 days the issue will be automatically unassigned. > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Assignee: Di Xu >Priority: Major > Labels: pull-request-available, stale-assigned, starter > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions
[ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333745#comment-17333745 ] Flink Jira Bot commented on FLINK-17613: This issue was marked "stale-assigned" and has not received an update in 7 days. It is now automatically unassigned. If you are still working on it, you can assign it to yourself again. Please also give an update about the status of the work. > Run K8s related e2e tests with multiple K8s versions > > > Key: FLINK-17613 > URL: https://issues.apache.org/jira/browse/FLINK-17613 > Project: Flink > Issue Type: Improvement > Components: Deployment / Kubernetes, Tests >Reporter: Yang Wang >Assignee: Di Xu >Priority: Major > Labels: pull-request-available, stale-assigned, starter > > Follow the discussion in this PR [1]. > If we could run the K8s related e2e tests in multiple versions(the latest > version, oldest maintained version, etc.), it will help us to find the > usability issues earlier before users post them in the user ML[2]. > [1].https://github.com/apache/flink/pull/12071#discussion_r422838483 > [2].https://lists.apache.org/list.html?u...@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s -- This message was sent by Atlassian Jira (v8.3.4#803005)
