[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388971#comment-14388971 ] ASF GitHub Bot commented on FLINK-1766: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/511 Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Improvement Reporter: Sibao Hong Assignee: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388912#comment-14388912 ] ASF GitHub Bot commented on FLINK-1766: --- Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-88183433 LGTM. Will merge later today. Thanks! Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Improvement Reporter: Sibao Hong Assignee: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372838#comment-14372838 ] ASF GitHub Bot commented on FLINK-1766: --- GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/511 [FLINK-1766]Fix the bug of equals function of FSKey The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return true You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink Bug_Flink_1776 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #511 commit ab0ae5ece5e641455fa819b372a742ed607c183d Author: hongsibao hongsi...@huawei.com Date: 2015-03-21T15:12:58Z [FLINK-1766]Fix the bug of equals function of FSKey Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372839#comment-14372839 ] ASF GitHub Bot commented on FLINK-1766: --- Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/509 Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372721#comment-14372721 ] ASF GitHub Bot commented on FLINK-1766: --- GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/509 [FLINK-1766]Fix the bug of equals function of FSKey The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return True. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink bug_equals_3.21 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/509.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #509 commit 68de654200b796c45e2f250c0d359c56a3d474bc Author: Sibao Hong hongsi...@huawei.com Date: 2015-03-13T07:03:51Z Merge pull request #1 from apache/master update commit 07c20a40ccbfc886344bde5c26ed3605a799220a Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-18T09:45:49Z Merge branch 'master' of https://github.com/apache/flink commit 914f06e856e7680500a2c4c10390b701872c49fc Author: hongsibao hongsi...@huawei.com Date: 2015-03-18T15:44:12Z Merge remote-tracking branch 'upstream/master' commit 17fd72dc87ff652362bbda159f09e14130ea3e93 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-19T07:28:43Z Merge branch 'master' of https://github.com/apache/flink commit 16e3a6c1c2d0ba4f73ed7854ce60e405791bb976 Author: hongsibao hongsi...@huawei.com Date: 2015-03-19T15:53:24Z Merge branch 'master' of https://github.com/matadorhong/flink commit 86253a304427620b570d52abee16d6ef561f6de4 Author: hongsibao hongsi...@huawei.com Date: 2015-03-19T15:55:17Z Merge remote-tracking branch 'upstream/master' commit 2495512d32554668efd2972866833b9f7033d7f6 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-20T01:23:49Z Merge branch 'master' of https://github.com/apache/flink commit 80bbc423d22f437c4b3a20f28e0f4ec6866fc14d Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-20T01:24:04Z Merge branch 'master' of https://github.com/matadorhong/flink commit cd969f20eca52442bd84212757fa3842e54c6099 Author: hongsibao hongsi...@huawei.com Date: 2015-03-20T16:42:25Z Merge remote-tracking branch 'upstream/master' commit 89d2bb56ec5c92579b073c9d963d03622f34d4bb Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-21T02:25:02Z Merge branch 'master' of https://github.com/matadorhong/flink commit 8a412681b281889a45bae96b8e129efc15625ae3 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-21T03:52:19Z Merge remote-tracking branch 'upstream/master' commit eeb3469a2c0350e3c4251dccf5947f7458e29657 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-21T12:49:05Z Fix the bug of equals function of FSKey. Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372970#comment-14372970 ] ASF GitHub Bot commented on FLINK-1766: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84423950 If you are interested: Here are some simple guidelines on how to format code and create easy to merge commits for pull requests: http://flink.apache.org/coding_guidelines.html Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372966#comment-14372966 ] ASF GitHub Bot commented on FLINK-1766: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84423820 Looks good. This seems more like an optimization, than a bug, Before we can merge the change, it needs to be brought in sync with the code style. Currently, the checkstyle rules reject the code for using spaces rather than tabs. Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374744#comment-14374744 ] ASF GitHub Bot commented on FLINK-1766: --- Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84489355 Great thanks to Ewen. I will first have a study of how to format code. Then pull a request. Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374752#comment-14374752 ] ASF GitHub Bot commented on FLINK-1766: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84494016 No problem. We are happy that you are interested to contribute :-) Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374751#comment-14374751 ] ASF GitHub Bot commented on FLINK-1766: --- Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84491491 Thanks for Ewen. That help me a lot to understand how to contribute to Flink. I will follow the guide in the future. Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
