[jira] [Commented] (FLINK-1794) Add test base for scalatest and adapt flink-ml test cases

2015-03-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388506#comment-14388506
 ] 

ASF GitHub Bot commented on FLINK-1794:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/540


 Add test base for scalatest and adapt flink-ml test cases
 -

 Key: FLINK-1794
 URL: https://issues.apache.org/jira/browse/FLINK-1794
 Project: Flink
  Issue Type: Improvement
Reporter: Till Rohrmann
Assignee: Till Rohrmann

 Currently, the flink-ml test cases use the standard {{ExecutionEnvironment}} 
 which can cause problems in parallel test executions as they happen on 
 Travis. For these tests it would be helpful to have an appropriate Scala test 
 base which instantiates a {{ForkableFlinkMiniCluster}} and sets the 
 {{ExecutionEnvironment}} appropriately.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1794) Add test base for scalatest and adapt flink-ml test cases

2015-03-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386867#comment-14386867
 ] 

ASF GitHub Bot commented on FLINK-1794:
---

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/540#issuecomment-87723741
  
If there are no objections, then I would merge this PR. My other PRs depend 
on this as well.


 Add test base for scalatest and adapt flink-ml test cases
 -

 Key: FLINK-1794
 URL: https://issues.apache.org/jira/browse/FLINK-1794
 Project: Flink
  Issue Type: Improvement
Reporter: Till Rohrmann
Assignee: Till Rohrmann

 Currently, the flink-ml test cases use the standard {{ExecutionEnvironment}} 
 which can cause problems in parallel test executions as they happen on 
 Travis. For these tests it would be helpful to have an appropriate Scala test 
 base which instantiates a {{ForkableFlinkMiniCluster}} and sets the 
 {{ExecutionEnvironment}} appropriately.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1794) Add test base for scalatest and adapt flink-ml test cases

2015-03-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384362#comment-14384362
 ] 

ASF GitHub Bot commented on FLINK-1794:
---

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/540

[FLINK-1794] [test-utils] Adds test base for scala tests and adapts 
existing flink-ml tests

The test base for scala tests is implemented as a trait. The trait expects 
as a self-type ```Suite```. Mixing this trait into a test suite will start a 
```ForkableFlinkMiniCluster``` upon class loading and stops the respective 
cluster after all tests have been run.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink fixClusterMLITCases

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #540


commit 25542ddc1c88a92f5b50df7d3384ad2820560510
Author: Till Rohrmann trohrm...@apache.org
Date:   2015-03-27T18:40:42Z

[FLINK-1794] [test-utils] Adds test base for scala tests and adapts 
existing flink-ml tests




 Add test base for scalatest and adapt flink-ml test cases
 -

 Key: FLINK-1794
 URL: https://issues.apache.org/jira/browse/FLINK-1794
 Project: Flink
  Issue Type: Improvement
Reporter: Till Rohrmann
Assignee: Till Rohrmann

 Currently, the flink-ml test cases use the standard {{ExecutionEnvironment}} 
 which can cause problems in parallel test executions as they happen on 
 Travis. For these tests it would be helpful to have an appropriate Scala test 
 base which instantiates a {{ForkableFlinkMiniCluster}} and sets the 
 {{ExecutionEnvironment}} appropriately.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1794) Add test base for scalatest and adapt flink-ml test cases

2015-03-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384602#comment-14384602
 ] 

ASF GitHub Bot commented on FLINK-1794:
---

Github user fhueske commented on a diff in the pull request:

https://github.com/apache/flink/pull/540#discussion_r27329656
  
--- Diff: 
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -68,7 +68,7 @@

private final Optimizer compiler;   // the compiler to 
compile the jobs

-   private boolean printStatusDuringExecution = false;
--- End diff --

Is this an intentional change? Doesn't it change the behavior of all 
submission clients based on this class?


 Add test base for scalatest and adapt flink-ml test cases
 -

 Key: FLINK-1794
 URL: https://issues.apache.org/jira/browse/FLINK-1794
 Project: Flink
  Issue Type: Improvement
Reporter: Till Rohrmann
Assignee: Till Rohrmann

 Currently, the flink-ml test cases use the standard {{ExecutionEnvironment}} 
 which can cause problems in parallel test executions as they happen on 
 Travis. For these tests it would be helpful to have an appropriate Scala test 
 base which instantiates a {{ForkableFlinkMiniCluster}} and sets the 
 {{ExecutionEnvironment}} appropriately.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)