[jira] [Commented] (FLINK-18900) HiveCatalog should error out when listing partitions with an invalid spec

2020-08-27 Thread Jingsong Lee (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186237#comment-17186237
 ] 

Jingsong Lee commented on FLINK-18900:
--

Revert interface modification for 1.11: a5767906916548ca51bf2d4b9e75c833ea6522a6

> HiveCatalog should error out when listing partitions with an invalid spec
> -
>
> Key: FLINK-18900
> URL: https://issues.apache.org/jira/browse/FLINK-18900
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive
>Affects Versions: 1.11.1
>Reporter: Rui Li
>Assignee: Nicholas Jiang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>
> Take the following case as an example:
> {code}
> create table tbl (x int) partitioned by (p int);
> alter table tbl add partition (p=1);
> {code}
> If we list partitions with partition spec {{foo=1}}, HiveCatalog returns 
> partition {{p=1}}, which is wrong.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-18900) HiveCatalog should error out when listing partitions with an invalid spec

2020-08-27 Thread Rui Li (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186205#comment-17186205
 ] 

Rui Li commented on FLINK-18900:


Perhaps we can revert the change in 1.11, given that 1.11 doesn't support SHOW 
PARTITIONS.

> HiveCatalog should error out when listing partitions with an invalid spec
> -
>
> Key: FLINK-18900
> URL: https://issues.apache.org/jira/browse/FLINK-18900
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive
>Affects Versions: 1.11.1
>Reporter: Rui Li
>Assignee: Nicholas Jiang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>
> Take the following case as an example:
> {code}
> create table tbl (x int) partitioned by (p int);
> alter table tbl add partition (p=1);
> {code}
> If we list partitions with partition spec {{foo=1}}, HiveCatalog returns 
> partition {{p=1}}, which is wrong.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-18900) HiveCatalog should error out when listing partitions with an invalid spec

2020-08-27 Thread Jingsong Lee (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186204#comment-17186204
 ] 

Jingsong Lee commented on FLINK-18900:
--

We should not modify method throws exception for {{Catalog.listPartitions}}.

> HiveCatalog should error out when listing partitions with an invalid spec
> -
>
> Key: FLINK-18900
> URL: https://issues.apache.org/jira/browse/FLINK-18900
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive
>Affects Versions: 1.11.1
>Reporter: Rui Li
>Assignee: Nicholas Jiang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>
> Take the following case as an example:
> {code}
> create table tbl (x int) partitioned by (p int);
> alter table tbl add partition (p=1);
> {code}
> If we list partitions with partition spec {{foo=1}}, HiveCatalog returns 
> partition {{p=1}}, which is wrong.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-18900) HiveCatalog should error out when listing partitions with an invalid spec

2020-08-12 Thread Nicholas Jiang (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176173#comment-17176173
 ] 

Nicholas Jiang commented on FLINK-18900:


[~lzljs3620320] Could you please assign this to me? I have discussed with 
[~lirui].

> HiveCatalog should error out when listing partitions with an invalid spec
> -
>
> Key: FLINK-18900
> URL: https://issues.apache.org/jira/browse/FLINK-18900
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive
>Affects Versions: 1.11.1
>Reporter: Rui Li
>Priority: Major
> Fix For: 1.12.0, 1.11.2
>
>
> Take the following case as an example:
> {code}
> create table tbl (x int) partitioned by (p int);
> alter table tbl add partition (p=1);
> {code}
> If we list partitions with partition spec {{foo=1}}, HiveCatalog returns 
> partition {{p=1}}, which is wrong.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)