[jira] [Commented] (FLINK-19847) Can we create a fast support on the Nested table join?

2021-06-09 Thread Jingsong Lee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359829#comment-17359829
 ] 

Jingsong Lee commented on FLINK-19847:
--

Even if we want to support nested table join, it should be join on Row or Map 
instead of Array.

Because Array is a special struct with index... I am not sure it is safety to 
support equals on it.

> Can we create a fast support on the Nested table join?
> --
>
> Key: FLINK-19847
> URL: https://issues.apache.org/jira/browse/FLINK-19847
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Runtime
>Affects Versions: 1.11.1
>Reporter: xiaogang zhou
>Priority: Minor
>  Labels: auto-deprioritized-major
>
> In CommonLookupJoin, one TODO is 
> support nested lookup keys in the future,
> // currently we only support top-level lookup keys
>  
> can we create a fast support on the Array join? thx



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222084#comment-17222084
 ] 

Jark Wu commented on FLINK-19847:
-

Yes, it is recommended to specify multiple flat fields rather than array type. 

> Can we create a fast support on the Nested table join?
> --
>
> Key: FLINK-19847
> URL: https://issues.apache.org/jira/browse/FLINK-19847
> Project: Flink
>  Issue Type: Wish
>  Components: Table SQL / Planner, Table SQL / Runtime
>Affects Versions: 1.11.1
>Reporter: xiaogang zhou
>Priority: Major
>
> In CommonLookupJoin, one TODO is 
> support nested lookup keys in the future,
> // currently we only support top-level lookup keys
>  
> can we create a fast support on the Array join? thx



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread xiaogang zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222042#comment-17222042
 ] 

xiaogang zhou commented on FLINK-19847:
---

looks like splitJoinCondition already has some problem, Maybe i try multiple 
fields in ddl first. thx

> Can we create a fast support on the Nested table join?
> --
>
> Key: FLINK-19847
> URL: https://issues.apache.org/jira/browse/FLINK-19847
> Project: Flink
>  Issue Type: Wish
>  Components: API / DataStream
>Affects Versions: 1.11.1
>Reporter: xiaogang zhou
>Priority: Major
>
> In CommonLookupJoin, one TODO is 
> support nested lookup keys in the future,
> // currently we only support top-level lookup keys
>  
> can we create a fast support on the Array join? thx



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread xiaogang zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222033#comment-17222033
 ] 

xiaogang zhou commented on FLINK-19847:
---

In our situation, we use a Asynclookup for the redis and some inner rpc 
service. we combine multikey lookup to save the network cost. so the DDL uses 
the array type. 

where i try to join on array, some exception happens. and I notice the todo. 
looks like something need to be done in the 

extractConstantField? 

> Can we create a fast support on the Nested table join?
> --
>
> Key: FLINK-19847
> URL: https://issues.apache.org/jira/browse/FLINK-19847
> Project: Flink
>  Issue Type: Wish
>  Components: API / DataStream
>Affects Versions: 1.11.1
>Reporter: xiaogang zhou
>Priority: Major
>
> In CommonLookupJoin, one TODO is 
> support nested lookup keys in the future,
> // currently we only support top-level lookup keys
>  
> can we create a fast support on the Array join? thx



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222027#comment-17222027
 ] 

Jark Wu commented on FLINK-19847:
-

[~zhoujira86] could you describe your use case and why you need the nested 
lookup key join?

> Can we create a fast support on the Nested table join?
> --
>
> Key: FLINK-19847
> URL: https://issues.apache.org/jira/browse/FLINK-19847
> Project: Flink
>  Issue Type: Wish
>  Components: API / DataStream
>Affects Versions: 1.11.1
>Reporter: xiaogang zhou
>Priority: Major
>
> In CommonLookupJoin, one TODO is 
> support nested lookup keys in the future,
> // currently we only support top-level lookup keys
>  
> can we create a fast support on the Array join? thx



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread xiaogang zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222026#comment-17222026
 ] 

xiaogang zhou commented on FLINK-19847:
---

[~jark] Please help review, thx

> Can we create a fast support on the Nested table join?
> --
>
> Key: FLINK-19847
> URL: https://issues.apache.org/jira/browse/FLINK-19847
> Project: Flink
>  Issue Type: Wish
>  Components: API / DataStream
>Affects Versions: 1.11.1
>Reporter: xiaogang zhou
>Priority: Major
>
> In CommonLookupJoin, one TODO is 
> support nested lookup keys in the future,
> // currently we only support top-level lookup keys
>  
> can we create a fast support on the Array join? thx



--
This message was sent by Atlassian Jira
(v8.3.4#803005)