[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Leonard Xu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222193#comment-17222193
 ] 

Leonard Xu commented on FLINK-19854:


Sorry for the broken tests, I didn't rebase the latest master timely, I rebased 
two day before.

I'll keep this in mind. Thanks very much [~rmetzger] and [~jark]

> TableScanTest.testTemporalJoinOnUpsertSource fails
> --
>
> Key: FLINK-19854
> URL: https://issues.apache.org/jira/browse/FLINK-19854
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Assignee: Leonard Xu
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8482=logs=e25d5e7e-2a9c-5589-4940-0b638d75a414=a6e0f756-5bb9-5ea8-a468-5f60db442a29
> org.junit.ComparisonFailure: planAfter expected:<...me, 
> __TEMPORAL_JOIN_[]LEFT_KEY(currency), ...> but was:<...me, 
> __TEMPORAL_JOIN_[CONDITION_PRIMARY_KEY(currency0), 
> __TEMPORAL_JOIN_]LEFT_KEY(currency), ...>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at 
> org.apache.flink.table.planner.utils.DiffRepository.assertEquals(DiffRepository.java:436)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.assertEqualsOrExpand(TableTestBase.scala:478)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.doVerifyPlan(TableTestBase.scala:362)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.verifyPlan(TableTestBase.scala:275)
>   at 
> org.apache.flink.table.planner.plan.stream.sql.TableScanTest.testTemporalJoinOnUpsertSource(TableScanTest.scala:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Robert Metzger (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222129#comment-17222129
 ] 

Robert Metzger commented on FLINK-19854:


Yes, I recommend that if the change is likely to break due to other changes.

> TableScanTest.testTemporalJoinOnUpsertSource fails
> --
>
> Key: FLINK-19854
> URL: https://issues.apache.org/jira/browse/FLINK-19854
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Assignee: Leonard Xu
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8482=logs=e25d5e7e-2a9c-5589-4940-0b638d75a414=a6e0f756-5bb9-5ea8-a468-5f60db442a29
> org.junit.ComparisonFailure: planAfter expected:<...me, 
> __TEMPORAL_JOIN_[]LEFT_KEY(currency), ...> but was:<...me, 
> __TEMPORAL_JOIN_[CONDITION_PRIMARY_KEY(currency0), 
> __TEMPORAL_JOIN_]LEFT_KEY(currency), ...>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at 
> org.apache.flink.table.planner.utils.DiffRepository.assertEquals(DiffRepository.java:436)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.assertEqualsOrExpand(TableTestBase.scala:478)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.doVerifyPlan(TableTestBase.scala:362)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.verifyPlan(TableTestBase.scala:275)
>   at 
> org.apache.flink.table.planner.plan.stream.sql.TableScanTest.testTemporalJoinOnUpsertSource(TableScanTest.scala:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Jark Wu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222121#comment-17222121
 ] 

Jark Wu commented on FLINK-19854:
-

Thanks [~rmetzger], I just know that. Then we have to rebase the pull request 
manually after it is accepted. 

> TableScanTest.testTemporalJoinOnUpsertSource fails
> --
>
> Key: FLINK-19854
> URL: https://issues.apache.org/jira/browse/FLINK-19854
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Assignee: Leonard Xu
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8482=logs=e25d5e7e-2a9c-5589-4940-0b638d75a414=a6e0f756-5bb9-5ea8-a468-5f60db442a29
> org.junit.ComparisonFailure: planAfter expected:<...me, 
> __TEMPORAL_JOIN_[]LEFT_KEY(currency), ...> but was:<...me, 
> __TEMPORAL_JOIN_[CONDITION_PRIMARY_KEY(currency0), 
> __TEMPORAL_JOIN_]LEFT_KEY(currency), ...>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at 
> org.apache.flink.table.planner.utils.DiffRepository.assertEquals(DiffRepository.java:436)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.assertEqualsOrExpand(TableTestBase.scala:478)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.doVerifyPlan(TableTestBase.scala:362)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.verifyPlan(TableTestBase.scala:275)
>   at 
> org.apache.flink.table.planner.plan.stream.sql.TableScanTest.testTemporalJoinOnUpsertSource(TableScanTest.scala:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Robert Metzger (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222116#comment-17222116
 ] 

Robert Metzger commented on FLINK-19854:


Thanks a lot for fixing this so quickly!

> TableScanTest.testTemporalJoinOnUpsertSource fails
> --
>
> Key: FLINK-19854
> URL: https://issues.apache.org/jira/browse/FLINK-19854
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Assignee: Leonard Xu
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8482=logs=e25d5e7e-2a9c-5589-4940-0b638d75a414=a6e0f756-5bb9-5ea8-a468-5f60db442a29
> org.junit.ComparisonFailure: planAfter expected:<...me, 
> __TEMPORAL_JOIN_[]LEFT_KEY(currency), ...> but was:<...me, 
> __TEMPORAL_JOIN_[CONDITION_PRIMARY_KEY(currency0), 
> __TEMPORAL_JOIN_]LEFT_KEY(currency), ...>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at 
> org.apache.flink.table.planner.utils.DiffRepository.assertEquals(DiffRepository.java:436)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.assertEqualsOrExpand(TableTestBase.scala:478)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.doVerifyPlan(TableTestBase.scala:362)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.verifyPlan(TableTestBase.scala:275)
>   at 
> org.apache.flink.table.planner.plan.stream.sql.TableScanTest.testTemporalJoinOnUpsertSource(TableScanTest.scala:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Robert Metzger (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222115#comment-17222115
 ] 

Robert Metzger commented on FLINK-19854:


Pull requests are not rebased to the latest master when they are build.

> TableScanTest.testTemporalJoinOnUpsertSource fails
> --
>
> Key: FLINK-19854
> URL: https://issues.apache.org/jira/browse/FLINK-19854
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Assignee: Leonard Xu
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8482=logs=e25d5e7e-2a9c-5589-4940-0b638d75a414=a6e0f756-5bb9-5ea8-a468-5f60db442a29
> org.junit.ComparisonFailure: planAfter expected:<...me, 
> __TEMPORAL_JOIN_[]LEFT_KEY(currency), ...> but was:<...me, 
> __TEMPORAL_JOIN_[CONDITION_PRIMARY_KEY(currency0), 
> __TEMPORAL_JOIN_]LEFT_KEY(currency), ...>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at 
> org.apache.flink.table.planner.utils.DiffRepository.assertEquals(DiffRepository.java:436)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.assertEqualsOrExpand(TableTestBase.scala:478)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.doVerifyPlan(TableTestBase.scala:362)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.verifyPlan(TableTestBase.scala:275)
>   at 
> org.apache.flink.table.planner.plan.stream.sql.TableScanTest.testTemporalJoinOnUpsertSource(TableScanTest.scala:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Jark Wu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222113#comment-17222113
 ] 

Jark Wu commented on FLINK-19854:
-

Hi [~rmetzger], I'm wondering will the pull request build not rebase to the 
latest master branch? 
The case {{testTemporalJoinOnUpsertSource}} is merged last night, but this 
build for the pull request https://github.com/apache/flink/pull/13300 (which 
breaks the test) is triggered and passed today. 

> TableScanTest.testTemporalJoinOnUpsertSource fails
> --
>
> Key: FLINK-19854
> URL: https://issues.apache.org/jira/browse/FLINK-19854
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Assignee: Leonard Xu
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8482=logs=e25d5e7e-2a9c-5589-4940-0b638d75a414=a6e0f756-5bb9-5ea8-a468-5f60db442a29
> org.junit.ComparisonFailure: planAfter expected:<...me, 
> __TEMPORAL_JOIN_[]LEFT_KEY(currency), ...> but was:<...me, 
> __TEMPORAL_JOIN_[CONDITION_PRIMARY_KEY(currency0), 
> __TEMPORAL_JOIN_]LEFT_KEY(currency), ...>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at 
> org.apache.flink.table.planner.utils.DiffRepository.assertEquals(DiffRepository.java:436)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.assertEqualsOrExpand(TableTestBase.scala:478)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.doVerifyPlan(TableTestBase.scala:362)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.verifyPlan(TableTestBase.scala:275)
>   at 
> org.apache.flink.table.planner.plan.stream.sql.TableScanTest.testTemporalJoinOnUpsertSource(TableScanTest.scala:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Robert Metzger (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222091#comment-17222091
 ] 

Robert Metzger commented on FLINK-19854:


2 failures in a row. Probably a broken test:
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8488=logs=e25d5e7e-2a9c-5589-4940-0b638d75a414=a6e0f756-5bb9-5ea8-a468-5f60db442a29
[~jark]

> TableScanTest.testTemporalJoinOnUpsertSource fails
> --
>
> Key: FLINK-19854
> URL: https://issues.apache.org/jira/browse/FLINK-19854
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Priority: Major
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8482=logs=e25d5e7e-2a9c-5589-4940-0b638d75a414=a6e0f756-5bb9-5ea8-a468-5f60db442a29
> org.junit.ComparisonFailure: planAfter expected:<...me, 
> __TEMPORAL_JOIN_[]LEFT_KEY(currency), ...> but was:<...me, 
> __TEMPORAL_JOIN_[CONDITION_PRIMARY_KEY(currency0), 
> __TEMPORAL_JOIN_]LEFT_KEY(currency), ...>
>   at org.junit.Assert.assertEquals(Assert.java:115)
>   at 
> org.apache.flink.table.planner.utils.DiffRepository.assertEquals(DiffRepository.java:436)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.assertEqualsOrExpand(TableTestBase.scala:478)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.doVerifyPlan(TableTestBase.scala:362)
>   at 
> org.apache.flink.table.planner.utils.TableTestUtilBase.verifyPlan(TableTestBase.scala:275)
>   at 
> org.apache.flink.table.planner.plan.stream.sql.TableScanTest.testTemporalJoinOnUpsertSource(TableScanTest.scala:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)