[jira] [Commented] (FLINK-20013) BoundedBlockingSubpartition may leak network buffer if task is failed or canceled

2020-11-12 Thread Arvid Heise (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230904#comment-17230904
 ] 

Arvid Heise commented on FLINK-20013:
-

Merged into 1.11 as 6626d396acbe14bbec1a9cc2ff1539ff94119046.

Merged into 1.10 as 10f155e3458161b74da7bf45691247b50175da4b.

> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled
> -
>
> Key: FLINK-20013
> URL: https://issues.apache.org/jira/browse/FLINK-20013
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Yingjie Cao
>Assignee: Nicholas Jiang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled. We need to recycle the current BufferConsumer when task is failed 
> or canceled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-20013) BoundedBlockingSubpartition may leak network buffer if task is failed or canceled

2020-11-11 Thread Arvid Heise (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230407#comment-17230407
 ] 

Arvid Heise commented on FLINK-20013:
-

Could you please create PRs for the backports, such that we can see with CI 
that no side-effects are happening?

> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled
> -
>
> Key: FLINK-20013
> URL: https://issues.apache.org/jira/browse/FLINK-20013
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Yingjie Cao
>Assignee: Nicholas Jiang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled. We need to recycle the current BufferConsumer when task is failed 
> or canceled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-20013) BoundedBlockingSubpartition may leak network buffer if task is failed or canceled

2020-11-10 Thread Nicholas Jiang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229652#comment-17229652
 ] 

Nicholas Jiang commented on FLINK-20013:


[~AHeise], IMO, I think it should be backported to 1.11 (and 1.10). 
cc [~kevin.cyj]

> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled
> -
>
> Key: FLINK-20013
> URL: https://issues.apache.org/jira/browse/FLINK-20013
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Yingjie Cao
>Assignee: Nicholas Jiang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled. We need to recycle the current BufferConsumer when task is failed 
> or canceled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-20013) BoundedBlockingSubpartition may leak network buffer if task is failed or canceled

2020-11-10 Thread Arvid Heise (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229454#comment-17229454
 ] 

Arvid Heise commented on FLINK-20013:
-

Shouldn't that be backported to 1.11 (and 1.10)?

> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled
> -
>
> Key: FLINK-20013
> URL: https://issues.apache.org/jira/browse/FLINK-20013
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Yingjie Cao
>Assignee: Nicholas Jiang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled. We need to recycle the current BufferConsumer when task is failed 
> or canceled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-20013) BoundedBlockingSubpartition may leak network buffer if task is failed or canceled

2020-11-10 Thread Arvid Heise (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229453#comment-17229453
 ] 

Arvid Heise commented on FLINK-20013:
-

Merged into master as c46ae271f11075a837bf5d8a66e2ffd2d73ffb28.

> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled
> -
>
> Key: FLINK-20013
> URL: https://issues.apache.org/jira/browse/FLINK-20013
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Yingjie Cao
>Assignee: Nicholas Jiang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled. We need to recycle the current BufferConsumer when task is failed 
> or canceled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-20013) BoundedBlockingSubpartition may leak network buffer if task is failed or canceled

2020-11-08 Thread Zhu Zhu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228387#comment-17228387
 ] 

Zhu Zhu commented on FLINK-20013:
-

Hi [~nicholasjiang], I can see that [~pnowojski] has assigned this ticket to 
you.
Feel free to open a fix for it.

> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled
> -
>
> Key: FLINK-20013
> URL: https://issues.apache.org/jira/browse/FLINK-20013
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Yingjie Cao
>Assignee: Nicholas Jiang
>Priority: Major
> Fix For: 1.12.0
>
>
> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled. We need to recycle the current BufferConsumer when task is failed 
> or canceled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-20013) BoundedBlockingSubpartition may leak network buffer if task is failed or canceled

2020-11-06 Thread Nicholas Jiang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227265#comment-17227265
 ] 

Nicholas Jiang commented on FLINK-20013:


[~zhuzh], when task is failed or canceled,  the current BufferConsumer in 
BoundedBlockingSubpartition doesn't close which causes network buffer leak. 
Therefore the current BufferConsumer should be closed wheen task is failed or 
canceled.

> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled
> -
>
> Key: FLINK-20013
> URL: https://issues.apache.org/jira/browse/FLINK-20013
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Yingjie Cao
>Assignee: Nicholas Jiang
>Priority: Major
> Fix For: 1.12.0
>
>
> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled. We need to recycle the current BufferConsumer when task is failed 
> or canceled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-20013) BoundedBlockingSubpartition may leak network buffer if task is failed or canceled

2020-11-06 Thread Zhu Zhu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227228#comment-17227228
 ] 

Zhu Zhu commented on FLINK-20013:
-

[~nicholasjiang] Sorry but I do not know much about this issue.
cc [~zjwang] [~pnowojski] who can understand this problem.

> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled
> -
>
> Key: FLINK-20013
> URL: https://issues.apache.org/jira/browse/FLINK-20013
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Yingjie Cao
>Priority: Major
> Fix For: 1.12.0
>
>
> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled. We need to recycle the current BufferConsumer when task is failed 
> or canceled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-20013) BoundedBlockingSubpartition may leak network buffer if task is failed or canceled

2020-11-06 Thread Nicholas Jiang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227227#comment-17227227
 ] 

Nicholas Jiang commented on FLINK-20013:


[~zhuzh], I have already offline discussed with [~kevin.cyj]. I could work for 
this issue. Would you please assign this to me. I would like to fix this today.

> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled
> -
>
> Key: FLINK-20013
> URL: https://issues.apache.org/jira/browse/FLINK-20013
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Yingjie Cao
>Priority: Major
> Fix For: 1.12.0
>
>
> BoundedBlockingSubpartition may leak network buffer if task is failed or 
> canceled. We need to recycle the current BufferConsumer when task is failed 
> or canceled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)