[jira] [Commented] (FLINK-20051) SourceReaderTestBase.testAddSplitToExistingFetcher failed with NullPointerException

2020-11-09 Thread Stephan Ewen (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-20051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228794#comment-17228794
 ] 

Stephan Ewen commented on FLINK-20051:
--

The problem is that an in-initialized record batch is returned when the reader 
is woken up to handle the split change.

This line is the problem: 
https://github.com/apache/flink/blob/0b3f15ee598aa2b55706a4c3a30e2e529ac8f651/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java#L99

We need to add {{recordsBySplits.prepareForRead();}}.

I will push this fix with my next set of commits.

> SourceReaderTestBase.testAddSplitToExistingFetcher failed with 
> NullPointerException
> ---
>
> Key: FLINK-20051
> URL: https://issues.apache.org/jira/browse/FLINK-20051
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Common
>Affects Versions: 1.12.0
>Reporter: Dian Fu
>Assignee: Stephan Ewen
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=9322=logs=4be4ed2b-549a-533d-aa33-09e28e360cc8=0db94045-2aa0-53fa-f444-0130d6933518
> {code}
> 2020-11-08T21:49:29.6792941Z [ERROR] 
> testAddSplitToExistingFetcher(org.apache.flink.connector.kafka.source.reader.KafkaSourceReaderTest)
>   Time elapsed: 0.632 s  <<< ERROR!
> 2020-11-08T21:49:29.6793408Z java.lang.NullPointerException
> 2020-11-08T21:49:29.6793998Z  at 
> org.apache.flink.connector.kafka.source.reader.KafkaPartitionSplitReader$KafkaPartitionSplitRecords.nextSplit(KafkaPartitionSplitReader.java:363)
> 2020-11-08T21:49:29.6795970Z  at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.moveToNextSplit(SourceReaderBase.java:187)
> 2020-11-08T21:49:29.6796596Z  at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.getNextFetch(SourceReaderBase.java:159)
> 2020-11-08T21:49:29.6797317Z  at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.pollNext(SourceReaderBase.java:116)
> 2020-11-08T21:49:29.6797942Z  at 
> org.apache.flink.connector.testutils.source.reader.SourceReaderTestBase.testAddSplitToExistingFetcher(SourceReaderTestBase.java:98)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-20051) SourceReaderTestBase.testAddSplitToExistingFetcher failed with NullPointerException

2020-11-09 Thread Till Rohrmann (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-20051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228701#comment-17228701
 ] 

Till Rohrmann commented on FLINK-20051:
---

Another instance: 
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=9356=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5

> SourceReaderTestBase.testAddSplitToExistingFetcher failed with 
> NullPointerException
> ---
>
> Key: FLINK-20051
> URL: https://issues.apache.org/jira/browse/FLINK-20051
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Common
>Affects Versions: 1.12.0
>Reporter: Dian Fu
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=9322=logs=4be4ed2b-549a-533d-aa33-09e28e360cc8=0db94045-2aa0-53fa-f444-0130d6933518
> {code}
> 2020-11-08T21:49:29.6792941Z [ERROR] 
> testAddSplitToExistingFetcher(org.apache.flink.connector.kafka.source.reader.KafkaSourceReaderTest)
>   Time elapsed: 0.632 s  <<< ERROR!
> 2020-11-08T21:49:29.6793408Z java.lang.NullPointerException
> 2020-11-08T21:49:29.6793998Z  at 
> org.apache.flink.connector.kafka.source.reader.KafkaPartitionSplitReader$KafkaPartitionSplitRecords.nextSplit(KafkaPartitionSplitReader.java:363)
> 2020-11-08T21:49:29.6795970Z  at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.moveToNextSplit(SourceReaderBase.java:187)
> 2020-11-08T21:49:29.6796596Z  at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.getNextFetch(SourceReaderBase.java:159)
> 2020-11-08T21:49:29.6797317Z  at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.pollNext(SourceReaderBase.java:116)
> 2020-11-08T21:49:29.6797942Z  at 
> org.apache.flink.connector.testutils.source.reader.SourceReaderTestBase.testAddSplitToExistingFetcher(SourceReaderTestBase.java:98)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-20051) SourceReaderTestBase.testAddSplitToExistingFetcher failed with NullPointerException

2020-11-08 Thread Robert Metzger (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-20051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228355#comment-17228355
 ] 

Robert Metzger commented on FLINK-20051:


[~becket_qin] can you take a look at this failure?

> SourceReaderTestBase.testAddSplitToExistingFetcher failed with 
> NullPointerException
> ---
>
> Key: FLINK-20051
> URL: https://issues.apache.org/jira/browse/FLINK-20051
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Common
>Affects Versions: 1.12.0
>Reporter: Dian Fu
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=9322=logs=4be4ed2b-549a-533d-aa33-09e28e360cc8=0db94045-2aa0-53fa-f444-0130d6933518
> {code}
> 2020-11-08T21:49:29.6792941Z [ERROR] 
> testAddSplitToExistingFetcher(org.apache.flink.connector.kafka.source.reader.KafkaSourceReaderTest)
>   Time elapsed: 0.632 s  <<< ERROR!
> 2020-11-08T21:49:29.6793408Z java.lang.NullPointerException
> 2020-11-08T21:49:29.6793998Z  at 
> org.apache.flink.connector.kafka.source.reader.KafkaPartitionSplitReader$KafkaPartitionSplitRecords.nextSplit(KafkaPartitionSplitReader.java:363)
> 2020-11-08T21:49:29.6795970Z  at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.moveToNextSplit(SourceReaderBase.java:187)
> 2020-11-08T21:49:29.6796596Z  at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.getNextFetch(SourceReaderBase.java:159)
> 2020-11-08T21:49:29.6797317Z  at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.pollNext(SourceReaderBase.java:116)
> 2020-11-08T21:49:29.6797942Z  at 
> org.apache.flink.connector.testutils.source.reader.SourceReaderTestBase.testAddSplitToExistingFetcher(SourceReaderTestBase.java:98)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)