[jira] [Commented] (FLINK-20927) Update configuration option in YarnConfigOptions class
[ https://issues.apache.org/jira/browse/FLINK-20927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265847#comment-17265847 ] Robert Metzger commented on FLINK-20927: Merged to master in https://github.com/apache/flink/commit/49f8af05cb1abe236aa96dff91d511ccdeed3673 > Update configuration option in YarnConfigOptions class > -- > > Key: FLINK-20927 > URL: https://issues.apache.org/jira/browse/FLINK-20927 > Project: Flink > Issue Type: Improvement > Components: Deployment / YARN >Affects Versions: 1.12.0 >Reporter: Ruguo Yu >Assignee: Ruguo Yu >Priority: Minor > Labels: pull-request-available > Fix For: 1.13.0 > > Attachments: image-2021-01-11-18-36-20-723.png, > image-2021-01-11-18-36-44-811.png > > > There are many configuration options that use a not recommended method to > build in _YarnConfigOptions_ class, mainly include the following: > 1. Use the deprecated method 'defaultValue' directly instead of specifying > the data type. > !image-2021-01-11-18-36-20-723.png|width=842,height=90! > 2. Use String instead of Enum types. > !image-2021-01-11-18-36-44-811.png|width=1128,height=139! > > Therefore, for the above problem, we can update it with the new API, which > can also be consistent with KubernetesConfigOptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20927) Update configuration option in YarnConfigOptions class
[ https://issues.apache.org/jira/browse/FLINK-20927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264754#comment-17264754 ] Till Rohrmann commented on FLINK-20927: --- I've assigned it to you. > Update configuration option in YarnConfigOptions class > -- > > Key: FLINK-20927 > URL: https://issues.apache.org/jira/browse/FLINK-20927 > Project: Flink > Issue Type: Improvement > Components: Deployment / YARN >Affects Versions: 1.12.0 >Reporter: Ruguo Yu >Assignee: Ruguo Yu >Priority: Minor > Labels: pull-request-available > Fix For: 1.13.0 > > Attachments: image-2021-01-11-18-36-20-723.png, > image-2021-01-11-18-36-44-811.png > > > There are many configuration options that use a not recommended method to > build in _YarnConfigOptions_ class, mainly include the following: > 1. Use the deprecated method 'defaultValue' directly instead of specifying > the data type. > !image-2021-01-11-18-36-20-723.png|width=842,height=90! > 2. Use String instead of Enum types. > !image-2021-01-11-18-36-44-811.png|width=1128,height=139! > > Therefore, for the above problem, we can update it with the new API, which > can also be consistent with KubernetesConfigOptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20927) Update configuration option in YarnConfigOptions class
[ https://issues.apache.org/jira/browse/FLINK-20927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264732#comment-17264732 ] Ruguo Yu commented on FLINK-20927: -- Ok [~trohrmann] , could you assign it to me? THX! > Update configuration option in YarnConfigOptions class > -- > > Key: FLINK-20927 > URL: https://issues.apache.org/jira/browse/FLINK-20927 > Project: Flink > Issue Type: Improvement > Components: Deployment / YARN >Affects Versions: 1.12.0 >Reporter: Ruguo Yu >Priority: Minor > Labels: pull-request-available > Fix For: 1.13.0 > > Attachments: image-2021-01-11-18-36-20-723.png, > image-2021-01-11-18-36-44-811.png > > > There are many configuration options that use a not recommended method to > build in _YarnConfigOptions_ class, mainly include the following: > 1. Use the deprecated method 'defaultValue' directly instead of specifying > the data type. > !image-2021-01-11-18-36-20-723.png|width=842,height=90! > 2. Use String instead of Enum types. > !image-2021-01-11-18-36-44-811.png|width=1128,height=139! > > Therefore, for the above problem, we can update it with the new API, which > can also be consistent with KubernetesConfigOptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20927) Update configuration option in YarnConfigOptions class
[ https://issues.apache.org/jira/browse/FLINK-20927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264726#comment-17264726 ] Till Rohrmann commented on FLINK-20927: --- You can update them but it is not very important [~jiang7chengzitc]. > Update configuration option in YarnConfigOptions class > -- > > Key: FLINK-20927 > URL: https://issues.apache.org/jira/browse/FLINK-20927 > Project: Flink > Issue Type: Improvement > Components: Deployment / YARN >Affects Versions: 1.12.0 >Reporter: Ruguo Yu >Priority: Minor > Labels: pull-request-available > Fix For: 1.13.0 > > Attachments: image-2021-01-11-18-36-20-723.png, > image-2021-01-11-18-36-44-811.png > > > There are many configuration options that use a not recommended method to > build in _YarnConfigOptions_ class, mainly include the following: > 1. Use the deprecated method 'defaultValue' directly instead of specifying > the data type. > !image-2021-01-11-18-36-20-723.png|width=842,height=90! > 2. Use String instead of Enum types. > !image-2021-01-11-18-36-44-811.png|width=1128,height=139! > > Therefore, for the above problem, we can update it with the new API, which > can also be consistent with KubernetesConfigOptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20927) Update configuration option in YarnConfigOptions class
[ https://issues.apache.org/jira/browse/FLINK-20927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264152#comment-17264152 ] Ruguo Yu commented on FLINK-20927: -- cc [~trohrmann], for the above question, do we need to standardize these configuration option? > Update configuration option in YarnConfigOptions class > -- > > Key: FLINK-20927 > URL: https://issues.apache.org/jira/browse/FLINK-20927 > Project: Flink > Issue Type: Improvement > Components: Deployment / YARN >Affects Versions: 1.12.0 >Reporter: Ruguo Yu >Priority: Minor > Labels: pull-request-available > Fix For: 1.13.0 > > Attachments: image-2021-01-11-18-36-20-723.png, > image-2021-01-11-18-36-44-811.png > > > There are many configuration options that use a not recommended method to > build in _YarnConfigOptions_ class, mainly include the following: > 1. Use the deprecated method 'defaultValue' directly instead of specifying > the data type. > !image-2021-01-11-18-36-20-723.png|width=842,height=90! > 2. Use String instead of Enum types. > !image-2021-01-11-18-36-44-811.png|width=1128,height=139! > > Therefore, for the above problem, we can update it with the new API, which > can also be consistent with KubernetesConfigOptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
