[jira] [Commented] (FLINK-21139) ThresholdMeterTest.testMarkMultipleEvents unstable
[
https://issues.apache.org/jira/browse/FLINK-21139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275963#comment-17275963
]
Zhenqiu Huang commented on FLINK-21139:
---
[~xintongsong]
Make sense. Just created the PR. Please review it when you have time.
> ThresholdMeterTest.testMarkMultipleEvents unstable
> --
>
> Key: FLINK-21139
> URL: https://issues.apache.org/jira/browse/FLINK-21139
> Project: Flink
> Issue Type: Bug
> Components: API / Core, Benchmarks, Build System, Tests
> Environment: $ java -version && javac -version
> openjdk version "11.0.8" 2020-07-14
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10-202007292333)
> Eclipse OpenJ9 VM AdoptOpenJDK (build master-dc7cbe4bd, JRE 11 Linux
> riscv-64-Bit Compressed References 20200729_78 (JIT disabled, AOT disabled)
> OpenJ9 - dc7cbe4bd
> OMR - 1c0299f20
> JCL - 94b9d6d2c6 based on jdk-11.0.8+10)
> javac 11.0.8
> $ uname -a
> Linux test-gdams-debian10-riscv64-1.adoptopenjdk.net
> 5.0.0-rc1-56210-g0a657e0d72f0 #1 SMP Fri May 15 18:05:26 EDT 2020 riscv64
> GNU/Linux
> $ cat /proc/cpuinfo
> processor : 0
> hart : 1
> isa : rv64imafdc
> mmu : sv39
> uarch : sifive,rocket0
>Reporter: Ivan Serdyuk
>Assignee: Zhenqiu Huang
>Priority: Critical
> Labels: pull-request-available, test-stability
> Fix For: 1.13.0
>
>
> The test {{ThresholdMeterTest.testMarkMultipleEvents}} seems to be unstable.
> The version of Flink is
> ??$ git log -1??
> ??commit 6e77cfdff8a358adab4ab770a503197d95a64440 (HEAD -> master,
> origin/master, origin/HEAD)??
> ??Author: Roman Khachatryan ??
> ??Date: Fri Jan 22 14:39:48 2021 +0100??
> The test fails with the following exception:
> {code}
> Expected: a numeric value within <1.0E-6> of <40.0>
> but: <0.0> differed by <39.99>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at
> org.apache.flink.metrics.ThresholdMeterTest.testMarkMultipleEvents(ThresholdMeterTest.java:58)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:87)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
[jira] [Commented] (FLINK-21139) ThresholdMeterTest.testMarkMultipleEvents unstable
[
https://issues.apache.org/jira/browse/FLINK-21139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275790#comment-17275790
]
Xintong Song commented on FLINK-21139:
--
[~ZhenqiuHuang],
Maybe we can move {{ThreasholdMeter}} to {{org.apache.flink.runtime.metrics}}.
There's already {{TimerGauge}}, which also uses {{Clock}}.
> ThresholdMeterTest.testMarkMultipleEvents unstable
> --
>
> Key: FLINK-21139
> URL: https://issues.apache.org/jira/browse/FLINK-21139
> Project: Flink
> Issue Type: Bug
> Components: API / Core, Benchmarks, Build System, Tests
> Environment: $ java -version && javac -version
> openjdk version "11.0.8" 2020-07-14
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10-202007292333)
> Eclipse OpenJ9 VM AdoptOpenJDK (build master-dc7cbe4bd, JRE 11 Linux
> riscv-64-Bit Compressed References 20200729_78 (JIT disabled, AOT disabled)
> OpenJ9 - dc7cbe4bd
> OMR - 1c0299f20
> JCL - 94b9d6d2c6 based on jdk-11.0.8+10)
> javac 11.0.8
> $ uname -a
> Linux test-gdams-debian10-riscv64-1.adoptopenjdk.net
> 5.0.0-rc1-56210-g0a657e0d72f0 #1 SMP Fri May 15 18:05:26 EDT 2020 riscv64
> GNU/Linux
> $ cat /proc/cpuinfo
> processor : 0
> hart : 1
> isa : rv64imafdc
> mmu : sv39
> uarch : sifive,rocket0
>Reporter: Ivan Serdyuk
>Assignee: Zhenqiu Huang
>Priority: Critical
> Labels: test-stability
> Fix For: 1.13.0
>
>
> The test {{ThresholdMeterTest.testMarkMultipleEvents}} seems to be unstable.
> The version of Flink is
> ??$ git log -1??
> ??commit 6e77cfdff8a358adab4ab770a503197d95a64440 (HEAD -> master,
> origin/master, origin/HEAD)??
> ??Author: Roman Khachatryan ??
> ??Date: Fri Jan 22 14:39:48 2021 +0100??
> The test fails with the following exception:
> {code}
> Expected: a numeric value within <1.0E-6> of <40.0>
> but: <0.0> differed by <39.99>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at
> org.apache.flink.metrics.ThresholdMeterTest.testMarkMultipleEvents(ThresholdMeterTest.java:58)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:87)
> at
> org.apache.maven.surefire.junitcore.JUnit
[jira] [Commented] (FLINK-21139) ThresholdMeterTest.testMarkMultipleEvents unstable
[
https://issues.apache.org/jira/browse/FLINK-21139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275780#comment-17275780
]
Zhenqiu Huang commented on FLINK-21139:
---
[~trohrmann] [~xintongsong]
The ManualClock is defined in flink-core. Currently, ThresholdMeter is defined
in flink-metrics. I feel it is not wise to make flink-metrics dependent on
flink-core module. Any suggestions about this?
> ThresholdMeterTest.testMarkMultipleEvents unstable
> --
>
> Key: FLINK-21139
> URL: https://issues.apache.org/jira/browse/FLINK-21139
> Project: Flink
> Issue Type: Bug
> Components: API / Core, Benchmarks, Build System, Tests
> Environment: $ java -version && javac -version
> openjdk version "11.0.8" 2020-07-14
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10-202007292333)
> Eclipse OpenJ9 VM AdoptOpenJDK (build master-dc7cbe4bd, JRE 11 Linux
> riscv-64-Bit Compressed References 20200729_78 (JIT disabled, AOT disabled)
> OpenJ9 - dc7cbe4bd
> OMR - 1c0299f20
> JCL - 94b9d6d2c6 based on jdk-11.0.8+10)
> javac 11.0.8
> $ uname -a
> Linux test-gdams-debian10-riscv64-1.adoptopenjdk.net
> 5.0.0-rc1-56210-g0a657e0d72f0 #1 SMP Fri May 15 18:05:26 EDT 2020 riscv64
> GNU/Linux
> $ cat /proc/cpuinfo
> processor : 0
> hart : 1
> isa : rv64imafdc
> mmu : sv39
> uarch : sifive,rocket0
>Reporter: Ivan Serdyuk
>Assignee: Zhenqiu Huang
>Priority: Critical
> Labels: test-stability
> Fix For: 1.13.0
>
>
> The test {{ThresholdMeterTest.testMarkMultipleEvents}} seems to be unstable.
> The version of Flink is
> ??$ git log -1??
> ??commit 6e77cfdff8a358adab4ab770a503197d95a64440 (HEAD -> master,
> origin/master, origin/HEAD)??
> ??Author: Roman Khachatryan ??
> ??Date: Fri Jan 22 14:39:48 2021 +0100??
> The test fails with the following exception:
> {code}
> Expected: a numeric value within <1.0E-6> of <40.0>
> but: <0.0> differed by <39.99>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at
> org.apache.flink.metrics.ThresholdMeterTest.testMarkMultipleEvents(ThresholdMeterTest.java:58)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUni
[jira] [Commented] (FLINK-21139) ThresholdMeterTest.testMarkMultipleEvents unstable
[
https://issues.apache.org/jira/browse/FLINK-21139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272518#comment-17272518
]
Xintong Song commented on FLINK-21139:
--
Thanks [~oceanfish81] for reporting this and [~trohrmann] for looking into this.
+1 for improve the testability by injecting a {{Clock}}.
Thanks [~ZhenqiuHuang] for offering to fix this. I've assigned you, please go
ahead.
> ThresholdMeterTest.testMarkMultipleEvents unstable
> --
>
> Key: FLINK-21139
> URL: https://issues.apache.org/jira/browse/FLINK-21139
> Project: Flink
> Issue Type: Bug
> Components: API / Core, Benchmarks, Build System, Tests
> Environment: $ java -version && javac -version
> openjdk version "11.0.8" 2020-07-14
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10-202007292333)
> Eclipse OpenJ9 VM AdoptOpenJDK (build master-dc7cbe4bd, JRE 11 Linux
> riscv-64-Bit Compressed References 20200729_78 (JIT disabled, AOT disabled)
> OpenJ9 - dc7cbe4bd
> OMR - 1c0299f20
> JCL - 94b9d6d2c6 based on jdk-11.0.8+10)
> javac 11.0.8
> $ uname -a
> Linux test-gdams-debian10-riscv64-1.adoptopenjdk.net
> 5.0.0-rc1-56210-g0a657e0d72f0 #1 SMP Fri May 15 18:05:26 EDT 2020 riscv64
> GNU/Linux
> $ cat /proc/cpuinfo
> processor : 0
> hart : 1
> isa : rv64imafdc
> mmu : sv39
> uarch : sifive,rocket0
>Reporter: Ivan Serdyuk
>Assignee: Zhenqiu Huang
>Priority: Critical
> Labels: test-stability
> Fix For: 1.13.0
>
>
> The test {{ThresholdMeterTest.testMarkMultipleEvents}} seems to be unstable.
> The version of Flink is
> ??$ git log -1??
> ??commit 6e77cfdff8a358adab4ab770a503197d95a64440 (HEAD -> master,
> origin/master, origin/HEAD)??
> ??Author: Roman Khachatryan ??
> ??Date: Fri Jan 22 14:39:48 2021 +0100??
> The test fails with the following exception:
> {code}
> Expected: a numeric value within <1.0E-6> of <40.0>
> but: <0.0> differed by <39.99>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at
> org.apache.flink.metrics.ThresholdMeterTest.testMarkMultipleEvents(ThresholdMeterTest.java:58)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWr
[jira] [Commented] (FLINK-21139) ThresholdMeterTest.testMarkMultipleEvents unstable
[
https://issues.apache.org/jira/browse/FLINK-21139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272297#comment-17272297
]
Zhenqiu Huang commented on FLINK-21139:
---
[~trohrmann]
Sure. Please assign it to me to fix it today.
> ThresholdMeterTest.testMarkMultipleEvents unstable
> --
>
> Key: FLINK-21139
> URL: https://issues.apache.org/jira/browse/FLINK-21139
> Project: Flink
> Issue Type: Bug
> Components: API / Core, Benchmarks, Build System, Tests
> Environment: $ java -version && javac -version
> openjdk version "11.0.8" 2020-07-14
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10-202007292333)
> Eclipse OpenJ9 VM AdoptOpenJDK (build master-dc7cbe4bd, JRE 11 Linux
> riscv-64-Bit Compressed References 20200729_78 (JIT disabled, AOT disabled)
> OpenJ9 - dc7cbe4bd
> OMR - 1c0299f20
> JCL - 94b9d6d2c6 based on jdk-11.0.8+10)
> javac 11.0.8
> $ uname -a
> Linux test-gdams-debian10-riscv64-1.adoptopenjdk.net
> 5.0.0-rc1-56210-g0a657e0d72f0 #1 SMP Fri May 15 18:05:26 EDT 2020 riscv64
> GNU/Linux
> $ cat /proc/cpuinfo
> processor : 0
> hart : 1
> isa : rv64imafdc
> mmu : sv39
> uarch : sifive,rocket0
>Reporter: Ivan Serdyuk
>Priority: Critical
> Labels: test-stability
> Fix For: 1.13.0
>
>
> The test {{ThresholdMeterTest.testMarkMultipleEvents}} seems to be unstable.
> The version of Flink is
> ??$ git log -1??
> ??commit 6e77cfdff8a358adab4ab770a503197d95a64440 (HEAD -> master,
> origin/master, origin/HEAD)??
> ??Author: Roman Khachatryan ??
> ??Date: Fri Jan 22 14:39:48 2021 +0100??
> The test fails with the following exception:
> {code}
> Expected: a numeric value within <1.0E-6> of <40.0>
> but: <0.0> differed by <39.99>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at
> org.apache.flink.metrics.ThresholdMeterTest.testMarkMultipleEvents(ThresholdMeterTest.java:58)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:87)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreP
[jira] [Commented] (FLINK-21139) ThresholdMeterTest.testMarkMultipleEvents unstable
[
https://issues.apache.org/jira/browse/FLINK-21139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272103#comment-17272103
]
Till Rohrmann commented on FLINK-21139:
---
Looking at the code of {{ThresholdMeter}} it looks that we are using
{{System.currentTimeMillis}}. I think this is not optimal because
{{System.currentTimeMillis}} can be subject to clock jumps. I think it would be
better to use {{Clock}} here.
> ThresholdMeterTest.testMarkMultipleEvents unstable
> --
>
> Key: FLINK-21139
> URL: https://issues.apache.org/jira/browse/FLINK-21139
> Project: Flink
> Issue Type: Bug
> Components: API / Core, Benchmarks, Build System, Tests
> Environment: $ java -version && javac -version
> openjdk version "11.0.8" 2020-07-14
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10-202007292333)
> Eclipse OpenJ9 VM AdoptOpenJDK (build master-dc7cbe4bd, JRE 11 Linux
> riscv-64-Bit Compressed References 20200729_78 (JIT disabled, AOT disabled)
> OpenJ9 - dc7cbe4bd
> OMR - 1c0299f20
> JCL - 94b9d6d2c6 based on jdk-11.0.8+10)
> javac 11.0.8
> $ uname -a
> Linux test-gdams-debian10-riscv64-1.adoptopenjdk.net
> 5.0.0-rc1-56210-g0a657e0d72f0 #1 SMP Fri May 15 18:05:26 EDT 2020 riscv64
> GNU/Linux
> $ cat /proc/cpuinfo
> processor : 0
> hart : 1
> isa : rv64imafdc
> mmu : sv39
> uarch : sifive,rocket0
>Reporter: Ivan Serdyuk
>Priority: Critical
> Labels: test-stability
> Fix For: 1.13.0
>
>
> The test {{ThresholdMeterTest.testMarkMultipleEvents}} seems to be unstable.
> The version of Flink is
> ??$ git log -1??
> ??commit 6e77cfdff8a358adab4ab770a503197d95a64440 (HEAD -> master,
> origin/master, origin/HEAD)??
> ??Author: Roman Khachatryan ??
> ??Date: Fri Jan 22 14:39:48 2021 +0100??
> The test fails with the following exception:
> {code}
> Expected: a numeric value within <1.0E-6> of <40.0>
> but: <0.0> differed by <39.99>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at
> org.apache.flink.metrics.ThresholdMeterTest.testMarkMultipleEvents(ThresholdMeterTest.java:58)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:87
[jira] [Commented] (FLINK-21139) ThresholdMeterTest.testMarkMultipleEvents unstable
[
https://issues.apache.org/jira/browse/FLINK-21139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272098#comment-17272098
]
Till Rohrmann commented on FLINK-21139:
---
Thanks for reporting this issue [~oceanfish81]. The unstable test has been
introduced with FLINK-10868. [~xintongsong] and [~hpeter] could you take a look
at this problem?
> ThresholdMeterTest.testMarkMultipleEvents unstable
> --
>
> Key: FLINK-21139
> URL: https://issues.apache.org/jira/browse/FLINK-21139
> Project: Flink
> Issue Type: Bug
> Components: API / Core, Benchmarks, Build System, Tests
> Environment: $ java -version && javac -version
> openjdk version "11.0.8" 2020-07-14
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10-202007292333)
> Eclipse OpenJ9 VM AdoptOpenJDK (build master-dc7cbe4bd, JRE 11 Linux
> riscv-64-Bit Compressed References 20200729_78 (JIT disabled, AOT disabled)
> OpenJ9 - dc7cbe4bd
> OMR - 1c0299f20
> JCL - 94b9d6d2c6 based on jdk-11.0.8+10)
> javac 11.0.8
> $ uname -a
> Linux test-gdams-debian10-riscv64-1.adoptopenjdk.net
> 5.0.0-rc1-56210-g0a657e0d72f0 #1 SMP Fri May 15 18:05:26 EDT 2020 riscv64
> GNU/Linux
> $ cat /proc/cpuinfo
> processor : 0
> hart : 1
> isa : rv64imafdc
> mmu : sv39
> uarch : sifive,rocket0
>Reporter: Ivan Serdyuk
>Priority: Critical
> Labels: test-stability
> Fix For: 1.13.0, 1.12.2
>
>
> The test {{ThresholdMeterTest.testMarkMultipleEvents}} seems to be unstable.
> The version of Flink is
> ??$ git log -1??
> ??commit 6e77cfdff8a358adab4ab770a503197d95a64440 (HEAD -> master,
> origin/master, origin/HEAD)??
> ??Author: Roman Khachatryan ??
> ??Date: Fri Jan 22 14:39:48 2021 +0100??
> The test fails with the following exception:
> {code}
> Expected: a numeric value within <1.0E-6> of <40.0>
> but: <0.0> differed by <39.99>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at
> org.apache.flink.metrics.ThresholdMeterTest.testMarkMultipleEvents(ThresholdMeterTest.java:58)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:87)
> at
> org.apache.maven.surefire.junitcore.JUnitCoreWrapp
