[jira] [Commented] (FLINK-2130) RabbitMQ source does not fail when failing to retrieve elements
[ https://issues.apache.org/jira/browse/FLINK-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570522#comment-14570522 ] ASF GitHub Bot commented on FLINK-2130: --- GitHub user mbalassi opened a pull request: https://github.com/apache/flink/pull/767 [FLINK-2130] [streaming] RMQ Source properly propagates exceptions You can merge this pull request into a Git repository by running: $ git pull https://github.com/mbalassi/flink flink-2130 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/767.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #767 commit 2b784f09493767ca5b6388ac692406466dc55575 Author: mbalassi mbala...@apache.org Date: 2015-06-03T09:16:48Z [FLINK-2130] [streaming] RMQ Source properly propagates exceptions RabbitMQ source does not fail when failing to retrieve elements --- Key: FLINK-2130 URL: https://issues.apache.org/jira/browse/FLINK-2130 Project: Flink Issue Type: Bug Components: Streaming, Streaming Connectors Reporter: Stephan Ewen Assignee: Márton Balassi The RMQ source only logs when elements cannot be retrieved. Failures are not propagated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2130) RabbitMQ source does not fail when failing to retrieve elements
[ https://issues.apache.org/jira/browse/FLINK-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569132#comment-14569132 ] Robert Metzger commented on FLINK-2130: --- I would let the source fail. All the other components in Flink also always fail immediately. I guess there are ways to configure retries at the RabbitMQ connector. RabbitMQ source does not fail when failing to retrieve elements --- Key: FLINK-2130 URL: https://issues.apache.org/jira/browse/FLINK-2130 Project: Flink Issue Type: Bug Components: Streaming, Streaming Connectors Reporter: Stephan Ewen The RMQ source only logs when elements cannot be retrieved. Failures are not propagated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2130) RabbitMQ source does not fail when failing to retrieve elements
[ https://issues.apache.org/jira/browse/FLINK-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569096#comment-14569096 ] Márton Balassi commented on FLINK-2130: --- This was a conscious design choice, so we do not fail a whole source task just because one single element was not read properly. Open and close failures are propagated. Would you suggest to do this on every failed message? RabbitMQ source does not fail when failing to retrieve elements --- Key: FLINK-2130 URL: https://issues.apache.org/jira/browse/FLINK-2130 Project: Flink Issue Type: Bug Reporter: Stephan Ewen The RMQ source only logs when elements cannot be retrieved. Failures are not propagated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
