[jira] [Commented] (FLINK-21858) TaskMetricGroup taskName is too long, especially in sql tasks.
[ https://issues.apache.org/jira/browse/FLINK-21858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17453818#comment-17453818 ] Martijn Visser commented on FLINK-21858: I expect that this ticket will be resolved via https://issues.apache.org/jira/browse/FLINK-25070 > TaskMetricGroup taskName is too long, especially in sql tasks. > -- > > Key: FLINK-21858 > URL: https://issues.apache.org/jira/browse/FLINK-21858 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.12.0, 1.12.1, 1.12.2 >Reporter: Andrew.D.lin >Priority: Minor > Labels: auto-deprioritized-major, auto-unassigned, stale-minor > > Now operatorName is limited to 80 by > org.apache.flink.runtime.metrics.groups.TaskMetricGroup#METRICS_OPERATOR_NAME_MAX_LENGTH. > So propose to limit the maximum length of metric name by configuration. > > Here is an example: > > "taskName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], select=[dt, src, src1, src2, src3, ct1, ct2, SUM_RETRACT((sum$0, > count$1)) AS sx_pv, SUM_RETRACT((sum$2, count$3)) AS sx_uv, > MAX_RETRACT(max$4) AS updt_time, MAX_RETRACT(max$5) AS time_id]) -> > Calc(select=[((MD5((dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' > CONCAT src1 CONCAT _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 > CONCAT _UTF-16LE'|' CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT > _UTF-16LE'|' CONCAT time_id)) SUBSTR 1 SUBSTR 2) CONCAT _UTF-16LE'_' CONCAT > (dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' CONCAT src1 CONCAT > _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 CONCAT _UTF-16LE'|' > CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT _UTF-16LE'|' CONCAT > time_id)) AS rowkey, sx_pv, sx_uv, updt_time]) -> > LocalGroupAggregate(groupBy=[rowkey], select=[rowkey, MAX_RETRACT(sx_pv) AS > max$0, MAX_RETRACT(sx_uv) AS max$1, MAX_RETRACT(updt_time) AS max$2, > COUNT_RETRACT(*) AS count1$3])" > "operatorName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], selec=[dt, s" > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-21858) TaskMetricGroup taskName is too long, especially in sql tasks.
[ https://issues.apache.org/jira/browse/FLINK-21858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17333569#comment-17333569 ] Flink Jira Bot commented on FLINK-21858: This issue was marked "stale-assigned" and has not received an update in 7 days. It is now automatically unassigned. If you are still working on it, you can assign it to yourself again. Please also give an update about the status of the work. > TaskMetricGroup taskName is too long, especially in sql tasks. > -- > > Key: FLINK-21858 > URL: https://issues.apache.org/jira/browse/FLINK-21858 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.12.0, 1.12.1, 1.12.2 >Reporter: Andrew.D.lin >Assignee: Andrew.D.lin >Priority: Major > Labels: stale-assigned > > Now operatorName is limited to 80 by > org.apache.flink.runtime.metrics.groups.TaskMetricGroup#METRICS_OPERATOR_NAME_MAX_LENGTH. > So propose to limit the maximum length of metric name by configuration. > > Here is an example: > > "taskName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], select=[dt, src, src1, src2, src3, ct1, ct2, SUM_RETRACT((sum$0, > count$1)) AS sx_pv, SUM_RETRACT((sum$2, count$3)) AS sx_uv, > MAX_RETRACT(max$4) AS updt_time, MAX_RETRACT(max$5) AS time_id]) -> > Calc(select=[((MD5((dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' > CONCAT src1 CONCAT _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 > CONCAT _UTF-16LE'|' CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT > _UTF-16LE'|' CONCAT time_id)) SUBSTR 1 SUBSTR 2) CONCAT _UTF-16LE'_' CONCAT > (dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' CONCAT src1 CONCAT > _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 CONCAT _UTF-16LE'|' > CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT _UTF-16LE'|' CONCAT > time_id)) AS rowkey, sx_pv, sx_uv, updt_time]) -> > LocalGroupAggregate(groupBy=[rowkey], select=[rowkey, MAX_RETRACT(sx_pv) AS > max$0, MAX_RETRACT(sx_uv) AS max$1, MAX_RETRACT(updt_time) AS max$2, > COUNT_RETRACT(*) AS count1$3])" > "operatorName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], selec=[dt, s" > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21858) TaskMetricGroup taskName is too long, especially in sql tasks.
[ https://issues.apache.org/jira/browse/FLINK-21858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322794#comment-17322794 ] Flink Jira Bot commented on FLINK-21858: This issue is assigned but has not received an update in 7 days so it has been labeled "stale-assigned". If you are still working on the issue, please give an update and remove the label. If you are no longer working on the issue, please unassign so someone else may work on it. In 7 days the issue will be automatically unassigned. > TaskMetricGroup taskName is too long, especially in sql tasks. > -- > > Key: FLINK-21858 > URL: https://issues.apache.org/jira/browse/FLINK-21858 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.12.0, 1.12.1, 1.12.2 >Reporter: Andrew.D.lin >Assignee: Andrew.D.lin >Priority: Major > Labels: stale-assigned > > Now operatorName is limited to 80 by > org.apache.flink.runtime.metrics.groups.TaskMetricGroup#METRICS_OPERATOR_NAME_MAX_LENGTH. > So propose to limit the maximum length of metric name by configuration. > > Here is an example: > > "taskName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], select=[dt, src, src1, src2, src3, ct1, ct2, SUM_RETRACT((sum$0, > count$1)) AS sx_pv, SUM_RETRACT((sum$2, count$3)) AS sx_uv, > MAX_RETRACT(max$4) AS updt_time, MAX_RETRACT(max$5) AS time_id]) -> > Calc(select=[((MD5((dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' > CONCAT src1 CONCAT _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 > CONCAT _UTF-16LE'|' CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT > _UTF-16LE'|' CONCAT time_id)) SUBSTR 1 SUBSTR 2) CONCAT _UTF-16LE'_' CONCAT > (dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' CONCAT src1 CONCAT > _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 CONCAT _UTF-16LE'|' > CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT _UTF-16LE'|' CONCAT > time_id)) AS rowkey, sx_pv, sx_uv, updt_time]) -> > LocalGroupAggregate(groupBy=[rowkey], select=[rowkey, MAX_RETRACT(sx_pv) AS > max$0, MAX_RETRACT(sx_uv) AS max$1, MAX_RETRACT(updt_time) AS max$2, > COUNT_RETRACT(*) AS count1$3])" > "operatorName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], selec=[dt, s" > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21858) TaskMetricGroup taskName is too long, especially in sql tasks.
[ https://issues.apache.org/jira/browse/FLINK-21858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304192#comment-17304192 ] Andrew.D.lin commented on FLINK-21858: -- Thanks for your reply. (y) [~chesnay] Ok, let me pay attention to [FLINK-20388|https://issues.apache.org/jira/browse/FLINK-20388] > TaskMetricGroup taskName is too long, especially in sql tasks. > -- > > Key: FLINK-21858 > URL: https://issues.apache.org/jira/browse/FLINK-21858 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.12.0, 1.12.1, 1.12.2 >Reporter: Andrew.D.lin >Assignee: Andrew.D.lin >Priority: Major > > Now operatorName is limited to 80 by > org.apache.flink.runtime.metrics.groups.TaskMetricGroup#METRICS_OPERATOR_NAME_MAX_LENGTH. > So propose to limit the maximum length of metric name by configuration. > > Here is an example: > > "taskName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], select=[dt, src, src1, src2, src3, ct1, ct2, SUM_RETRACT((sum$0, > count$1)) AS sx_pv, SUM_RETRACT((sum$2, count$3)) AS sx_uv, > MAX_RETRACT(max$4) AS updt_time, MAX_RETRACT(max$5) AS time_id]) -> > Calc(select=[((MD5((dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' > CONCAT src1 CONCAT _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 > CONCAT _UTF-16LE'|' CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT > _UTF-16LE'|' CONCAT time_id)) SUBSTR 1 SUBSTR 2) CONCAT _UTF-16LE'_' CONCAT > (dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' CONCAT src1 CONCAT > _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 CONCAT _UTF-16LE'|' > CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT _UTF-16LE'|' CONCAT > time_id)) AS rowkey, sx_pv, sx_uv, updt_time]) -> > LocalGroupAggregate(groupBy=[rowkey], select=[rowkey, MAX_RETRACT(sx_pv) AS > max$0, MAX_RETRACT(sx_uv) AS max$1, MAX_RETRACT(updt_time) AS max$2, > COUNT_RETRACT(*) AS count1$3])" > "operatorName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], selec=[dt, s" > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21858) TaskMetricGroup taskName is too long, especially in sql tasks.
[ https://issues.apache.org/jira/browse/FLINK-21858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304048#comment-17304048 ] Chesnay Schepler commented on FLINK-21858: -- I don't think we should make it configurable. This is closely related to FLINK-20388, where we are discussing the introduction of a dedicated operator description, and relegating the operator name to short and, honestly, useful identifier. > TaskMetricGroup taskName is too long, especially in sql tasks. > -- > > Key: FLINK-21858 > URL: https://issues.apache.org/jira/browse/FLINK-21858 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.12.0, 1.12.1, 1.12.2 >Reporter: Andrew.D.lin >Assignee: Andrew.D.lin >Priority: Major > > Now operatorName is limited to 80 by > org.apache.flink.runtime.metrics.groups.TaskMetricGroup#METRICS_OPERATOR_NAME_MAX_LENGTH. > So propose to limit the maximum length of metric name by configuration. > > Here is an example: > > "taskName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], select=[dt, src, src1, src2, src3, ct1, ct2, SUM_RETRACT((sum$0, > count$1)) AS sx_pv, SUM_RETRACT((sum$2, count$3)) AS sx_uv, > MAX_RETRACT(max$4) AS updt_time, MAX_RETRACT(max$5) AS time_id]) -> > Calc(select=[((MD5((dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' > CONCAT src1 CONCAT _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 > CONCAT _UTF-16LE'|' CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT > _UTF-16LE'|' CONCAT time_id)) SUBSTR 1 SUBSTR 2) CONCAT _UTF-16LE'_' CONCAT > (dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' CONCAT src1 CONCAT > _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 CONCAT _UTF-16LE'|' > CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT _UTF-16LE'|' CONCAT > time_id)) AS rowkey, sx_pv, sx_uv, updt_time]) -> > LocalGroupAggregate(groupBy=[rowkey], select=[rowkey, MAX_RETRACT(sx_pv) AS > max$0, MAX_RETRACT(sx_uv) AS max$1, MAX_RETRACT(updt_time) AS max$2, > COUNT_RETRACT(*) AS count1$3])" > "operatorName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], selec=[dt, s" > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21858) TaskMetricGroup taskName is too long, especially in sql tasks.
[ https://issues.apache.org/jira/browse/FLINK-21858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304037#comment-17304037 ] Andrew.D.lin commented on FLINK-21858: -- Hi [~chesnay] Is it reasonable to restrict the metric name by adding configuration? there is a better suggestion？:) > TaskMetricGroup taskName is too long, especially in sql tasks. > -- > > Key: FLINK-21858 > URL: https://issues.apache.org/jira/browse/FLINK-21858 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.12.0, 1.12.1, 1.12.2 >Reporter: Andrew.D.lin >Assignee: Andrew.D.lin >Priority: Major > > Now operatorName is limited to 80 by > org.apache.flink.runtime.metrics.groups.TaskMetricGroup#METRICS_OPERATOR_NAME_MAX_LENGTH. > So propose to limit the maximum length of metric name by configuration. > > Here is an example: > > "taskName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], select=[dt, src, src1, src2, src3, ct1, ct2, SUM_RETRACT((sum$0, > count$1)) AS sx_pv, SUM_RETRACT((sum$2, count$3)) AS sx_uv, > MAX_RETRACT(max$4) AS updt_time, MAX_RETRACT(max$5) AS time_id]) -> > Calc(select=[((MD5((dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' > CONCAT src1 CONCAT _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 > CONCAT _UTF-16LE'|' CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT > _UTF-16LE'|' CONCAT time_id)) SUBSTR 1 SUBSTR 2) CONCAT _UTF-16LE'_' CONCAT > (dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' CONCAT src1 CONCAT > _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 CONCAT _UTF-16LE'|' > CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT _UTF-16LE'|' CONCAT > time_id)) AS rowkey, sx_pv, sx_uv, updt_time]) -> > LocalGroupAggregate(groupBy=[rowkey], select=[rowkey, MAX_RETRACT(sx_pv) AS > max$0, MAX_RETRACT(sx_uv) AS max$1, MAX_RETRACT(updt_time) AS max$2, > COUNT_RETRACT(*) AS count1$3])" > "operatorName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], selec=[dt, s" > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21858) TaskMetricGroup taskName is too long, especially in sql tasks.
[ https://issues.apache.org/jira/browse/FLINK-21858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304033#comment-17304033 ] Andrew.D.lin commented on FLINK-21858: -- OK .thanks for your reply. [~zjwang] > TaskMetricGroup taskName is too long, especially in sql tasks. > -- > > Key: FLINK-21858 > URL: https://issues.apache.org/jira/browse/FLINK-21858 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.12.0, 1.12.1, 1.12.2 >Reporter: Andrew.D.lin >Assignee: Andrew.D.lin >Priority: Major > > Now operatorName is limited to 80 by > org.apache.flink.runtime.metrics.groups.TaskMetricGroup#METRICS_OPERATOR_NAME_MAX_LENGTH. > So propose to limit the maximum length of metric name by configuration. > > Here is an example: > > "taskName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], select=[dt, src, src1, src2, src3, ct1, ct2, SUM_RETRACT((sum$0, > count$1)) AS sx_pv, SUM_RETRACT((sum$2, count$3)) AS sx_uv, > MAX_RETRACT(max$4) AS updt_time, MAX_RETRACT(max$5) AS time_id]) -> > Calc(select=[((MD5((dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' > CONCAT src1 CONCAT _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 > CONCAT _UTF-16LE'|' CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT > _UTF-16LE'|' CONCAT time_id)) SUBSTR 1 SUBSTR 2) CONCAT _UTF-16LE'_' CONCAT > (dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' CONCAT src1 CONCAT > _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 CONCAT _UTF-16LE'|' > CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT _UTF-16LE'|' CONCAT > time_id)) AS rowkey, sx_pv, sx_uv, updt_time]) -> > LocalGroupAggregate(groupBy=[rowkey], select=[rowkey, MAX_RETRACT(sx_pv) AS > max$0, MAX_RETRACT(sx_uv) AS max$1, MAX_RETRACT(updt_time) AS max$2, > COUNT_RETRACT(*) AS count1$3])" > "operatorName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], selec=[dt, s" > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21858) TaskMetricGroup taskName is too long, especially in sql tasks.
[ https://issues.apache.org/jira/browse/FLINK-21858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304031#comment-17304031 ] Zhijiang commented on FLINK-21858: -- I have assigned it to you, but it is better to confirm the solution with [~chesnay] before submitting the PR. :) > TaskMetricGroup taskName is too long, especially in sql tasks. > -- > > Key: FLINK-21858 > URL: https://issues.apache.org/jira/browse/FLINK-21858 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.12.0, 1.12.1, 1.12.2 >Reporter: Andrew.D.lin >Assignee: Andrew.D.lin >Priority: Major > > Now operatorName is limited to 80 by > org.apache.flink.runtime.metrics.groups.TaskMetricGroup#METRICS_OPERATOR_NAME_MAX_LENGTH. > So propose to limit the maximum length of metric name by configuration. > > Here is an example: > > "taskName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], select=[dt, src, src1, src2, src3, ct1, ct2, SUM_RETRACT((sum$0, > count$1)) AS sx_pv, SUM_RETRACT((sum$2, count$3)) AS sx_uv, > MAX_RETRACT(max$4) AS updt_time, MAX_RETRACT(max$5) AS time_id]) -> > Calc(select=[((MD5((dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' > CONCAT src1 CONCAT _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 > CONCAT _UTF-16LE'|' CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT > _UTF-16LE'|' CONCAT time_id)) SUBSTR 1 SUBSTR 2) CONCAT _UTF-16LE'_' CONCAT > (dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' CONCAT src1 CONCAT > _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 CONCAT _UTF-16LE'|' > CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT _UTF-16LE'|' CONCAT > time_id)) AS rowkey, sx_pv, sx_uv, updt_time]) -> > LocalGroupAggregate(groupBy=[rowkey], select=[rowkey, MAX_RETRACT(sx_pv) AS > max$0, MAX_RETRACT(sx_uv) AS max$1, MAX_RETRACT(updt_time) AS max$2, > COUNT_RETRACT(*) AS count1$3])" > "operatorName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], selec=[dt, s" > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21858) TaskMetricGroup taskName is too long, especially in sql tasks.
[ https://issues.apache.org/jira/browse/FLINK-21858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304000#comment-17304000 ] Andrew.D.lin commented on FLINK-21858: -- I am willing to do it! > TaskMetricGroup taskName is too long, especially in sql tasks. > -- > > Key: FLINK-21858 > URL: https://issues.apache.org/jira/browse/FLINK-21858 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.12.0, 1.12.1, 1.12.2 >Reporter: Andrew.D.lin >Priority: Major > > Now operatorName is limited to 80 by > org.apache.flink.runtime.metrics.groups.TaskMetricGroup#METRICS_OPERATOR_NAME_MAX_LENGTH. > So propose to limit the maximum length of metric name by configuration. > > Here is an example: > > "taskName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], select=[dt, src, src1, src2, src3, ct1, ct2, SUM_RETRACT((sum$0, > count$1)) AS sx_pv, SUM_RETRACT((sum$2, count$3)) AS sx_uv, > MAX_RETRACT(max$4) AS updt_time, MAX_RETRACT(max$5) AS time_id]) -> > Calc(select=[((MD5((dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' > CONCAT src1 CONCAT _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 > CONCAT _UTF-16LE'|' CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT > _UTF-16LE'|' CONCAT time_id)) SUBSTR 1 SUBSTR 2) CONCAT _UTF-16LE'_' CONCAT > (dt CONCAT _UTF-16LE'|' CONCAT src CONCAT _UTF-16LE'|' CONCAT src1 CONCAT > _UTF-16LE'|' CONCAT src2 CONCAT _UTF-16LE'|' CONCAT src3 CONCAT _UTF-16LE'|' > CONCAT ct1 CONCAT _UTF-16LE'|' CONCAT ct2 CONCAT _UTF-16LE'|' CONCAT > time_id)) AS rowkey, sx_pv, sx_uv, updt_time]) -> > LocalGroupAggregate(groupBy=[rowkey], select=[rowkey, MAX_RETRACT(sx_pv) AS > max$0, MAX_RETRACT(sx_uv) AS max$1, MAX_RETRACT(updt_time) AS max$2, > COUNT_RETRACT(*) AS count1$3])" > "operatorName":"GlobalGroupAggregate(groupBy=[dt, src, src1, src2, src3, ct1, > ct2], selec=[dt, s" > -- This message was sent by Atlassian Jira (v8.3.4#803005)
