[jira] [Commented] (FLINK-23861) flink sql client support dynamic params
[ https://issues.apache.org/jira/browse/FLINK-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401651#comment-17401651 ] zhangbinzaifendou commented on FLINK-23861: --- 1 Fllink SET command is like a muddy road, -c or --conf is like a wide asphalt road, users can choose freely. 2 Spark,Hive has dominated batch Compute for so long that it has formed a complete habit in the minds of many fans.I don't think some of Flink's command are exactly what users are used to. For example, hive -e "XXX "/ spark-sql -e" XXX "cannot be used in the Flink SQL Client.In order for Flink to fight for the cake in the batch compute field, Flink not only has to surpass other systems in terms of function and performance, but the user's habits are also extremely important, so we can satisfy them as much as possible. After all, Flink will "dominate the world" in the future. > flink sql client support dynamic params > --- > > Key: FLINK-23861 > URL: https://issues.apache.org/jira/browse/FLINK-23861 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Client >Affects Versions: 1.13.2 >Reporter: zhangbinzaifendou >Priority: Minor > Labels: pull-request-available > Attachments: image-2021-08-18-23-41-13-629.png, > image-2021-08-18-23-42-04-257.png, image-2021-08-18-23-43-04-323.png > > > 1 Every time the set command is executed, the method call process is very > long and a new createTableEnvironment object is created > 2 As a result of the previous discussion in FLINK-22770, I don't think it's a > good habit for users to put quotes around keys and values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23861) flink sql client support dynamic params
[
https://issues.apache.org/jira/browse/FLINK-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401496#comment-17401496
]
Jark Wu commented on FLINK-23861:
-
Thanks [~zhangbinzaifendou], I just think performance shouldn't be the reason
to introduce a new API, if the performance is a problem, then we should fix the
performance problem. Otherwise, users still can't happily to use SET command.
Personally, I'm not againt with {{-c k=v}} options. If it provides some kind of
convenience, it's fine to introduce it, but I only have a minor suggestion that
would be better to use {{-D}} instead of {{-c}} or {{--conf}} as the argument
prefix, because this keeps align with Flink CLI behavior:
https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/cli/
> flink sql client support dynamic params
> ---
>
> Key: FLINK-23861
> URL: https://issues.apache.org/jira/browse/FLINK-23861
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.13.2
>Reporter: zhangbinzaifendou
>Priority: Minor
> Labels: pull-request-available
> Attachments: image-2021-08-18-23-41-13-629.png,
> image-2021-08-18-23-42-04-257.png, image-2021-08-18-23-43-04-323.png
>
>
> 1 Every time the set command is executed, the method call process is very
> long and a new createTableEnvironment object is created
> 2 As a result of the previous discussion in FLINK-22770, I don't think it's a
> good habit for users to put quotes around keys and values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-23861) flink sql client support dynamic params
[ https://issues.apache.org/jira/browse/FLINK-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401465#comment-17401465 ] zhangbinzaifendou commented on FLINK-23861: --- [~jark] Thank you for your reply！ 1 There is no detailed test for the specific execution time, but from the perspective of the method execution process, the process is very lengthy and not elegant enough. The -c/--conf k=v is simple and convenient. 2 Spark, Hive and other systems have related parameter configurations, such as --conf --hiveconf. 3 Avoid using single quotation marks and maintain good usage habits. > flink sql client support dynamic params > --- > > Key: FLINK-23861 > URL: https://issues.apache.org/jira/browse/FLINK-23861 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Client >Affects Versions: 1.13.2 >Reporter: zhangbinzaifendou >Priority: Minor > Labels: pull-request-available > Attachments: image-2021-08-18-23-41-13-629.png, > image-2021-08-18-23-42-04-257.png, image-2021-08-18-23-43-04-323.png > > > 1 Every time the set command is executed, the method call process is very > long and a new createTableEnvironment object is created > 2 As a result of the previous discussion in FLINK-22770, I don't think it's a > good habit for users to put quotes around keys and values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23861) flink sql client support dynamic params
[
https://issues.apache.org/jira/browse/FLINK-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401443#comment-17401443
]
Jark Wu commented on FLINK-23861:
-
IIUC, your main concern is the performance of SET command because it
{{createTableEnvironment}} ?
How long will it take?
> flink sql client support dynamic params
> ---
>
> Key: FLINK-23861
> URL: https://issues.apache.org/jira/browse/FLINK-23861
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.13.2
>Reporter: zhangbinzaifendou
>Priority: Minor
> Labels: pull-request-available
> Attachments: image-2021-08-18-23-41-13-629.png,
> image-2021-08-18-23-42-04-257.png, image-2021-08-18-23-43-04-323.png
>
>
> 1 Every time the set command is executed, the method call process is very
> long and a new createTableEnvironment object is created
> 2 As a result of the previous discussion in FLINK-22770, I don't think it's a
> good habit for users to put quotes around keys and values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-23861) flink sql client support dynamic params
[ https://issues.apache.org/jira/browse/FLINK-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401160#comment-17401160 ] zhangbinzaifendou commented on FLINK-23861: --- h2. The same goes for init.sql. h2. The createTableEnvironment method is executed when the set method is executed. h2. init.sql h5. !image-2021-08-18-23-43-04-323.png|width=716,height=253! h5. !image-2021-08-18-23-41-13-629.png|width=813,height=251! !image-2021-08-18-23-42-04-257.png|width=790,height=300! > flink sql client support dynamic params > --- > > Key: FLINK-23861 > URL: https://issues.apache.org/jira/browse/FLINK-23861 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Client >Affects Versions: 1.13.2 >Reporter: zhangbinzaifendou >Priority: Minor > Labels: pull-request-available > Attachments: image-2021-08-18-23-41-13-629.png, > image-2021-08-18-23-42-04-257.png, image-2021-08-18-23-43-04-323.png > > > 1 Every time the set command is executed, the method call process is very > long and a new createTableEnvironment object is created > 2 As a result of the previous discussion in > [FLINK-22770|https://issues.apache.org/jira/browse/FLINK-22770], I don’t > think that adding quotation marks to key and value is not a good habit for > users. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23861) flink sql client support dynamic params
[
https://issues.apache.org/jira/browse/FLINK-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401119#comment-17401119
]
Jark Wu commented on FLINK-23861:
-
Why not put the SET configuration in {{-i init.sql}} ?
> flink sql client support dynamic params
> ---
>
> Key: FLINK-23861
> URL: https://issues.apache.org/jira/browse/FLINK-23861
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.13.2
>Reporter: zhangbinzaifendou
>Priority: Minor
> Labels: pull-request-available
>
> 1 Every time the set command is executed, the method call process is very
> long and a new createTableEnvironment object is created
> 2 As a result of the previous discussion in
> [FLINK-22770|https://issues.apache.org/jira/browse/FLINK-22770], I don’t
> think that adding quotation marks to key and value is not a good habit for
> users.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
