[jira] [Commented] (FLINK-24857) Upgrade SourceReaderTestBase to Use Junit 5

2022-01-03 Thread Fabian Paul (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467950#comment-17467950
 ] 

Fabian Paul commented on FLINK-24857:
-

Merged in master: 1b02f022cdcb4af449ed5dfe88acd3f9e4926dbe

> Upgrade SourceReaderTestBase to Use Junit 5
> ---
>
> Key: FLINK-24857
> URL: https://issues.apache.org/jira/browse/FLINK-24857
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Test Infrastructure
>Reporter: Yufei Zhang
>Assignee: Yufei Zhang
>Priority: Minor
>  Labels: pull-request-available, test
>
> Currently SourceReaderTestBase uses Junit 4, it needs to be upgraded to Junit 
> 5 for new tests to use.
> It affects two subclasses.
>  
>  * org/apache/flink/connector/kafka/source/reader/KafkaSourceReaderTest.java
>  * org/apache/flink/connector/base/source/reader/SourceReaderBaseTest.java
>  
> These two classes needs to be fixed as well



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (FLINK-24857) Upgrade SourceReaderTestBase to Use Junit 5

2021-11-10 Thread Martijn Visser (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17441687#comment-17441687
 ] 

Martijn Visser commented on FLINK-24857:


[~affe] I've assigned it to you

> Upgrade SourceReaderTestBase to Use Junit 5
> ---
>
> Key: FLINK-24857
> URL: https://issues.apache.org/jira/browse/FLINK-24857
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Test Infrastructure
>Reporter: Yufei Zhang
>Assignee: Yufei Zhang
>Priority: Minor
>  Labels: test
>
> Currently SourceReaderTestBase uses Junit 4, it needs to be upgraded to Junit 
> 5 for new tests to use.
> It affects two subclasses.
>  
>  * org/apache/flink/connector/kafka/source/reader/KafkaSourceReaderTest.java
>  * org/apache/flink/connector/base/source/reader/SourceReaderBaseTest.java
>  
> These two classes needs to be fixed as well



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (FLINK-24857) Upgrade SourceReaderTestBase to Use Junit 5

2021-11-10 Thread Yufei Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17441611#comment-17441611
 ] 

Yufei Zhang commented on FLINK-24857:
-

Would be happy to help with this ticket~

> Upgrade SourceReaderTestBase to Use Junit 5
> ---
>
> Key: FLINK-24857
> URL: https://issues.apache.org/jira/browse/FLINK-24857
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Test Infrastructure
>Reporter: Yufei Zhang
>Priority: Minor
>  Labels: test
>
> Currently SourceReaderTestBase uses Junit 4, it needs to be upgraded to Junit 
> 5 for new tests to use.
> It affects two subclasses.
>  
>  * org/apache/flink/connector/kafka/source/reader/KafkaSourceReaderTest.java
>  * org/apache/flink/connector/base/source/reader/SourceReaderBaseTest.java
>  
> These two classes needs to be fixed as well



--
This message was sent by Atlassian Jira
(v8.20.1#820001)