[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503673#comment-17503673
]
Yang Wang commented on FLINK-26528:
---
Thanks for your explanation. I get your point. This ticket is to reduce the K8s
APIServer load.
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503631#comment-17503631
]
Aitozi commented on FLINK-26528:
Yes, my meaning is to eliminate the unchanged update to toward kubernetes. IMO,
The {{UpdateControl}} have four abilities
* update status
* update resource
* not update not reschedule
* not update but reschedule
So if we have change the status or resource (not recommended and not used now),
we should apply the update. If the status have not achieved the desired state,
and is not changed since last reconcile loop, we should just reschedule and
wait the next turn.
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503593#comment-17503593
]
Gyula Fora commented on FLINK-26528:
I think we are not trying to change the reschedule behaviour here, only whether
we signal status change or not toward kubernetes
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503549#comment-17503549
]
Yang Wang commented on FLINK-26528:
---
Even though the CR does not change since last reconciliation, we might still
need the periodical update events so that we have a chance to get the Flink job
status and find some other issues(e.g. deployment crashed, deleted).
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503534#comment-17503534
]
Aitozi commented on FLINK-26528:
Yes, I can take this work, I have done some poc code locally, I will continue
on your current code
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503525#comment-17503525
]
Gyula Fora commented on FLINK-26528:
[~aitozi] would you like me to assign this ticket to you?
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503523#comment-17503523
]
Gyula Fora commented on FLINK-26528:
I think after [https://github.com/apache/flink-kubernetes-operator/pull/48] we
can do this quite nicely. I have made some improvements in this PR and now tha
update control handling is centralized into one place.
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503409#comment-17503409
]
Aitozi commented on FLINK-26528:
It's not the same question, this ticket is want to solve that we should avoid
to trigger the update for the object when it has not changed.
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503364#comment-17503364
]
Yang Wang commented on FLINK-26528:
---
Why this ticket could not be covered by {{{}generationAwareEventProcessing =
true{}}}, which means the events will be triggered only when spec changed?
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26528) Trigger the updateControl when the FlinkDeployment have changed
[
https://issues.apache.org/jira/browse/FLINK-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503027#comment-17503027
]
Aitozi commented on FLINK-26528:
I proposal to provide a {{ReconcileResult}} which will generate the
{{UpdateControl}} by comparing the FlinkDeployment before and after the
reconcile handle. This requires to clone and keep the original resource object
at the reconcile entrypoint. By this, we can only update the resource when it
has changed, reducing the unnecessary update, e.g. when doing the state sync.
cc [~gyfora] [~wangyang0918]
> Trigger the updateControl when the FlinkDeployment have changed
> ---
>
> Key: FLINK-26528
> URL: https://issues.apache.org/jira/browse/FLINK-26528
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> If the CR has not changed since last reconcile, we could create a
> UpdateControl with {{UpdateControl#noUpdate}} , this is meant to reduce the
> unnecessary update for resource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
