[jira] [Commented] (FLINK-2684) Make TypeInformation non-serializable again by removing Table API's need for it
[
https://issues.apache.org/jira/browse/FLINK-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14802692#comment-14802692
]
Till Rohrmann commented on FLINK-2684:
--
Yes, I think this is the better solution here. In fact, I already implemented
this solution and it seems to work.
> Make TypeInformation non-serializable again by removing Table API's need for
> it
> ---
>
> Key: FLINK-2684
> URL: https://issues.apache.org/jira/browse/FLINK-2684
> Project: Flink
> Issue Type: Improvement
> Components: Table API
>Reporter: Till Rohrmann
>Priority: Minor
>
> Currently, the {{TypeInformations}} must be serializable because they are
> shipped with UDFs of the Table API to the TMs. There the Table API code is
> generated and compiled. By generating the code on the client and shipping the
> code as strings, we could get rid of this dependency. As a consequence, the
> {{TypeInformations}} can be non-serializable again, as they were intended to
> be.
> Maybe [~aljoscha] can provide some more implementation details here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2684) Make TypeInformation non-serializable again by removing Table API's need for it
[
https://issues.apache.org/jira/browse/FLINK-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791818#comment-14791818
]
Chiwan Park commented on FLINK-2684:
Although {{TypeInformation}} is not serializable, we can fix FLINK-2690 with
another solution using {{getAllDeclaredFields}} in {{TypeExtractor}}. So If
there are some problems with serializable {{TypeInformation}}, let's make it
non-serializable.
> Make TypeInformation non-serializable again by removing Table API's need for
> it
> ---
>
> Key: FLINK-2684
> URL: https://issues.apache.org/jira/browse/FLINK-2684
> Project: Flink
> Issue Type: Improvement
> Components: Table API
>Reporter: Till Rohrmann
>Priority: Minor
>
> Currently, the {{TypeInformations}} must be serializable because they are
> shipped with UDFs of the Table API to the TMs. There the Table API code is
> generated and compiled. By generating the code on the client and shipping the
> code as strings, we could get rid of this dependency. As a consequence, the
> {{TypeInformations}} can be non-serializable again, as they were intended to
> be.
> Maybe [~aljoscha] can provide some more implementation details here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2684) Make TypeInformation non-serializable again by removing Table API's need for it
[
https://issues.apache.org/jira/browse/FLINK-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14747171#comment-14747171
]
Till Rohrmann commented on FLINK-2684:
--
The benefits would be to re-establish the old contract that
{{TypeInformations}} shouldn't be passed along other job information. Marking
it {{Serializable}} has led in the past to problems where {{TypeInformations}},
which weren't serializable, were sent over the wire and, thus, made the program
fail. As far as I know, there is no real need to make the {{TypeInformation}}
serializable and, thus, re-establishing a harder contract will prevent possible
errors in the future.
> Make TypeInformation non-serializable again by removing Table API's need for
> it
> ---
>
> Key: FLINK-2684
> URL: https://issues.apache.org/jira/browse/FLINK-2684
> Project: Flink
> Issue Type: Improvement
> Components: Table API
>Reporter: Till Rohrmann
>Priority: Minor
>
> Currently, the {{TypeInformations}} must be serializable because they are
> shipped with UDFs of the Table API to the TMs. There the Table API code is
> generated and compiled. By generating the code on the client and shipping the
> code as strings, we could get rid of this dependency. As a consequence, the
> {{TypeInformations}} can be non-serializable again, as they were intended to
> be.
> Maybe [~aljoscha] can provide some more implementation details here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2684) Make TypeInformation non-serializable again by removing Table API's need for it
[
https://issues.apache.org/jira/browse/FLINK-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14747205#comment-14747205
]
Aljoscha Krettek commented on FLINK-2684:
-
For the Table API to work we would only need to move the code generation to the
pre-flight phase, ship the code as a string, and then compile it at runtime
using Janino.
Right now, both the code generation and compilation happen at runtime.
> Make TypeInformation non-serializable again by removing Table API's need for
> it
> ---
>
> Key: FLINK-2684
> URL: https://issues.apache.org/jira/browse/FLINK-2684
> Project: Flink
> Issue Type: Improvement
> Components: Table API
>Reporter: Till Rohrmann
>Priority: Minor
>
> Currently, the {{TypeInformations}} must be serializable because they are
> shipped with UDFs of the Table API to the TMs. There the Table API code is
> generated and compiled. By generating the code on the client and shipping the
> code as strings, we could get rid of this dependency. As a consequence, the
> {{TypeInformations}} can be non-serializable again, as they were intended to
> be.
> Maybe [~aljoscha] can provide some more implementation details here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2684) Make TypeInformation non-serializable again by removing Table API's need for it
[
https://issues.apache.org/jira/browse/FLINK-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790874#comment-14790874
]
Chesnay Schepler commented on FLINK-2684:
-
FLINK-2690 presents a possible use-case for serializable TypeInformation.
> Make TypeInformation non-serializable again by removing Table API's need for
> it
> ---
>
> Key: FLINK-2684
> URL: https://issues.apache.org/jira/browse/FLINK-2684
> Project: Flink
> Issue Type: Improvement
> Components: Table API
>Reporter: Till Rohrmann
>Priority: Minor
>
> Currently, the {{TypeInformations}} must be serializable because they are
> shipped with UDFs of the Table API to the TMs. There the Table API code is
> generated and compiled. By generating the code on the client and shipping the
> code as strings, we could get rid of this dependency. As a consequence, the
> {{TypeInformations}} can be non-serializable again, as they were intended to
> be.
> Maybe [~aljoscha] can provide some more implementation details here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2684) Make TypeInformation non-serializable again by removing Table API's need for it
[
https://issues.apache.org/jira/browse/FLINK-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745831#comment-14745831
]
Chesnay Schepler commented on FLINK-2684:
-
What are the benefits of making them non-serializable?
> Make TypeInformation non-serializable again by removing Table API's need for
> it
> ---
>
> Key: FLINK-2684
> URL: https://issues.apache.org/jira/browse/FLINK-2684
> Project: Flink
> Issue Type: Improvement
> Components: Table API
>Reporter: Till Rohrmann
>Priority: Minor
>
> Currently, the {{TypeInformations}} must be serializable because they are
> shipped with UDFs of the Table API to the TMs. There the Table API code is
> generated and compiled. By generating the code on the client and shipping the
> code as strings, we could get rid of this dependency. As a consequence, the
> {{TypeInformations}} can be non-serializable again, as they were intended to
> be.
> Maybe [~aljoscha] can provide some more implementation details here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
