[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink
[
https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541431#comment-17541431
]
Fabian Paul commented on FLINK-27174:
-
Merged in release-1.15: c028c00b5ddfdf2903de07e1415c7c855007c663
> Non-null check for bootstrapServers field is incorrect in KafkaSink
> ---
>
> Key: FLINK-27174
> URL: https://issues.apache.org/jira/browse/FLINK-27174
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
>Affects Versions: 1.14.4
>Reporter: Zhengqi Zhang
>Assignee: Zhengqi Zhang
>Priority: Major
> Labels: easyfix, pull-request-available
> Attachments: image-2022-04-11-18-11-18-576.png,
> image-2022-04-11-18-17-48-514.png
>
>
> If the user-supplied kafkaProducerConfig contains bootstrapServers
> information, there is no need to define the value of this field separately
> through the setBootstrapServers method. Obviously, the current code doesn't
> notice this.
> !image-2022-04-11-18-11-18-576.png|width=859,height=261!
>
> Perhaps we can check bootstrapServers as follows:
> !image-2022-04-11-18-17-48-514.png|width=861,height=322!
>
> {color:#172b4d}Or check bootstrapServers like KafkaSourceBuilder.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink
[
https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541377#comment-17541377
]
Fabian Paul commented on FLINK-27174:
-
Merged in release-1.14: c81a0512c7ade2ec4f2a91e98ec5ee4d09a66d3b
> Non-null check for bootstrapServers field is incorrect in KafkaSink
> ---
>
> Key: FLINK-27174
> URL: https://issues.apache.org/jira/browse/FLINK-27174
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
>Affects Versions: 1.14.4
>Reporter: Zhengqi Zhang
>Assignee: Zhengqi Zhang
>Priority: Major
> Labels: easyfix, pull-request-available
> Attachments: image-2022-04-11-18-11-18-576.png,
> image-2022-04-11-18-17-48-514.png
>
>
> If the user-supplied kafkaProducerConfig contains bootstrapServers
> information, there is no need to define the value of this field separately
> through the setBootstrapServers method. Obviously, the current code doesn't
> notice this.
> !image-2022-04-11-18-11-18-576.png|width=859,height=261!
>
> Perhaps we can check bootstrapServers as follows:
> !image-2022-04-11-18-17-48-514.png|width=861,height=322!
>
> {color:#172b4d}Or check bootstrapServers like KafkaSourceBuilder.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink
[
https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539571#comment-17539571
]
Fabian Paul commented on FLINK-27174:
-
Merged in master: b4bb9c8bffe1e37ad6912348d8b3bef89af42286
> Non-null check for bootstrapServers field is incorrect in KafkaSink
> ---
>
> Key: FLINK-27174
> URL: https://issues.apache.org/jira/browse/FLINK-27174
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
>Affects Versions: 1.14.4
>Reporter: Zhengqi Zhang
>Assignee: Zhengqi Zhang
>Priority: Major
> Labels: easyfix, pull-request-available
> Attachments: image-2022-04-11-18-11-18-576.png,
> image-2022-04-11-18-17-48-514.png
>
>
> If the user-supplied kafkaProducerConfig contains bootstrapServers
> information, there is no need to define the value of this field separately
> through the setBootstrapServers method. Obviously, the current code doesn't
> notice this.
> !image-2022-04-11-18-11-18-576.png|width=859,height=261!
>
> Perhaps we can check bootstrapServers as follows:
> !image-2022-04-11-18-17-48-514.png|width=861,height=322!
>
> {color:#172b4d}Or check bootstrapServers like KafkaSourceBuilder.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink
[
https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530500#comment-17530500
]
Zhengqi Zhang commented on FLINK-27174:
---
[~fpaul], If you think this proposal works, can you give me a ticket and I'll
be happy to try and fix it.
> Non-null check for bootstrapServers field is incorrect in KafkaSink
> ---
>
> Key: FLINK-27174
> URL: https://issues.apache.org/jira/browse/FLINK-27174
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
>Affects Versions: 1.14.4
>Reporter: Zhengqi Zhang
>Priority: Major
> Labels: easyfix
> Attachments: image-2022-04-11-18-11-18-576.png,
> image-2022-04-11-18-17-48-514.png
>
>
> If the user-supplied kafkaProducerConfig contains bootstrapServers
> information, there is no need to define the value of this field separately
> through the setBootstrapServers method. Obviously, the current code doesn't
> notice this.
> !image-2022-04-11-18-11-18-576.png|width=859,height=261!
>
> Perhaps we can check bootstrapServers as follows:
> !image-2022-04-11-18-17-48-514.png|width=861,height=322!
>
> {color:#172b4d}Or check bootstrapServers like KafkaSourceBuilder.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink
[
https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526356#comment-17526356
]
Zhengqi Zhang commented on FLINK-27174:
---
In the current code, if the user does not use the setBootstrapServers method to
set bootstrapServers, even if he provides it in a separate property, the
non-null check on bootstrapServers will fail, which is obviously unreasonable.
In fact, we can just check bootstrapServers in the final property.
> Non-null check for bootstrapServers field is incorrect in KafkaSink
> ---
>
> Key: FLINK-27174
> URL: https://issues.apache.org/jira/browse/FLINK-27174
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
>Affects Versions: 1.14.4
>Reporter: Zhengqi Zhang
>Priority: Major
> Labels: easyfix
> Attachments: image-2022-04-11-18-11-18-576.png,
> image-2022-04-11-18-17-48-514.png
>
>
> If the user-supplied kafkaProducerConfig contains bootstrapServers
> information, there is no need to define the value of this field separately
> through the setBootstrapServers method. Obviously, the current code doesn't
> notice this.
> !image-2022-04-11-18-11-18-576.png|width=859,height=261!
>
> Perhaps we can check bootstrapServers as follows:
> !image-2022-04-11-18-17-48-514.png|width=861,height=322!
>
> {color:#172b4d}Or check bootstrapServers like KafkaSourceBuilder.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink
[
https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526331#comment-17526331
]
Fabian Paul commented on FLINK-27174:
-
I think that is a valid point. We introduced the setBootstrapServers method to
keep in consistent with the KafkaSource. Do you want to work on relaxing the
check that it also allows the bootstrap servers as part of the properties?
> Non-null check for bootstrapServers field is incorrect in KafkaSink
> ---
>
> Key: FLINK-27174
> URL: https://issues.apache.org/jira/browse/FLINK-27174
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
>Affects Versions: 1.14.4
>Reporter: Zhengqi Zhang
>Priority: Major
> Labels: easyfix
> Attachments: image-2022-04-11-18-11-18-576.png,
> image-2022-04-11-18-17-48-514.png
>
>
> If the user-supplied kafkaProducerConfig contains bootstrapServers
> information, there is no need to define the value of this field separately
> through the setBootstrapServers method. Obviously, the current code doesn't
> notice this.
> !image-2022-04-11-18-11-18-576.png|width=859,height=261!
>
> Perhaps we can check bootstrapServers as follows:
> !image-2022-04-11-18-17-48-514.png|width=861,height=322!
>
> {color:#172b4d}Or check bootstrapServers like KafkaSourceBuilder.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink
[
https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526313#comment-17526313
]
Zhengqi Zhang commented on FLINK-27174:
---
[~fpaul] , please take a look
> Non-null check for bootstrapServers field is incorrect in KafkaSink
> ---
>
> Key: FLINK-27174
> URL: https://issues.apache.org/jira/browse/FLINK-27174
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
>Affects Versions: 1.14.4
>Reporter: Zhengqi Zhang
>Priority: Major
> Labels: easyfix
> Attachments: image-2022-04-11-18-11-18-576.png,
> image-2022-04-11-18-17-48-514.png
>
>
> If the user-supplied kafkaProducerConfig contains bootstrapServers
> information, there is no need to define the value of this field separately
> through the setBootstrapServers method. Obviously, the current code doesn't
> notice this.
> !image-2022-04-11-18-11-18-576.png|width=859,height=261!
>
> Perhaps we can check bootstrapServers as follows:
> !image-2022-04-11-18-17-48-514.png|width=861,height=322!
>
> {color:#172b4d}Or check bootstrapServers like KafkaSourceBuilder.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
