[jira] [Commented] (FLINK-27232) .scalafmt.conf cant be located when running in sub-directory
[ https://issues.apache.org/jira/browse/FLINK-27232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522372#comment-17522372 ] Marios Trivyzas commented on FLINK-27232: - I get your points, not insisting, we can leave it as is. > .scalafmt.conf cant be located when running in sub-directory > > > Key: FLINK-27232 > URL: https://issues.apache.org/jira/browse/FLINK-27232 > Project: Flink > Issue Type: Technical Debt > Components: Build System >Affects Versions: 1.16.0 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > > cd flink-scala > mvn validate > Error: Failed to execute goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check (spotless-check) on > project flink-scala_2.12: Execution spotless-check of goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check failed: Unable to > locate file with path: .scalafmt.conf: Could not find resource > '.scalafmt.conf'. -> [Help 1] > Currently breaks the docs build. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-27232) .scalafmt.conf cant be located when running in sub-directory
[ https://issues.apache.org/jira/browse/FLINK-27232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522334#comment-17522334 ] Chesnay Schepler commented on FLINK-27232: -- And what would be the practical benefit of running checkstyle later on? There are downsides, like having to spend time on other plugins, and the validate is a phase is quite useful to us because we don't do anything build-wise in said phase, so we avoid any potential plugin-ordering issues which could result in issues not being found consistently (imagine a plugin that modifies sources in process-sources; there's no reliable way to force checkstyle/spotless to run first). > .scalafmt.conf cant be located when running in sub-directory > > > Key: FLINK-27232 > URL: https://issues.apache.org/jira/browse/FLINK-27232 > Project: Flink > Issue Type: Technical Debt > Components: Build System >Affects Versions: 1.16.0 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > > cd flink-scala > mvn validate > Error: Failed to execute goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check (spotless-check) on > project flink-scala_2.12: Execution spotless-check of goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check failed: Unable to > locate file with path: .scalafmt.conf: Could not find resource > '.scalafmt.conf'. -> [Help 1] > Currently breaks the docs build. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-27232) .scalafmt.conf cant be located when running in sub-directory
[
https://issues.apache.org/jira/browse/FLINK-27232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522310#comment-17522310
]
Marios Trivyzas commented on FLINK-27232:
-
[https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#default-lifecycle]
I think that conceptually, checking the source files for checkstyle should be
done in the {{process-sources}} phase and not in the {{validate}} or
{{initialize}} phases which are for setting up things.
Furthermore the {{directory-maven-plugin}} should maybe be bound to
{{validate}} which is the 1st phase, to make sure that it's available from
{{initialize}} state on.
> .scalafmt.conf cant be located when running in sub-directory
>
>
> Key: FLINK-27232
> URL: https://issues.apache.org/jira/browse/FLINK-27232
> Project: Flink
> Issue Type: Technical Debt
> Components: Build System
>Affects Versions: 1.16.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Major
> Labels: pull-request-available
>
> cd flink-scala
> mvn validate
> Error: Failed to execute goal
> com.diffplug.spotless:spotless-maven-plugin:2.13.0:check (spotless-check) on
> project flink-scala_2.12: Execution spotless-check of goal
> com.diffplug.spotless:spotless-maven-plugin:2.13.0:check failed: Unable to
> locate file with path: .scalafmt.conf: Could not find resource
> '.scalafmt.conf'. -> [Help 1]
> Currently breaks the docs build.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27232) .scalafmt.conf cant be located when running in sub-directory
[ https://issues.apache.org/jira/browse/FLINK-27232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522301#comment-17522301 ] Chesnay Schepler commented on FLINK-27232: -- I don't quite follow the reasoning for changing the phase binding. > .scalafmt.conf cant be located when running in sub-directory > > > Key: FLINK-27232 > URL: https://issues.apache.org/jira/browse/FLINK-27232 > Project: Flink > Issue Type: Technical Debt > Components: Build System >Affects Versions: 1.16.0 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > > cd flink-scala > mvn validate > Error: Failed to execute goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check (spotless-check) on > project flink-scala_2.12: Execution spotless-check of goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check failed: Unable to > locate file with path: .scalafmt.conf: Could not find resource > '.scalafmt.conf'. -> [Help 1] > Currently breaks the docs build. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-27232) .scalafmt.conf cant be located when running in sub-directory
[
https://issues.apache.org/jira/browse/FLINK-27232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522286#comment-17522286
]
Marios Trivyzas commented on FLINK-27232:
-
Even if we come with some solution that takes us back to the same workflow
("autonomous" build inside any module), I think we should reconsider the phase
binding, according to my findings here:
https://github.com/apache/flink/pull/19472
> .scalafmt.conf cant be located when running in sub-directory
>
>
> Key: FLINK-27232
> URL: https://issues.apache.org/jira/browse/FLINK-27232
> Project: Flink
> Issue Type: Technical Debt
> Components: Build System
>Affects Versions: 1.16.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Major
> Labels: pull-request-available
>
> cd flink-scala
> mvn validate
> Error: Failed to execute goal
> com.diffplug.spotless:spotless-maven-plugin:2.13.0:check (spotless-check) on
> project flink-scala_2.12: Execution spotless-check of goal
> com.diffplug.spotless:spotless-maven-plugin:2.13.0:check failed: Unable to
> locate file with path: .scalafmt.conf: Could not find resource
> '.scalafmt.conf'. -> [Help 1]
> Currently breaks the docs build.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27232) .scalafmt.conf cant be located when running in sub-directory
[ https://issues.apache.org/jira/browse/FLINK-27232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1756#comment-1756 ] Timo Walther commented on FLINK-27232: -- In any case, it would be great to enable a simple `mvn clean install` in the `flink-table` module again. Running spotless directly is a less common task, given that the IDEs are executing it most of the time. We can also introduce a custom Maven phase if that is possible. > .scalafmt.conf cant be located when running in sub-directory > > > Key: FLINK-27232 > URL: https://issues.apache.org/jira/browse/FLINK-27232 > Project: Flink > Issue Type: Technical Debt > Components: Build System >Affects Versions: 1.16.0 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler >Priority: Major > > cd flink-scala > mvn validate > Error: Failed to execute goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check (spotless-check) on > project flink-scala_2.12: Execution spotless-check of goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check failed: Unable to > locate file with path: .scalafmt.conf: Could not find resource > '.scalafmt.conf'. -> [Help 1] > Currently breaks the docs build. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-27232) .scalafmt.conf cant be located when running in sub-directory
[ https://issues.apache.org/jira/browse/FLINK-27232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522212#comment-17522212 ] Chesnay Schepler commented on FLINK-27232: -- AFAIK multiModuleProjectDirectory would neither work properly (based on google results) nor is it supported in maven 3.2.5. The safest (and most annoying solution) solution I could come up is to explicitly configure the scala check in each scala-reliant module, with the correct path to the file. > .scalafmt.conf cant be located when running in sub-directory > > > Key: FLINK-27232 > URL: https://issues.apache.org/jira/browse/FLINK-27232 > Project: Flink > Issue Type: Technical Debt > Components: Build System >Affects Versions: 1.16.0 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler >Priority: Major > > cd flink-scala > mvn validate > Error: Failed to execute goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check (spotless-check) on > project flink-scala_2.12: Execution spotless-check of goal > com.diffplug.spotless:spotless-maven-plugin:2.13.0:check failed: Unable to > locate file with path: .scalafmt.conf: Could not find resource > '.scalafmt.conf'. -> [Help 1] > Currently breaks the docs build. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-27232) .scalafmt.conf cant be located when running in sub-directory
[
https://issues.apache.org/jira/browse/FLINK-27232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522206#comment-17522206
]
Timo Walther commented on FLINK-27232:
--
This is a big regression and we are currently also investigating it. CC
[~matriv] Even if it might cause other issues,
{{${maven.multiModuleProjectDirectory}}} seems the best solution yet even if
not perfect. But happy for better ideas.
> .scalafmt.conf cant be located when running in sub-directory
>
>
> Key: FLINK-27232
> URL: https://issues.apache.org/jira/browse/FLINK-27232
> Project: Flink
> Issue Type: Technical Debt
> Components: Build System
>Affects Versions: 1.16.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Major
>
> cd flink-scala
> mvn validate
> Error: Failed to execute goal
> com.diffplug.spotless:spotless-maven-plugin:2.13.0:check (spotless-check) on
> project flink-scala_2.12: Execution spotless-check of goal
> com.diffplug.spotless:spotless-maven-plugin:2.13.0:check failed: Unable to
> locate file with path: .scalafmt.conf: Could not find resource
> '.scalafmt.conf'. -> [Help 1]
> Currently breaks the docs build.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
