[jira] [Commented] (FLINK-28207) Disabling webhook should also disable mutator
[ https://issues.apache.org/jira/browse/FLINK-28207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557873#comment-17557873 ] Márton Balassi commented on FLINK-28207: Thanks for the clarification [~aitozi]. I will go with your suggestion. > Disabling webhook should also disable mutator > - > > Key: FLINK-28207 > URL: https://issues.apache.org/jira/browse/FLINK-28207 > Project: Flink > Issue Type: Improvement > Components: Kubernetes Operator >Reporter: Márton Balassi >Assignee: Márton Balassi >Priority: Major > Fix For: kubernetes-operator-1.1.0 > > > The configuration for the mutating webhook suggests that it is nested inside > the (validating) webhook: > https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/values.yaml#L73-L76 > Based on this I would expect that if I disable the top level webhook it also > disables the mutator, however this is not the case: > https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/webhook.yaml#L19-L79 > https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/webhook.yaml#L115-L148 > I do not see a use case currently where we would want the mutating webhook > without having the validating one, so I suggest following the hierarchy that > the helm configs imply. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FLINK-28207) Disabling webhook should also disable mutator
[
https://issues.apache.org/jira/browse/FLINK-28207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557763#comment-17557763
]
Aitozi commented on FLINK-28207:
The option is introduced to let user can choose to enable/disable the validator
and mutator individually. But, for compatibility, the validator option keep
with the {{webhook.create}}, It should be called {{webhook.validator.create}}
better, I think. The context is
[here|https://github.com/apache/flink-kubernetes-operator/pull/265#discussion_r895715818]
One another solution: we can add the {{webhook.validator.create}} and let the
{{webhook.create}} control both, WDYT ?
> Disabling webhook should also disable mutator
> -
>
> Key: FLINK-28207
> URL: https://issues.apache.org/jira/browse/FLINK-28207
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Márton Balassi
>Assignee: Márton Balassi
>Priority: Major
> Fix For: kubernetes-operator-1.1.0
>
>
> The configuration for the mutating webhook suggests that it is nested inside
> the (validating) webhook:
> https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/values.yaml#L73-L76
> Based on this I would expect that if I disable the top level webhook it also
> disables the mutator, however this is not the case:
> https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/webhook.yaml#L19-L79
> https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/webhook.yaml#L115-L148
> I do not see a use case currently where we would want the mutating webhook
> without having the validating one, so I suggest following the hierarchy that
> the helm configs imply.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-28207) Disabling webhook should also disable mutator
[ https://issues.apache.org/jira/browse/FLINK-28207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557677#comment-17557677 ] Márton Balassi commented on FLINK-28207: [~aitozi] do you have any concerns? > Disabling webhook should also disable mutator > - > > Key: FLINK-28207 > URL: https://issues.apache.org/jira/browse/FLINK-28207 > Project: Flink > Issue Type: Improvement > Components: Kubernetes Operator >Reporter: Márton Balassi >Assignee: Márton Balassi >Priority: Major > Fix For: kubernetes-operator-1.1.0 > > > The configuration for the mutating webhook suggests that it is nested inside > the (validating) webhook: > https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/values.yaml#L73-L76 > Based on this I would expect that if I disable the top level webhook it also > disables the mutator, however this is not the case: > https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/webhook.yaml#L19-L79 > https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/webhook.yaml#L115-L148 > I do not see a use case currently where we would want the mutating webhook > without having the validating one, so I suggest following the hierarchy that > the helm configs imply. -- This message was sent by Atlassian Jira (v8.20.7#820007)
