[jira] [Commented] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents

2022-09-13 Thread Tony Zhu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603822#comment-17603822
 ] 

Tony Zhu commented on FLINK-28902:
--

Can I try this ticket?

> FileSystemJobResultStoreTestInternal is a unit test that's not following the 
> unit test naming convents
> --
>
> Key: FLINK-28902
> URL: https://issues.apache.org/jira/browse/FLINK-28902
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination, Test Infrastructure
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Matthias Pohl
>Priority: Minor
>  Labels: starter
>
> AzureCI still picks the test up as part of {{mvn verify}} (see an [example 
> build|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39780&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=8539]).
> Anyway, we should move the {{Internal}} suffix and move it somewhere inside 
> of the test name.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents

2022-09-14 Thread Matthias Pohl (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603954#comment-17603954
 ] 

Matthias Pohl commented on FLINK-28902:
---

Sure, thanks for offering your help. I assigned the ticket to you.

> FileSystemJobResultStoreTestInternal is a unit test that's not following the 
> unit test naming convents
> --
>
> Key: FLINK-28902
> URL: https://issues.apache.org/jira/browse/FLINK-28902
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination, Test Infrastructure
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Matthias Pohl
>Assignee: Tony Zhu
>Priority: Minor
>  Labels: starter
>
> AzureCI still picks the test up as part of {{mvn verify}} (see an [example 
> build|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39780&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=8539]).
> Anyway, we should move the {{Internal}} suffix and move it somewhere inside 
> of the test name.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents

2022-09-14 Thread Tony Zhu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605120#comment-17605120
 ] 

Tony Zhu commented on FLINK-28902:
--

I created this PR. Could you help review please

> FileSystemJobResultStoreTestInternal is a unit test that's not following the 
> unit test naming convents
> --
>
> Key: FLINK-28902
> URL: https://issues.apache.org/jira/browse/FLINK-28902
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination, Test Infrastructure
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Matthias Pohl
>Assignee: Tony Zhu
>Priority: Minor
>  Labels: pull-request-available, starter
>
> AzureCI still picks the test up as part of {{mvn verify}} (see an [example 
> build|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39780&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=8539]).
> Anyway, we should move the {{Internal}} suffix and move it somewhere inside 
> of the test name.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)