[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601631#comment-17601631 ] jackylau commented on FLINK-29227: -- hi [~tiwalter] so i I propose to add disruptor to lib, whay do you think? com.lmax disruptor > shoud package disruptor(com.lmax) to flink lib for aync logger when > xxconnector using it. > - > > Key: FLINK-29227 > URL: https://issues.apache.org/jira/browse/FLINK-29227 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.17.0 >Reporter: jackylau >Priority: Major > Fix For: 1.17.0 > > > when i develop xxConnector which dependecncy like this > xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)） > xconnector loaded by user(childFirst) classloader > log4j2 which using loaded by app classloader, which make AsyncLoggerConfig > load by app classloader, according to the principle of classloader > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601767#comment-17601767 ] Chesnay Schepler commented on FLINK-29227: -- I don't really get the problem. If you want to use disruptor, add it to lib/. I don't understand why we should bundle additional things into Flink. > shoud package disruptor(com.lmax) to flink lib for aync logger when > xxconnector using it. > - > > Key: FLINK-29227 > URL: https://issues.apache.org/jira/browse/FLINK-29227 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.17.0 >Reporter: jackylau >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > > when i develop xxConnector which dependecncy like this > xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)） > xconnector loaded by user(childFirst) classloader > log4j2 which loaded by app classloader, which also make AsyncLoggerConfig > loaded by app classloader, according to the principle of classloader. and the > flink lib don't have disruptor, which cause ClassNotFound. Although, the > disruptor jar exists in my xxconnector > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601768#comment-17601768 ] jackylau commented on FLINK-29227: -- if xxconnector using async logger it will exists same problem. [~chesnay] https://logging.apache.org/log4j/2.x/manual/async.html > shoud package disruptor(com.lmax) to flink lib for aync logger when > xxconnector using it. > - > > Key: FLINK-29227 > URL: https://issues.apache.org/jira/browse/FLINK-29227 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.17.0 >Reporter: jackylau >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > > when i develop xxConnector which dependecncy like this > xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)） > xconnector loaded by user(childFirst) classloader > log4j2 which loaded by app classloader, which also make AsyncLoggerConfig > loaded by app classloader, according to the principle of classloader. and the > flink lib don't have disruptor, which cause ClassNotFound. Although, the > disruptor jar exists in my xxconnector > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601769#comment-17601769 ] Chesnay Schepler commented on FLINK-29227: -- What problem? If something you for logging use requires disruptor, then you must add it to lib/. If adding it to lib/ doesn't solve the problem, then bundling it in Flink _also_ doesn't solve the problem. > shoud package disruptor(com.lmax) to flink lib for aync logger when > xxconnector using it. > - > > Key: FLINK-29227 > URL: https://issues.apache.org/jira/browse/FLINK-29227 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.17.0 >Reporter: jackylau >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > > when i develop xxConnector which dependecncy like this > xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)） > xconnector loaded by user(childFirst) classloader > log4j2 which loaded by app classloader, which also make AsyncLoggerConfig > loaded by app classloader, according to the principle of classloader. and the > flink lib don't have disruptor, which cause ClassNotFound. Although, the > disruptor jar exists in my xxconnector > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601776#comment-17601776 ] jackylau commented on FLINK-29227: -- [~chesnay] yes, just need add disruptor to lib/. so i suggest add it into flink/lib. Otherwise users need to be added to their projects. And the current Flink project has declared this dependency in the parent POM. And the disruptor is dependent on Log4J2 for async logger and personally i believe it should be entered as well as log4j > shoud package disruptor(com.lmax) to flink lib for aync logger when > xxconnector using it. > - > > Key: FLINK-29227 > URL: https://issues.apache.org/jira/browse/FLINK-29227 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.17.0 >Reporter: jackylau >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > > when i develop xxConnector which dependecncy like this > xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)） > xconnector loaded by user(childFirst) classloader > log4j2 which loaded by app classloader, which also make AsyncLoggerConfig > loaded by app classloader, according to the principle of classloader. and the > flink lib don't have disruptor, which cause ClassNotFound. Although, the > disruptor jar exists in my xxconnector > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601780#comment-17601780 ] jackylau commented on FLINK-29227: -- and Async Logger is configurable like this !image-2022-09-08-20-03-27-219.png! > shoud package disruptor(com.lmax) to flink lib for aync logger when > xxconnector using it. > - > > Key: FLINK-29227 > URL: https://issues.apache.org/jira/browse/FLINK-29227 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.17.0 >Reporter: jackylau >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > Attachments: image-2022-09-08-20-03-27-219.png > > > when i develop xxConnector which dependecncy like this > xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)） > xconnector loaded by user(childFirst) classloader > log4j2 which loaded by app classloader, which also make AsyncLoggerConfig > loaded by app classloader, according to the principle of classloader. and the > flink lib don't have disruptor, which cause ClassNotFound. Although, the > disruptor jar exists in my xxconnector > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601813#comment-17601813 ] Jark Wu commented on FLINK-29227: - I agree with [~chesnay]. Flink should keep the default dependencies small and shouldn't bundle unnecessary dependencies. AFAIK, disruptor is a widely used dependency which means the high probability of conflict, but few users use async logger. So I think it's fine for the users who want to use async logger to manually add disruptor to flink/lib. It's just like how Hadoop users setup their Flink environment. > shoud package disruptor(com.lmax) to flink lib for aync logger when > xxconnector using it. > - > > Key: FLINK-29227 > URL: https://issues.apache.org/jira/browse/FLINK-29227 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.17.0 >Reporter: jackylau >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > Attachments: image-2022-09-08-20-03-27-219.png > > > when i develop xxConnector which dependecncy like this > xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)） > xconnector loaded by user(childFirst) classloader > log4j2 which loaded by app classloader, which also make AsyncLoggerConfig > loaded by app classloader, according to the principle of classloader. and the > flink lib don't have disruptor, which cause ClassNotFound. Although, the > disruptor jar exists in my xxconnector > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602061#comment-17602061 ] jackylau commented on FLINK-29227: -- [~jark] thanks for your careful explanation > shoud package disruptor(com.lmax) to flink lib for aync logger when > xxconnector using it. > - > > Key: FLINK-29227 > URL: https://issues.apache.org/jira/browse/FLINK-29227 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.17.0 >Reporter: jackylau >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > Attachments: image-2022-09-08-20-03-27-219.png > > > when i develop xxConnector which dependecncy like this > xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)） > xconnector loaded by user(childFirst) classloader > log4j2 which loaded by app classloader, which also make AsyncLoggerConfig > loaded by app classloader, according to the principle of classloader. and the > flink lib don't have disruptor, which cause ClassNotFound. Although, the > disruptor jar exists in my xxconnector > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602064#comment-17602064 ] jackylau commented on FLINK-29227: -- i close this issue [~jark] [~chesnay] > shoud package disruptor(com.lmax) to flink lib for aync logger when > xxconnector using it. > - > > Key: FLINK-29227 > URL: https://issues.apache.org/jira/browse/FLINK-29227 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.17.0 >Reporter: jackylau >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > Attachments: image-2022-09-08-20-03-27-219.png > > > when i develop xxConnector which dependecncy like this > xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)） > xconnector loaded by user(childFirst) classloader > log4j2 which loaded by app classloader, which also make AsyncLoggerConfig > loaded by app classloader, according to the principle of classloader. and the > flink lib don't have disruptor, which cause ClassNotFound. Although, the > disruptor jar exists in my xxconnector > -- This message was sent by Atlassian Jira (v8.20.10#820010)
