[jira] [Commented] (FLINK-29245) [JUnit 5 Migration] Remove RetryRule

2022-10-07 Thread Matthias Pohl (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613936#comment-17613936
 ] 

Matthias Pohl commented on FLINK-29245:
---

Good point. I went through the open FLINK-25325 subtasks and updated the 
assignee to make it more visual where there is work in progress already.

> [JUnit 5 Migration] Remove RetryRule
> 
>
> Key: FLINK-29245
> URL: https://issues.apache.org/jira/browse/FLINK-29245
> Project: Flink
>  Issue Type: Sub-task
>  Components: Documentation, Tests
>Affects Versions: 1.17.0
>Reporter: Matthias Pohl
>Priority: Major
>  Labels: starter
>
> With the transition to JUnit5, using 
> [RetryExtension|https://github.com/apache/flink/blob/78b231f60aed59061f0f609e0cfd659d78e6fdd5/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/extensions/retry/RetryExtension.java#L43]
>  is favored, anyway. {{RetryExtension}} also utilizes the annotations 
> {{@RetryOnException}} and {{@RetryOnFailure}} which still refer to 
> {{RetryRule}} in its JavaDoc.
> This issue is about cleaning things up around {{RetryRule}} and the related 
> JavaDocs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29245) [JUnit 5 Migration] Remove RetryRule

2022-10-06 Thread Nagaraj Tantri (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613755#comment-17613755
 ] 

Nagaraj Tantri commented on FLINK-29245:


Thanks [~mapohl] . Since most of the open tickets had "Can you assign this to 
me please?", I thought they would be picked up. Will keep an eye open for others

> [JUnit 5 Migration] Remove RetryRule
> 
>
> Key: FLINK-29245
> URL: https://issues.apache.org/jira/browse/FLINK-29245
> Project: Flink
>  Issue Type: Sub-task
>  Components: Documentation, Tests
>Affects Versions: 1.17.0
>Reporter: Matthias Pohl
>Priority: Major
>  Labels: starter
>
> With the transition to JUnit5, using 
> [RetryExtension|https://github.com/apache/flink/blob/78b231f60aed59061f0f609e0cfd659d78e6fdd5/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/extensions/retry/RetryExtension.java#L43]
>  is favored, anyway. {{RetryExtension}} also utilizes the annotations 
> {{@RetryOnException}} and {{@RetryOnFailure}} which still refer to 
> {{RetryRule}} in its JavaDoc.
> This issue is about cleaning things up around {{RetryRule}} and the related 
> JavaDocs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29245) [JUnit 5 Migration] Remove RetryRule

2022-10-04 Thread Matthias Pohl (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612501#comment-17612501
 ] 

Matthias Pohl commented on FLINK-29245:
---

Hi [~nagarajtantri], thanks for volunteering to fix this issue. This one 
specifically is currently blocked by other JUnit5 migrations (e.g. FLINK-25538 
as mentioned in [my comment 
above|https://issues.apache.org/jira/browse/FLINK-29245?focusedCommentId=17602326=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17602326]).
 I linked FLINK-25538 to make this clearer. You might want to pick up one of 
the other subtasks under FLINK-25325 if you'd like to help the community 
migrating to JUnit5

> [JUnit 5 Migration] Remove RetryRule
> 
>
> Key: FLINK-29245
> URL: https://issues.apache.org/jira/browse/FLINK-29245
> Project: Flink
>  Issue Type: Sub-task
>  Components: Documentation, Tests
>Affects Versions: 1.17.0
>Reporter: Matthias Pohl
>Priority: Major
>  Labels: starter
>
> With the transition to JUnit5, using 
> [RetryExtension|https://github.com/apache/flink/blob/78b231f60aed59061f0f609e0cfd659d78e6fdd5/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/extensions/retry/RetryExtension.java#L43]
>  is favored, anyway. {{RetryExtension}} also utilizes the annotations 
> {{@RetryOnException}} and {{@RetryOnFailure}} which still refer to 
> {{RetryRule}} in its JavaDoc.
> This issue is about cleaning things up around {{RetryRule}} and the related 
> JavaDocs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29245) [JUnit 5 Migration] Remove RetryRule

2022-10-03 Thread Nagaraj Tantri (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612480#comment-17612480
 ] 

Nagaraj Tantri commented on FLINK-29245:


Hi [~mapohl], I would like to work on this. Can I raise a PR?

> [JUnit 5 Migration] Remove RetryRule
> 
>
> Key: FLINK-29245
> URL: https://issues.apache.org/jira/browse/FLINK-29245
> Project: Flink
>  Issue Type: Sub-task
>  Components: Documentation, Tests
>Affects Versions: 1.17.0
>Reporter: Matthias Pohl
>Priority: Major
>  Labels: starter
>
> With the transition to JUnit5, using 
> [RetryExtension|https://github.com/apache/flink/blob/78b231f60aed59061f0f609e0cfd659d78e6fdd5/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/extensions/retry/RetryExtension.java#L43]
>  is favored, anyway. {{RetryExtension}} also utilizes the annotations 
> {{@RetryOnException}} and {{@RetryOnFailure}} which still refer to 
> {{RetryRule}} in its JavaDoc.
> This issue is about cleaning things up around {{RetryRule}} and the related 
> JavaDocs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)