[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011381#comment-15011381
 ] 

ASF GitHub Bot commented on FLINK-2989:
---

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/1344#issuecomment-157775857
  
LGTM


> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>Assignee: Maximilian Michels
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011505#comment-15011505
 ] 

ASF GitHub Bot commented on FLINK-2989:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1344


> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>Assignee: Maximilian Michels
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010962#comment-15010962
 ] 

ASF GitHub Bot commented on FLINK-2989:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/1344#issuecomment-157711251
  
I'm assuming everyone is ok with this workaround for now. If not please 
speak up. I'll merge this in time for 0.10.1.


> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>Assignee: Maximilian Michels
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009633#comment-15009633
 ] 

ASF GitHub Bot commented on FLINK-2989:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1344#issuecomment-157522724
  
Since Flink 0.10.1 is around the corner, we should merge this PR ;)


> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[Robert Metzger (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009635#comment-15009635
 ] 

Robert Metzger commented on FLINK-2989:
---

[~mxm], I've assigned you to the issue.

> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>Assignee: Maximilian Michels
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000301#comment-15000301
 ] 

ASF GitHub Bot commented on FLINK-2989:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1344#issuecomment-155763996
  
Maybe not as part of this PR, but in the long term, we should add a 
integration test for cancelling a job running in a YARN session.


> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000311#comment-15000311
 ] 

ASF GitHub Bot commented on FLINK-2989:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/1344#issuecomment-155764939
  
+1 for the integration test


> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[Maximilian Michels (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998474#comment-14998474
 ] 

Maximilian Michels commented on FLINK-2989:
---

Should we allow both, GET and DELETE? Via DELETE we would support Rest-style 
API calls if desired. For the cancel button we would use the GET interface to 
support YARN properly.

> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[Fabian Hueske (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998477#comment-14998477
 ] 

Fabian Hueske commented on FLINK-2989:
--

Sounds like a good idea to me

> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[Sachin Goel (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998485#comment-14998485
 ] 

Sachin Goel commented on FLINK-2989:


Good enough. Do we need this in the release?

> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998616#comment-14998616
 ] 

ASF GitHub Bot commented on FLINK-2989:
---

GitHub user mxm opened a pull request:

https://github.com/apache/flink/pull/1344

[FLINK-2989] job cancel button doesn't work on YARN

In addition to the REST-compliant "DELETE /jobs/", allows
cancellation also via a special GET request of the form
"GET /jobs//yarn-cancel".

That enables us to cancel jobs from the web frontend on YARN while
keeping a REST-compliant DELETE alternative.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mxm/flink yarn-cancel

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1344


commit 313aee9be2bbc18ce82469de5e75606083761016
Author: Maximilian Michels 
Date:   2015-11-10T12:35:58Z

[FLINK-2989] job cancel button doesn't work on YARN

In addition to the REST-compliant "DELETE /jobs/", allows
cancellation also via a special GET request of the form
"GET /jobs//yarn-cancel".

That enables us to cancel jobs from the web frontend on YARN while
keeping a REST-compliant DELETE alternative.




> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2989) Job Cancel button doesn't work on Yarn

[Maximilian Michels (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998615#comment-14998615
 ] 

Maximilian Michels commented on FLINK-2989:
---

No, we are currently opting for just fixing really critical issues. 

> Job Cancel button doesn't work on Yarn
> --
>
> Key: FLINK-2989
> URL: https://issues.apache.org/jira/browse/FLINK-2989
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Reporter: Sachin Goel
>
> The newly added Cancel button doesn't work on Yarn, when accessing via Yarn 
> Web Application proxy. It works fine when we're directly on the web monitor.
> The reason is Yarn doesn't allow DELETE requests to the AM yet. It should be 
> enabled in 2.8.0. [YARN-2031, YARN-2084.]
> A workaround for now can be to use a {{GET}} method instead of {{DELETE}}, 
> but that breaks the conventions of REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)