[jira] [Commented] (FLINK-31061) Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder rule which based on greedy algorithm
[ https://issues.apache.org/jira/browse/FLINK-31061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691961#comment-17691961 ] Yunhong Zheng commented on FLINK-31061: --- Thanks, [~JunRuiLi] for your careful testing. no problems were found during the test, so I will close this issue. > Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder > rule which based on greedy algorithm > - > > Key: FLINK-31061 > URL: https://issues.apache.org/jira/browse/FLINK-31061 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Affects Versions: 1.17.0 >Reporter: Yunhong Zheng >Assignee: Junrui Li >Priority: Major > Fix For: 1.17.0 > > > This issue aims to verify FLINK-30376: [Introduce a new flink bushy join > reorder rule which based on greedy > algorithm|https://issues.apache.org/jira/browse/FLINK-30376]. > In Flink-1.17, bushy join reorder strategy is the default join reorder > strategy, and this strategy can be disable by setting factor ' > table.optimizer.bushy-join-reorder-threshold' smaller that the table number > need to be reordered. If disabled, the Lopt join reorder strategy, which is > default join reorder strategy in Flink-1.16, will be choosen. > We can verify it in SQL client after we build the flink-dist package. > # Firstly, we need to create several tables (The best case is that these > tables have table and column statistics). > # Secondly, we need to set 'table.optimizer.join-reorder-enabled = true' to > open join reorder. > # Verify bushy join reorder (The default bushy join reorder threshold is 12, > so if the number of table smaller than 12, the join reorder strategy is bushy > join reorder). > # Compare the results of bushy join reorder and Lopt join reorder strategy. > Need to be same. > # If we want to create a bushy join tree after join reorder, we need to add > statistics. Like：'JoinReorderITCaseBase.testBushyTreeJoinReorder'. > If you meet any problems, it's welcome to ping me directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-31061) Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder rule which based on greedy algorithm
[ https://issues.apache.org/jira/browse/FLINK-31061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691004#comment-17691004 ] Junrui Li commented on FLINK-31061: --- I have tested it and it looks good to me. I used sql client to do the test by connecting it to Hive and set factor 'table.optimizer.bushy-join-reorder-threshold' = 1 to disable bushy join reorder and set 'table.optimizer.bushy-join-reorder-threshold' = 1000 to enable bushy join reorder. By running testing jobs, I can see that bushy join reorder is taking effect: the join operator plan is different and the job result is also as expected. > Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder > rule which based on greedy algorithm > - > > Key: FLINK-31061 > URL: https://issues.apache.org/jira/browse/FLINK-31061 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Affects Versions: 1.17.0 >Reporter: Yunhong Zheng >Assignee: Junrui Li >Priority: Major > Fix For: 1.17.0 > > > This issue aims to verify FLINK-30376: [Introduce a new flink bushy join > reorder rule which based on greedy > algorithm|https://issues.apache.org/jira/browse/FLINK-30376]. > In Flink-1.17, bushy join reorder strategy is the default join reorder > strategy, and this strategy can be disable by setting factor ' > table.optimizer.bushy-join-reorder-threshold' smaller that the table number > need to be reordered. If disabled, the Lopt join reorder strategy, which is > default join reorder strategy in Flink-1.16, will be choosen. > We can verify it in SQL client after we build the flink-dist package. > # Firstly, we need to create several tables (The best case is that these > tables have table and column statistics). > # Secondly, we need to set 'table.optimizer.join-reorder-enabled = true' to > open join reorder. > # Verify bushy join reorder (The default bushy join reorder threshold is 12, > so if the number of table smaller than 12, the join reorder strategy is bushy > join reorder). > # Compare the results of bushy join reorder and Lopt join reorder strategy. > Need to be same. > # If we want to create a bushy join tree after join reorder, we need to add > statistics. Like：'JoinReorderITCaseBase.testBushyTreeJoinReorder'. > If you meet any problems, it's welcome to ping me directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-31061) Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder rule which based on greedy algorithm
[ https://issues.apache.org/jira/browse/FLINK-31061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1767#comment-1767 ] Junrui Li commented on FLINK-31061: --- Thanks [~337361...@qq.com] for creating this issue, I'd like to do this testing work. > Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder > rule which based on greedy algorithm > - > > Key: FLINK-31061 > URL: https://issues.apache.org/jira/browse/FLINK-31061 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Affects Versions: 1.17.0 >Reporter: Yunhong Zheng >Priority: Major > Fix For: 1.17.0 > > > This issue aims to verify FLINK-30376: [Introduce a new flink bushy join > reorder rule which based on greedy > algorithm|https://issues.apache.org/jira/browse/FLINK-30376]. > In Flink-1.17, bushy join reorder strategy is the default join reorder > strategy, and this strategy can be disable by setting factor ' > table.optimizer.bushy-join-reorder-threshold' smaller that the table number > need to be reordered. If disabled, the Lopt join reorder strategy, which is > default join reorder strategy in Flink-1.16, will be choosen. > We can verify it in SQL client after we build the flink-dist package. > # Firstly, we need to create several tables (The best case is that these > tables have table and column statistics). > # Secondly, we need to set 'table.optimizer.join-reorder-enabled = true' to > open join reorder. > # Verify bushy join reorder (The default bushy join reorder threshold is 12, > so if the number of table smaller than 12, the join reorder strategy is bushy > join reorder). > # Compare the results of bushy join reorder and Lopt join reorder strategy. > Need to be same. > # If we want to create a bushy join tree after join reorder, we need to add > statistics. Like：'JoinReorderITCaseBase.testBushyTreeJoinReorder'. > If you meet any problems, it's welcome to ping me directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
