[jira] [Commented] (FLINK-33228) Fix the total current resource calculation when fulfilling requirements

2023-10-10 Thread Yangze Guo (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-33228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773872#comment-17773872
 ] 

Yangze Guo commented on FLINK-33228:


master: 5269631af525a01d944cfa9994a116fb27b80b1b

> Fix the total current resource calculation when fulfilling requirements
> ---
>
> Key: FLINK-33228
> URL: https://issues.apache.org/jira/browse/FLINK-33228
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination
>Affects Versions: 1.19.0
>Reporter: xiangyu feng
>Assignee: xiangyu feng
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.19.0
>
> Attachments: image-2023-10-10-16-09-23-635.png
>
>
> Currently, the `totalCurrentResources` calculation in 
> `DefaultResourceAllocationStrategy#tryFulfillRequirements` is wrong.
> `ResourceProfile.merge` will not change the original `ResourceProfile`.
> !image-2023-10-10-16-09-23-635.png|width=564,height=286!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-33228) Fix the total current resource calculation when fulfilling requirements

2023-10-10 Thread xiangyu feng (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-33228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773597#comment-17773597
 ] 

xiangyu feng commented on FLINK-33228:
--

Hi [~guoyangze], I fixed this issue by changing the totalCurrentResources from 
`ResourceProfile`  to `InternalResourceInfo`. Would u kindly assign this Jira 
to me?

> Fix the total current resource calculation when fulfilling requirements
> ---
>
> Key: FLINK-33228
> URL: https://issues.apache.org/jira/browse/FLINK-33228
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination
>Reporter: xiangyu feng
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2023-10-10-16-09-23-635.png
>
>
> Currently, the `totalCurrentResources` calculation in 
> `DefaultResourceAllocationStrategy#tryFulfillRequirements` is wrong.
> `ResourceProfile.merge` will not change the original `ResourceProfile`.
> !image-2023-10-10-16-09-23-635.png|width=564,height=286!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)