[jira] [Commented] (FLINK-3416) [py] .bat files fail when path contains spaces

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159038#comment-15159038
 ] 

ASF GitHub Bot commented on FLINK-3416:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/1674#discussion_r53794490
  
--- Diff: flink-dist/src/main/flink-bin/bin/pyflink2.bat ---
@@ -22,4 +22,4 @@ setlocal EnableDelayedExpansion
 SET bin=%~dp0
 SET FLINK_ROOT_DIR=%bin%..
 
-%FLINK_ROOT_DIR%\bin\flink run -v %FLINK_ROOT_DIR%\lib\flink-python*.jar 2 
%*
\ No newline at end of file
+"%FLINK_ROOT_DIR%\bin\flink" run -v 
"%FLINK_ROOT_DIR%"\lib\flink-python*.jar 2 %*
--- End diff --

that would result in all arguments passed being treated as a single 
argument.

if additional paths are 
* relative, Flink will receive a relative path and use internal tools to 
make them absolute.
* absolute, the user has to use "" himself.


> [py] .bat files fail when path contains spaces
> --
>
> Key: FLINK-3416
> URL: https://issues.apache.org/jira/browse/FLINK-3416
> Project: Flink
>  Issue Type: Bug
>  Components: Python API
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3416) [py] .bat files fail when path contains spaces

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159008#comment-15159008
 ] 

ASF GitHub Bot commented on FLINK-3416:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/1674#discussion_r53791882
  
--- Diff: flink-dist/src/main/flink-bin/bin/pyflink2.bat ---
@@ -22,4 +22,4 @@ setlocal EnableDelayedExpansion
 SET bin=%~dp0
 SET FLINK_ROOT_DIR=%bin%..
 
-%FLINK_ROOT_DIR%\bin\flink run -v %FLINK_ROOT_DIR%\lib\flink-python*.jar 2 
%*
\ No newline at end of file
+"%FLINK_ROOT_DIR%\bin\flink" run -v 
"%FLINK_ROOT_DIR%"\lib\flink-python*.jar 2 %*
--- End diff --

I was thinking of quotes around `%*`. This is necessary in the shell 
scripts.

If you haven't already, could you try something like WordCount with spaces 
in the output file name?


> [py] .bat files fail when path contains spaces
> --
>
> Key: FLINK-3416
> URL: https://issues.apache.org/jira/browse/FLINK-3416
> Project: Flink
>  Issue Type: Bug
>  Components: Python API
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3416) [py] .bat files fail when path contains spaces

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158934#comment-15158934
 ] 

ASF GitHub Bot commented on FLINK-3416:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1674


> [py] .bat files fail when path contains spaces
> --
>
> Key: FLINK-3416
> URL: https://issues.apache.org/jira/browse/FLINK-3416
> Project: Flink
>  Issue Type: Bug
>  Components: Python API
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3416) [py] .bat files fail when path contains spaces

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158573#comment-15158573
 ] 

ASF GitHub Bot commented on FLINK-3416:
---

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/1674#issuecomment-187605508
  
Changes look good to me. Thanks for your contribution @zentol. Will merge 
it.


> [py] .bat files fail when path contains spaces
> --
>
> Key: FLINK-3416
> URL: https://issues.apache.org/jira/browse/FLINK-3416
> Project: Flink
>  Issue Type: Bug
>  Components: Python API
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3416) [py] .bat files fail when path contains spaces

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156221#comment-15156221
 ] 

ASF GitHub Bot commented on FLINK-3416:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/1674#discussion_r53573047
  
--- Diff: flink-dist/src/main/flink-bin/bin/pyflink2.bat ---
@@ -22,4 +22,4 @@ setlocal EnableDelayedExpansion
 SET bin=%~dp0
 SET FLINK_ROOT_DIR=%bin%..
 
-%FLINK_ROOT_DIR%\bin\flink run -v %FLINK_ROOT_DIR%\lib\flink-python*.jar 2 
%*
\ No newline at end of file
+"%FLINK_ROOT_DIR%\bin\flink" run -v 
"%FLINK_ROOT_DIR%"\lib\flink-python*.jar 2 %*
--- End diff --

no, the jar name will never contain spaces


> [py] .bat files fail when path contains spaces
> --
>
> Key: FLINK-3416
> URL: https://issues.apache.org/jira/browse/FLINK-3416
> Project: Flink
>  Issue Type: Bug
>  Components: Python API
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3416) [py] .bat files fail when path contains spaces

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156179#comment-15156179
 ] 

ASF GitHub Bot commented on FLINK-3416:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/1674#discussion_r53571627
  
--- Diff: flink-dist/src/main/flink-bin/bin/pyflink2.bat ---
@@ -22,4 +22,4 @@ setlocal EnableDelayedExpansion
 SET bin=%~dp0
 SET FLINK_ROOT_DIR=%bin%..
 
-%FLINK_ROOT_DIR%\bin\flink run -v %FLINK_ROOT_DIR%\lib\flink-python*.jar 2 
%*
\ No newline at end of file
+"%FLINK_ROOT_DIR%\bin\flink" run -v 
"%FLINK_ROOT_DIR%"\lib\flink-python*.jar 2 %*
--- End diff --

Does the wildcard argument also need double quotes?


> [py] .bat files fail when path contains spaces
> --
>
> Key: FLINK-3416
> URL: https://issues.apache.org/jira/browse/FLINK-3416
> Project: Flink
>  Issue Type: Bug
>  Components: Python API
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3416) [py] .bat files fail when path contains spaces

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154038#comment-15154038
 ] 

ASF GitHub Bot commented on FLINK-3416:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/1674

[FLINK-3416] [py] Support for spaces in flink path



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 3416_py_win

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1674


commit 842934ec2491890dac8f0df05c73fca9e1f5cb3d
Author: zentol 
Date:   2016-02-19T10:11:04Z

[FLINK-3416] [py] Support for spaces in flink path




> [py] .bat files fail when path contains spaces
> --
>
> Key: FLINK-3416
> URL: https://issues.apache.org/jira/browse/FLINK-3416
> Project: Flink
>  Issue Type: Bug
>  Components: Python API
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)