[jira] [Commented] (FLINK-34517) environment configs ignored when calling procedure operation

2024-02-26 Thread JustinLee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820650#comment-17820650
 ] 

JustinLee commented on FLINK-34517:
---

I'd like to take this ticket. [~hackergin]  Could you help to assign this to me?

> environment configs ignored when calling procedure operation
> 
>
> Key: FLINK-34517
> URL: https://issues.apache.org/jira/browse/FLINK-34517
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.18.0
>Reporter: JustinLee
>Priority: Major
>
> when calling ProcedureOperation in flink sql , the ProcedureContext only 
> contains the underlying application-specific config , not 
> environment-specific config,
> to be more specific , in a  flink sql app of the same 
> StreamExecutionEnvironment ,which has a config1. when executing a query, 
> config1 works , while executing a procedure, config1  doesn't work, which 
> apparently is not an expected behavior.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-34517) environment configs ignored when calling procedure operation

2024-02-26 Thread xuyang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820947#comment-17820947
 ] 

xuyang commented on FLINK-34517:


Hi, [~JustinLee] . Do you mean there are some configs lost when executing 
procedure in SqlGateway? IIUC, the table config used when calling procedure is 
from `ExecutableOperationContextImpl`, which is built in `OperationExecutor` 
with the logic following.
{code:java}
private TableConfig tableConfig() {
Configuration operationConfig = sessionContext.getSessionConf().clone();
operationConfig.addAll(executionConfig);

TableConfig tableConfig = TableConfig.getDefault();

tableConfig.setRootConfiguration(sessionContext.getDefaultContext().getFlinkConfig());
tableConfig.addConfiguration(operationConfig);

return tableConfig;
} {code}

> environment configs ignored when calling procedure operation
> 
>
> Key: FLINK-34517
> URL: https://issues.apache.org/jira/browse/FLINK-34517
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.18.0
>Reporter: JustinLee
>Assignee: JustinLee
>Priority: Major
>
> when calling procedure operation in Flink SQL, the ProcedureContext only 
> contains the underlying application-specific config , not 
> environment-specific config.
> to be more specific, in a  Flink sql app of the same 
> StreamExecutionEnvironment which has a config1. when executing a sql query, 
> config1 works, while calling a sql procedure, config1 doesn't work, which 
> apparently is not an expected behavior.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-34517) environment configs ignored when calling procedure operation

2024-02-27 Thread JustinLee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821495#comment-17821495
 ] 

JustinLee commented on FLINK-34517:
---

Hi, [~xuyangzhong] . Not executing in SqlGateway , just in a normal sql app can 
remark the promblem , i illustrate it in the test case in the 
[pr-24397|[https://github.com/apache/flink/pull/24397],] you can have a look If 
it's convenient for you. Thanks

 

> environment configs ignored when calling procedure operation
> 
>
> Key: FLINK-34517
> URL: https://issues.apache.org/jira/browse/FLINK-34517
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.18.0
>Reporter: JustinLee
>Assignee: JustinLee
>Priority: Major
>  Labels: pull-request-available
>
> when calling procedure operation in Flink SQL, the ProcedureContext only 
> contains the underlying application-specific config , not 
> environment-specific config.
> to be more specific, in a  Flink sql app of the same 
> StreamExecutionEnvironment which has a config1. when executing a sql query, 
> config1 works, while calling a sql procedure, config1 doesn't work, which 
> apparently is not an expected behavior.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-34517) environment configs ignored when calling procedure operation

2024-03-04 Thread luoyuxia (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823069#comment-17823069
 ] 

luoyuxia commented on FLINK-34517:
--

1.18: 620c5a7aeba448d247107ad44a6ba6f1e759052e

master: todo

> environment configs ignored when calling procedure operation
> 
>
> Key: FLINK-34517
> URL: https://issues.apache.org/jira/browse/FLINK-34517
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.18.0
>Reporter: JustinLee
>Assignee: JustinLee
>Priority: Major
>  Labels: pull-request-available
>
> when calling procedure operation in Flink SQL, the ProcedureContext only 
> contains the underlying application-specific config , not 
> environment-specific config.
> to be more specific, in a  Flink sql app of the same 
> StreamExecutionEnvironment which has a config1. when executing a sql query, 
> config1 works, while calling a sql procedure, config1 doesn't work, which 
> apparently is not an expected behavior.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)