[jira] [Commented] (FLINK-34673) SessionRelatedITCase#testTouchSession failure on GitHub Actions
[
https://issues.apache.org/jira/browse/FLINK-34673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848576#comment-17848576
]
Juanvi Soler commented on FLINK-34673:
--
Ended up just adding before the second request:
{code:java}
Thread.sleep(1); // ensure requests are not sent at the same time {code}
> SessionRelatedITCase#testTouchSession failure on GitHub Actions
> ---
>
> Key: FLINK-34673
> URL: https://issues.apache.org/jira/browse/FLINK-34673
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Gateway
>Affects Versions: 1.19.0
>Reporter: Ryan Skraba
>Priority: Major
> Labels: pull-request-available, starter, test-stability
>
> [https://github.com/apache/flink/actions/runs/8258416388/job/22590907051#step:10:12155]
> {code:java}
> Error: 03:08:21 03:08:21.304 [ERROR]
> org.apache.flink.table.gateway.rest.SessionRelatedITCase.testTouchSession --
> Time elapsed: 0.015 s <<< FAILURE!
> Mar 13 03:08:21 java.lang.AssertionError:
> Mar 13 03:08:21
> Mar 13 03:08:21 Expecting actual:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21 to be greater than:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21
> Mar 13 03:08:21 at
> org.apache.flink.table.gateway.rest.SessionRelatedITCase.testTouchSession(SessionRelatedITCase.java:175)
> Mar 13 03:08:21 at
> java.base/java.lang.reflect.Method.invoke(Method.java:580)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34673) SessionRelatedITCase#testTouchSession failure on GitHub Actions
[
https://issues.apache.org/jira/browse/FLINK-34673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848537#comment-17848537
]
Juanvi Soler commented on FLINK-34673:
--
Thanks [~rskraba] ! I wasn't able to reproduce it but created
[https://github.com/apache/flink/pull/24826]
Let me know what you think
> SessionRelatedITCase#testTouchSession failure on GitHub Actions
> ---
>
> Key: FLINK-34673
> URL: https://issues.apache.org/jira/browse/FLINK-34673
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Gateway
>Affects Versions: 1.19.0
>Reporter: Ryan Skraba
>Priority: Major
> Labels: pull-request-available, starter, test-stability
>
> [https://github.com/apache/flink/actions/runs/8258416388/job/22590907051#step:10:12155]
> {code:java}
> Error: 03:08:21 03:08:21.304 [ERROR]
> org.apache.flink.table.gateway.rest.SessionRelatedITCase.testTouchSession --
> Time elapsed: 0.015 s <<< FAILURE!
> Mar 13 03:08:21 java.lang.AssertionError:
> Mar 13 03:08:21
> Mar 13 03:08:21 Expecting actual:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21 to be greater than:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21
> Mar 13 03:08:21 at
> org.apache.flink.table.gateway.rest.SessionRelatedITCase.testTouchSession(SessionRelatedITCase.java:175)
> Mar 13 03:08:21 at
> java.base/java.lang.reflect.Method.invoke(Method.java:580)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34673) SessionRelatedITCase#testTouchSession failure on GitHub Actions
[
https://issues.apache.org/jira/browse/FLINK-34673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848115#comment-17848115
]
Ryan Skraba commented on FLINK-34673:
-
Hello! This is an easy one to reproduce, by launching it in IntelliJ (for
example) and setting the run configuration to Repeat until failure. It
normally only takes about 100 or so runs to demonstrate the flaky test.
In this case, the motivation is to reduce the (vast) number of flaky tests so
that we can trust that CI results are reliably real failures. The test is
faulty, not any code that would find itself in production!
> SessionRelatedITCase#testTouchSession failure on GitHub Actions
> ---
>
> Key: FLINK-34673
> URL: https://issues.apache.org/jira/browse/FLINK-34673
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Gateway
>Affects Versions: 1.19.0
>Reporter: Ryan Skraba
>Priority: Major
> Labels: starter, test-stability
>
> [https://github.com/apache/flink/actions/runs/8258416388/job/22590907051#step:10:12155]
> {code:java}
> Error: 03:08:21 03:08:21.304 [ERROR]
> org.apache.flink.table.gateway.rest.SessionRelatedITCase.testTouchSession --
> Time elapsed: 0.015 s <<< FAILURE!
> Mar 13 03:08:21 java.lang.AssertionError:
> Mar 13 03:08:21
> Mar 13 03:08:21 Expecting actual:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21 to be greater than:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21
> Mar 13 03:08:21 at
> org.apache.flink.table.gateway.rest.SessionRelatedITCase.testTouchSession(SessionRelatedITCase.java:175)
> Mar 13 03:08:21 at
> java.base/java.lang.reflect.Method.invoke(Method.java:580)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34673) SessionRelatedITCase#testTouchSession failure on GitHub Actions
[
https://issues.apache.org/jira/browse/FLINK-34673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848062#comment-17848062
]
Juanvi Soler commented on FLINK-34673:
--
[~rskraba] I tried to reproduce this without success:
{code:java}
./mvnw -f ./flink-table/flink-sql-gateway/pom.xml
-Dtest=SessionRelatedITCase#testTouchSession test [INFO] Scanning for
projects...
[INFO]
[INFO] -< org.apache.flink:flink-sql-gateway >-
[INFO] Building Flink : Table : SQL Gateway 1.19-SNAPSHOT
[INFO] [ jar ]-
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (validate) @ flink-sql-gateway
---
[WARNING] Old version of checkstyle detected. Consider updating to >= v8.30
[WARNING] For more information see:
https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] --- spotless-maven-plugin:2.27.1:check (spotless-check) @
flink-sql-gateway ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.1.0:enforce (enforce-maven-version) @
flink-sql-gateway ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.1.0:enforce (enforce-maven) @
flink-sql-gateway ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.1.0:enforce (ban-unsafe-snakeyaml) @
flink-sql-gateway ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.1.0:enforce (ban-unsafe-jackson) @
flink-sql-gateway ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.1.0:enforce (forbid-log4j-1) @
flink-sql-gateway ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.1.0:enforce
(forbid-direct-akka-rpc-dependencies) @ flink-sql-gateway ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.1.0:enforce
(forbid-direct-table-planner-dependencies) @ flink-sql-gateway ---
[INFO]
[INFO] --- directory-maven-plugin:0.1:directory-of (directories) @
flink-sql-gateway ---
[INFO] Directory of org.apache.flink:flink-parent set to:
/Users/juanvicentes/projects/forks/flink
[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles)
@ flink-sql-gateway ---
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @
flink-sql-gateway ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @
flink-sql-gateway ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @
flink-sql-gateway ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @
flink-sql-gateway ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:3.2.2:test (default-test) @ flink-sql-gateway
---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running org.apache.flink.table.gateway.rest.SessionRelatedITCase
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.359 s
-- in org.apache.flink.table.gateway.rest.SessionRelatedITCase
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 5.891 s
[INFO] Finished at: 2024-05-21T08:23:16+02:00
[INFO]
{code}
Any ideas?
> SessionRelatedITCase#testTouchSession failure on GitHub Actions
> ---
>
> Key: FLINK-34673
> URL: https://issues.apache.org/jira/browse/FLINK-34673
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Gateway
>Affects Versions: 1.19.0
>Reporter: Ryan Skraba
>Priority: Major
> Labels: starter, test-stability
>
> [https://github.com/apache/flink/actions/runs/8258416388/job/22590907051#step:10:12155]
> {code:java}
> Error: 03:08:21 03:08:21.304 [ERROR]
> org.apache.flink.table.gateway.rest.SessionRelatedITCase.testTouchSession --
> Time elapsed: 0.015 s <<< FAILURE!
> Mar 13 03:08:21 java.lang.AssertionError:
> Mar 13 03:08:21
> Mar 13 03:08:21 Expecting actual:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21 to be greater than:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21
> Mar 13 03:08:21 at
>
[jira] [Commented] (FLINK-34673) SessionRelatedITCase#testTouchSession failure on GitHub Actions
[
https://issues.apache.org/jira/browse/FLINK-34673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827172#comment-17827172
]
Ryan Skraba commented on FLINK-34673:
-
While I normally dislike putting "Thread.sleep(...)" in a test, it would
probably be the most appropriate fix for this and ensure that the two requests
don't happen in the same millisecond.
> SessionRelatedITCase#testTouchSession failure on GitHub Actions
> ---
>
> Key: FLINK-34673
> URL: https://issues.apache.org/jira/browse/FLINK-34673
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Gateway
>Affects Versions: 1.19.0
>Reporter: Ryan Skraba
>Priority: Major
> Labels: starter, test-stability
>
> [https://github.com/apache/flink/actions/runs/8258416388/job/22590907051#step:10:12155]
> {code:java}
> Error: 03:08:21 03:08:21.304 [ERROR]
> org.apache.flink.table.gateway.rest.SessionRelatedITCase.testTouchSession --
> Time elapsed: 0.015 s <<< FAILURE!
> Mar 13 03:08:21 java.lang.AssertionError:
> Mar 13 03:08:21
> Mar 13 03:08:21 Expecting actual:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21 to be greater than:
> Mar 13 03:08:21 1710299301198L
> Mar 13 03:08:21
> Mar 13 03:08:21 at
> org.apache.flink.table.gateway.rest.SessionRelatedITCase.testTouchSession(SessionRelatedITCase.java:175)
> Mar 13 03:08:21 at
> java.base/java.lang.reflect.Method.invoke(Method.java:580)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
> Mar 13 03:08:21 at
> java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
