[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226444#comment-15226444 ] ASF GitHub Bot commented on FLINK-3614: --- Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1805 > Remove Non-Keyed Window Operator > > > Key: FLINK-3614 > URL: https://issues.apache.org/jira/browse/FLINK-3614 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek >Assignee: Aljoscha Krettek > > I propose to remove the special Non-Keyed Window Operator and implement > non-parallel windows by using the standard WindowOperator with a dummy > KeySelector. > Maintaining everything for two WindowOperators is a huge burden. The > implementation is completely separate by now. For example, the Non-Keyed > window operator does not use the StateBackend for state, i.e. cannot use > RocksDB. Also, with upcoming changes (Merging/Session windows, aligned > windows) this will only increase the maintenance burden. > Also, the fast AlignedProcessingTimeWindows operators also only support the > Parallel/Keyed case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226443#comment-15226443 ] ASF GitHub Bot commented on FLINK-3614: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1805#issuecomment-205855000 Manually merged. > Remove Non-Keyed Window Operator > > > Key: FLINK-3614 > URL: https://issues.apache.org/jira/browse/FLINK-3614 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek >Assignee: Aljoscha Krettek > > I propose to remove the special Non-Keyed Window Operator and implement > non-parallel windows by using the standard WindowOperator with a dummy > KeySelector. > Maintaining everything for two WindowOperators is a huge burden. The > implementation is completely separate by now. For example, the Non-Keyed > window operator does not use the StateBackend for state, i.e. cannot use > RocksDB. Also, with upcoming changes (Merging/Session windows, aligned > windows) this will only increase the maintenance burden. > Also, the fast AlignedProcessingTimeWindows operators also only support the > Parallel/Keyed case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219732#comment-15219732 ] ASF GitHub Bot commented on FLINK-3614: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1805#issuecomment-203875675 Any thoughts on this? > Remove Non-Keyed Window Operator > > > Key: FLINK-3614 > URL: https://issues.apache.org/jira/browse/FLINK-3614 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek >Assignee: Aljoscha Krettek > > I propose to remove the special Non-Keyed Window Operator and implement > non-parallel windows by using the standard WindowOperator with a dummy > KeySelector. > Maintaining everything for two WindowOperators is a huge burden. The > implementation is completely separate by now. For example, the Non-Keyed > window operator does not use the StateBackend for state, i.e. cannot use > RocksDB. Also, with upcoming changes (Merging/Session windows, aligned > windows) this will only increase the maintenance burden. > Also, the fast AlignedProcessingTimeWindows operators also only support the > Parallel/Keyed case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198121#comment-15198121 ] ASF GitHub Bot commented on FLINK-3614: --- GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1805 [FLINK-3614] Remove Non-Keyed Window Operator Instead we use a dummy KeySelector and the regular WindowOperator now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink window-remove-non-keyed-operator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1805.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1805 commit 0730c5d46168ef530dbd4058e44f98973628af0e Author: Aljoscha Krettek Date: 2016-03-16T14:59:05Z [FLINK-3614] Remove Non-Keyed Window Operator Instead we use a dummy KeySelector and the regular WindowOperator now. > Remove Non-Keyed Window Operator > > > Key: FLINK-3614 > URL: https://issues.apache.org/jira/browse/FLINK-3614 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek >Assignee: Aljoscha Krettek > > I propose to remove the special Non-Keyed Window Operator and implement > non-parallel windows by using the standard WindowOperator with a dummy > KeySelector. > Maintaining everything for two WindowOperators is a huge burden. The > implementation is completely separate by now. For example, the Non-Keyed > window operator does not use the StateBackend for state, i.e. cannot use > RocksDB. Also, with upcoming changes (Merging/Session windows, aligned > windows) this will only increase the maintenance burden. > Also, the fast AlignedProcessingTimeWindows operators also only support the > Parallel/Keyed case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197171#comment-15197171 ] Aljoscha Krettek commented on FLINK-3614: - Yes, the parallel pre-aggregation will have to get its own issue, however. :-) > Remove Non-Keyed Window Operator > > > Key: FLINK-3614 > URL: https://issues.apache.org/jira/browse/FLINK-3614 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek >Assignee: Aljoscha Krettek > > I propose to remove the special Non-Keyed Window Operator and implement > non-parallel windows by using the standard WindowOperator with a dummy > KeySelector. > Maintaining everything for two WindowOperators is a huge burden. The > implementation is completely separate by now. For example, the Non-Keyed > window operator does not use the StateBackend for state, i.e. cannot use > RocksDB. Also, with upcoming changes (Merging/Session windows, aligned > windows) this will only increase the maintenance burden. > Also, the fast AlignedProcessingTimeWindows operators also only support the > Parallel/Keyed case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197076#comment-15197076 ] Maximilian Michels commented on FLINK-3614: --- +1 > Remove Non-Keyed Window Operator > > > Key: FLINK-3614 > URL: https://issues.apache.org/jira/browse/FLINK-3614 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek >Assignee: Aljoscha Krettek > > I propose to remove the special Non-Keyed Window Operator and implement > non-parallel windows by using the standard WindowOperator with a dummy > KeySelector. > Maintaining everything for two WindowOperators is a huge burden. The > implementation is completely separate by now. For example, the Non-Keyed > window operator does not use the StateBackend for state, i.e. cannot use > RocksDB. Also, with upcoming changes (Merging/Session windows, aligned > windows) this will only increase the maintenance burden. > Also, the fast AlignedProcessingTimeWindows operators also only support the > Parallel/Keyed case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195046#comment-15195046 ] Gyula Fora commented on FLINK-3614: --- I think this is a very good idea, and also this is probably the right time to add parallel pre-aggregation for global window reduces. > Remove Non-Keyed Window Operator > > > Key: FLINK-3614 > URL: https://issues.apache.org/jira/browse/FLINK-3614 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek >Assignee: Aljoscha Krettek > > I propose to remove the special Non-Keyed Window Operator and implement > non-parallel windows by using the standard WindowOperator with a dummy > KeySelector. > Maintaining everything for two WindowOperators is a huge burden. The > implementation is completely separate by now. For example, the Non-Keyed > window operator does not use the StateBackend for state, i.e. cannot use > RocksDB. Also, with upcoming changes (Merging/Session windows, aligned > windows) this will only increase the maintenance burden. > Also, the fast AlignedProcessingTimeWindows operators also only support the > Parallel/Keyed case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
