[jira] [Commented] (FLINK-4172) Don't proxy a ProxiedObject
[ https://issues.apache.org/jira/browse/FLINK-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368272#comment-15368272 ] ASF GitHub Bot commented on FLINK-4172: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2213 > Don't proxy a ProxiedObject > --- > > Key: FLINK-4172 > URL: https://issues.apache.org/jira/browse/FLINK-4172 > Project: Flink > Issue Type: Bug > Components: Gelly >Affects Versions: 1.1.0 >Reporter: Greg Hogan >Assignee: Greg Hogan > Fix For: 1.1.0 > > > Some graph algorithms pass through a DataSet unmodified (at least, until we > have VertexSet and EdgeSet). We need to prevent a DataSet from being proxied > twice. Allowing two methods to own a single object sounds brittle, so we can > instead provide access to the original DataSet which can be wrapped in a new > proxy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4172) Don't proxy a ProxiedObject
[ https://issues.apache.org/jira/browse/FLINK-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367713#comment-15367713 ] ASF GitHub Bot commented on FLINK-4172: --- Github user uce commented on the issue: https://github.com/apache/flink/pull/2213 +1 to merge. The previously not working `TriangleListing` example (undirected, rmat, print) is now working with this change. > Don't proxy a ProxiedObject > --- > > Key: FLINK-4172 > URL: https://issues.apache.org/jira/browse/FLINK-4172 > Project: Flink > Issue Type: Bug > Components: Gelly >Affects Versions: 1.1.0 >Reporter: Greg Hogan >Assignee: Greg Hogan > Fix For: 1.1.0 > > > Some graph algorithms pass through a DataSet unmodified (at least, until we > have VertexSet and EdgeSet). We need to prevent a DataSet from being proxied > twice. Allowing two methods to own a single object sounds brittle, so we can > instead provide access to the original DataSet which can be wrapped in a new > proxy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4172) Don't proxy a ProxiedObject
[ https://issues.apache.org/jira/browse/FLINK-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367593#comment-15367593 ] ASF GitHub Bot commented on FLINK-4172: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2213 I am not an expert in the proxy magic of Gelly, but it looks fine to me. From my side, feel free to merge at your discretion... > Don't proxy a ProxiedObject > --- > > Key: FLINK-4172 > URL: https://issues.apache.org/jira/browse/FLINK-4172 > Project: Flink > Issue Type: Bug > Components: Gelly >Affects Versions: 1.1.0 >Reporter: Greg Hogan >Assignee: Greg Hogan > Fix For: 1.1.0 > > > Some graph algorithms pass through a DataSet unmodified (at least, until we > have VertexSet and EdgeSet). We need to prevent a DataSet from being proxied > twice. Allowing two methods to own a single object sounds brittle, so we can > instead provide access to the original DataSet which can be wrapped in a new > proxy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4172) Don't proxy a ProxiedObject
[ https://issues.apache.org/jira/browse/FLINK-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367591#comment-15367591 ] ASF GitHub Bot commented on FLINK-4172: --- Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2213 @vasia or @StephanEwen would you have a minute to look this over? I'll look to merge this for RC1. > Don't proxy a ProxiedObject > --- > > Key: FLINK-4172 > URL: https://issues.apache.org/jira/browse/FLINK-4172 > Project: Flink > Issue Type: Bug > Components: Gelly >Affects Versions: 1.1.0 >Reporter: Greg Hogan >Assignee: Greg Hogan > Fix For: 1.1.0 > > > Some graph algorithms pass through a DataSet unmodified (at least, until we > have VertexSet and EdgeSet). We need to prevent a DataSet from being proxied > twice. Allowing two methods to own a single object sounds brittle, so we can > instead provide access to the original DataSet which can be wrapped in a new > proxy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4172) Don't proxy a ProxiedObject
[ https://issues.apache.org/jira/browse/FLINK-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366112#comment-15366112 ] ASF GitHub Bot commented on FLINK-4172: --- GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2213 [FLINK-4172] [gelly] Don't proxy a ProxiedObject Retrieve the proxied object and wrap in a new proxy. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 4172_dont_proxy_a_proxiedobject Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2213 commit 91526d6ce6989dc65863b414c3ae074f33476046 Author: Greg Hogan Date: 2016-07-07T13:35:29Z [FLINK-4172] [gelly] Don't proxy a ProxiedObject Retrieve the proxied object and wrap in a new proxy. > Don't proxy a ProxiedObject > --- > > Key: FLINK-4172 > URL: https://issues.apache.org/jira/browse/FLINK-4172 > Project: Flink > Issue Type: Bug > Components: Gelly >Affects Versions: 1.1.0 >Reporter: Greg Hogan >Assignee: Greg Hogan > Fix For: 1.1.0 > > > Some graph algorithms pass through a DataSet unmodified (at least, until we > have VertexSet and EdgeSet). We need to prevent a DataSet from being proxied > twice. Allowing two methods to own a single object sounds brittle, so we can > instead provide access to the original DataSet which can be wrapped in a new > proxy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
