[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588216#comment-15588216 ] ASF GitHub Bot commented on FLINK-4619: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2498 > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.0, 1.1.1, 1.1.2 >Reporter: Maciej Prochniak > Fix For: 1.2.0, 1.1.3 > > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582373#comment-15582373 ] ASF GitHub Bot commented on FLINK-4619: --- Github user uce commented on the issue: https://github.com/apache/flink/pull/2498 Yes, I merge this later today. > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.0, 1.1.1, 1.1.2 >Reporter: Maciej Prochniak > Fix For: 1.2.0, 1.1.3 > > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582020#comment-15582020 ] ASF GitHub Bot commented on FLINK-4619: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2498 No need to re-trigger this. Travis green light is good. @uce - Do you think this works well with your latest changes? > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.0, 1.1.1, 1.1.2 >Reporter: Maciej Prochniak > Fix For: 1.2.0, 1.1.3 > > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581389#comment-15581389 ] ASF GitHub Bot commented on FLINK-4619: --- Github user mproch commented on the issue: https://github.com/apache/flink/pull/2498 @StephanEwen can I retrigger this or whatever? > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.0, 1.1.1, 1.1.2 >Reporter: Maciej Prochniak > Fix For: 1.2.0, 1.1.3 > > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558432#comment-15558432 ] ASF GitHub Bot commented on FLINK-4619: --- Github user mproch commented on the issue: https://github.com/apache/flink/pull/2498 Hmm... I managed to make travis build pass, but I cannot see how jenkins test failures relate to my change... > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.0, 1.1.1, 1.1.2 >Reporter: Maciej Prochniak > Fix For: 1.2.0, 1.1.3 > > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494099#comment-15494099 ] ASF GitHub Bot commented on FLINK-4619: --- Github user mproch commented on the issue: https://github.com/apache/flink/pull/2498 Yes, it's a bit more tricky then I expected... These tests probably also need to be changed, because they relied on previous behaviour... What's more with the change some checks on FlinkMiniCluster start to be non-deterministic... I'll commit fixes when I'll fully understand how it works... > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.0, 1.1.1, 1.1.2 >Reporter: Maciej Prochniak > Fix For: 1.2.0, 1.1.3 > > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494086#comment-15494086 ] ASF GitHub Bot commented on FLINK-4619: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2498 Good idea. Unfortunately, the changed broke some tests: - `SavepointITCase.testSubmitWithUnknownSavepointPath` - `RescalingITCase.testSavepointRescalingFailureWithNonPartitionedState` You can see more in the Travis CI report. > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.0, 1.1.1, 1.1.2 >Reporter: Maciej Prochniak > Fix For: 1.2.0, 1.1.3 > > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491488#comment-15491488 ] ASF GitHub Bot commented on FLINK-4619: --- GitHub user mproch opened a pull request: https://github.com/apache/flink/pull/2498 [FLINK-4619] - JobManager does not answer to client when restore from savepoint fails You can merge this pull request into a Git repository by running: $ git pull https://github.com/mproch/flink flink-4619 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2498.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2498 commit 79ed80af927ecededd06ba61d98879b189f064ea Author: Maciek Próchniak Date: 2016-09-14T12:27:27Z [FLINK-4619] - JobManager does not answer to client when restore from savepoint fails > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.0, 1.1.1, 1.1.2 >Reporter: Maciej Prochniak > Fix For: 1.2.0, 1.1.3 > > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[
https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490344#comment-15490344
]
Tzu-Li (Gordon) Tai commented on FLINK-4619:
I think {{org.apache.flink.runtime.client.JobClientActorTest}} in the java
tests of {{flink-runtime}} might be a good place to start looking at.
Feel free to open a PR when you think you're ready, I can offer to help review
:)
> JobManager does not answer to client when restore from savepoint fails
> --
>
> Key: FLINK-4619
> URL: https://issues.apache.org/jira/browse/FLINK-4619
> Project: Flink
> Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Maciej Prochniak
>
> When savepoint used is incompatible with currently deployed process, the job
> manager never returns (jobInfo.notifyClients is not invoked in one of
> try-catch blocks)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490317#comment-15490317 ] Maciej Prochniak commented on FLINK-4619: - https://github.com/mproch/flink/commit/ceef33d94058958f36275bfae81d00054e8cc231 - I think this should do the job, but have yet to find a place to write test... > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.1 >Reporter: Maciej Prochniak > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4619) JobManager does not answer to client when restore from savepoint fails
[ https://issues.apache.org/jira/browse/FLINK-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490308#comment-15490308 ] Tzu-Li (Gordon) Tai commented on FLINK-4619: +1 to fix. Encountered this also. From the client, it would be much more helpful to have information of the cause. > JobManager does not answer to client when restore from savepoint fails > -- > > Key: FLINK-4619 > URL: https://issues.apache.org/jira/browse/FLINK-4619 > Project: Flink > Issue Type: Bug >Affects Versions: 1.1.1 >Reporter: Maciej Prochniak > > When savepoint used is incompatible with currently deployed process, the job > manager never returns (jobInfo.notifyClients is not invoked in one of > try-catch blocks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
