[jira] [Commented] (FLINK-4906) Use constants for the name of system-defined metrics
[ https://issues.apache.org/jira/browse/FLINK-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741976#comment-15741976 ] ASF GitHub Bot commented on FLINK-4906: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2980 > Use constants for the name of system-defined metrics > > > Key: FLINK-4906 > URL: https://issues.apache.org/jira/browse/FLINK-4906 > Project: Flink > Issue Type: Improvement > Components: Metrics >Affects Versions: 1.1.3 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler > Fix For: 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4906) Use constants for the name of system-defined metrics
[ https://issues.apache.org/jira/browse/FLINK-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735503#comment-15735503 ] ASF GitHub Bot commented on FLINK-4906: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/2980 @StephanEwen Thank your for the review, merging. > Use constants for the name of system-defined metrics > > > Key: FLINK-4906 > URL: https://issues.apache.org/jira/browse/FLINK-4906 > Project: Flink > Issue Type: Improvement > Components: Metrics >Affects Versions: 1.1.3 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler > Fix For: 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4906) Use constants for the name of system-defined metrics
[ https://issues.apache.org/jira/browse/FLINK-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735375#comment-15735375 ] ASF GitHub Bot commented on FLINK-4906: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2980 I think this makes sense. +1 > Use constants for the name of system-defined metrics > > > Key: FLINK-4906 > URL: https://issues.apache.org/jira/browse/FLINK-4906 > Project: Flink > Issue Type: Improvement > Components: Metrics >Affects Versions: 1.1.3 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler > Fix For: 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4906) Use constants for the name of system-defined metrics
[ https://issues.apache.org/jira/browse/FLINK-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735280#comment-15735280 ] ASF GitHub Bot commented on FLINK-4906: --- GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2980 [FLINK-4906] [metrics] Introduce constants for IO metrics This PR introduces constants for the names of all all records/byte related IO metrics (numRecordsOut etc.). Before we go ahead and replace all of them i wanted to start small, providing a preview of how it would look like so we can decide whether to go forward with this or not. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 4906_metric_names Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2980.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2980 commit d2ec9426d372816a88662880813d0d81b1b5cc8b Author: zentol Date: 2016-12-09T13:10:10Z [FLINK-4906] [metrics] Introduce constants for IO metrics > Use constants for the name of system-defined metrics > > > Key: FLINK-4906 > URL: https://issues.apache.org/jira/browse/FLINK-4906 > Project: Flink > Issue Type: Improvement > Components: Metrics >Affects Versions: 1.1.3 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler > Fix For: 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
