[jira] [Commented] (FLINK-5112) Remove unused accumulator code from ArchivedExecutionJobVertex
[
https://issues.apache.org/jira/browse/FLINK-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15699569#comment-15699569
]
ASF GitHub Bot commented on FLINK-5112:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2846
> Remove unused accumulator code from ArchivedExecutionJobVertex
> --
>
> Key: FLINK-5112
> URL: https://issues.apache.org/jira/browse/FLINK-5112
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{ArchivedExecutionJobVertex}} computes upon creation the value for the
> accumulators of the associated {{ExecutionVertices}}. This value is, however,
> nowhere stored. This indicates that it is a legacy artifact and I propose to
> remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5112) Remove unused accumulator code from ArchivedExecutionJobVertex
[
https://issues.apache.org/jira/browse/FLINK-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15686328#comment-15686328
]
ASF GitHub Bot commented on FLINK-5112:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2846
Thanks for the review @zentol and the merging.
> Remove unused accumulator code from ArchivedExecutionJobVertex
> --
>
> Key: FLINK-5112
> URL: https://issues.apache.org/jira/browse/FLINK-5112
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{ArchivedExecutionJobVertex}} computes upon creation the value for the
> accumulators of the associated {{ExecutionVertices}}. This value is, however,
> nowhere stored. This indicates that it is a legacy artifact and I propose to
> remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5112) Remove unused accumulator code from ArchivedExecutionJobVertex
[
https://issues.apache.org/jira/browse/FLINK-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683793#comment-15683793
]
ASF GitHub Bot commented on FLINK-5112:
---
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2846
[FLINK-5112] [ExecutionGraph] Remove unused accumulator aggregation code
from ArchivedExecutionJobVertex
The ArchivedExecutionJobVertex calculated for its ExecutionVertices the
aggregated accumulator
value. However, the result was nowhere stored. This indicates that this
code is no longer used
and can be removed.
Review @zentol.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink
fixArchivedJobExecutionVertex
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2846.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2846
commit 8d5fc2f91dfa8dd706cc4e7e9a934910bde23543
Author: Till Rohrmann
Date: 2016-11-21T14:57:06Z
[FLINK-5112] [ExecutionGraph] Remove unused accumulator aggregation code
from ArchivedExecutionJobVertex
The ArchivedExecutionJobVertex calculated for its ExecutionVertices the
aggregated accumulator
value. However, the result was nowhere stored. This indicates that this
code is no longer used
and can be removed.
> Remove unused accumulator code from ArchivedExecutionJobVertex
> --
>
> Key: FLINK-5112
> URL: https://issues.apache.org/jira/browse/FLINK-5112
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{ArchivedExecutionJobVertex}} computes upon creation the value for the
> accumulators of the associated {{ExecutionVertices}}. This value is, however,
> nowhere stored. This indicates that it is a legacy artifact and I propose to
> remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5112) Remove unused accumulator code from ArchivedExecutionJobVertex
[
https://issues.apache.org/jira/browse/FLINK-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683807#comment-15683807
]
ASF GitHub Bot commented on FLINK-5112:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2846
+1, will merge this.
> Remove unused accumulator code from ArchivedExecutionJobVertex
> --
>
> Key: FLINK-5112
> URL: https://issues.apache.org/jira/browse/FLINK-5112
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{ArchivedExecutionJobVertex}} computes upon creation the value for the
> accumulators of the associated {{ExecutionVertices}}. This value is, however,
> nowhere stored. This indicates that it is a legacy artifact and I propose to
> remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
