[jira] [Commented] (FLINK-5240) Properly Close StateBackend in StreamTask when closing/canceling

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748676#comment-15748676
 ] 

ASF GitHub Bot commented on FLINK-5240:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2997


> Properly Close StateBackend in StreamTask when closing/canceling
> 
>
> Key: FLINK-5240
> URL: https://issues.apache.org/jira/browse/FLINK-5240
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.2.0
>
>
> Right now, the {{StreamTask}} never calls {{close()}} on the state backend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5240) Properly Close StateBackend in StreamTask when closing/canceling

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748669#comment-15748669
 ] 

ASF GitHub Bot commented on FLINK-5240:
---

Github user mxm commented on the issue:

https://github.com/apache/flink/pull/2997
  
Thanks for the review, will merge then.


> Properly Close StateBackend in StreamTask when closing/canceling
> 
>
> Key: FLINK-5240
> URL: https://issues.apache.org/jira/browse/FLINK-5240
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.2.0
>
>
> Right now, the {{StreamTask}} never calls {{close()}} on the state backend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5240) Properly Close StateBackend in StreamTask when closing/canceling

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748632#comment-15748632
 ] 

ASF GitHub Bot commented on FLINK-5240:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/2997
  
+1, please go ahead and merge.

And thank for fixing.   


> Properly Close StateBackend in StreamTask when closing/canceling
> 
>
> Key: FLINK-5240
> URL: https://issues.apache.org/jira/browse/FLINK-5240
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.2.0
>
>
> Right now, the {{StreamTask}} never calls {{close()}} on the state backend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5240) Properly Close StateBackend in StreamTask when closing/canceling

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748279#comment-15748279
 ] 

ASF GitHub Bot commented on FLINK-5240:
---

Github user StefanRRichter commented on the issue:

https://github.com/apache/flink/pull/2997
  
LGTM  


> Properly Close StateBackend in StreamTask when closing/canceling
> 
>
> Key: FLINK-5240
> URL: https://issues.apache.org/jira/browse/FLINK-5240
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.2.0
>
>
> Right now, the {{StreamTask}} never calls {{close()}} on the state backend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5240) Properly Close StateBackend in StreamTask when closing/canceling

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745293#comment-15745293
 ] 

ASF GitHub Bot commented on FLINK-5240:
---

GitHub user mxm opened a pull request:

https://github.com/apache/flink/pull/2997

[FLINK-5240][tests] ensure state backends are properly closed

This adds additional test cases to verify the state backends are closed
properly upon the end of a task. The state backends should always be
closed regardless of the final state of the task.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mxm/flink FLINK-5240

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2997.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2997


commit 5162c26d4cf59be8f997ee1e99200ff143f13db2
Author: Maximilian Michels 
Date:   2016-12-13T14:21:31Z

[FLINK-5240][tests] ensure state backends are properly closed

This adds additional test cases to verify the state backends are closed
properly upon the end of a task. The state backends should always be
closed regardless of the final state of the task.




> Properly Close StateBackend in StreamTask when closing/canceling
> 
>
> Key: FLINK-5240
> URL: https://issues.apache.org/jira/browse/FLINK-5240
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.2.0
>
>
> Right now, the {{StreamTask}} never calls {{close()}} on the state backend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5240) Properly Close StateBackend in StreamTask when closing/canceling

[Stephan Ewen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715864#comment-15715864
 ] 

Stephan Ewen commented on FLINK-5240:
-

This is fixed in 1.1.4 via 59f61bf6cb8351cec9369e2de39c6eeffbda10ea


> Properly Close StateBackend in StreamTask when closing/canceling
> 
>
> Key: FLINK-5240
> URL: https://issues.apache.org/jira/browse/FLINK-5240
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.2.0
>
>
> Right now, the {{StreamTask}} never calls {{close()}} on the state backend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)