[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932215#comment-15932215
 ] 

ASF GitHub Bot commented on FLINK-5634:
---

Github user jgrier closed the pull request at:

https://github.com/apache/flink/pull/3204


> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
>Assignee: Jamie Grier
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.
> Here is a PR for this:  https://github.com/apache/flink/pull/3204



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901025#comment-15901025
 ] 

ASF GitHub Bot commented on FLINK-5634:
---

Github user patricklucas commented on the issue:

https://github.com/apache/flink/pull/3204
  
I vote to close this issue since #3492 has been merged/FLINK-4326 has been 
resolved.


> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
>Assignee: Jamie Grier
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.
> Here is a PR for this:  https://github.com/apache/flink/pull/3204



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874603#comment-15874603
 ] 

ASF GitHub Bot commented on FLINK-5634:
---

Github user iemejia commented on the issue:

https://github.com/apache/flink/pull/3204
  
@greghogan Definitely a misunderstanding, I had the impression you just 
didn't like my solution, so I didn't continue pushing for it (even if we 
finished with similar ideas).

For ref, Greg's PR, so someone (a committer) reviews it
https://github.com/apache/flink/pull/3351

I will move the docker scripts to use start-foreground once it is merged.



> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
>Assignee: Jamie Grier
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.
> Here is a PR for this:  https://github.com/apache/flink/pull/3204



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872294#comment-15872294
 ] 

ASF GitHub Bot commented on FLINK-5634:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3204
  
This is now looking like a game of hot potato :) I'm happy to let @iemejia 
create the PR but he had offered the same to me. If I don't hear otherwise 
first I'll create a PR for FLINK-4326. While sitting down so I don't step on 
anyone's toes.


> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
>Assignee: Jamie Grier
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.
> Here is a PR for this:  https://github.com/apache/flink/pull/3204



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872224#comment-15872224
 ] 

ASF GitHub Bot commented on FLINK-5634:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3204
  
Does anyone want to take a stab at addressing this the 
https://issues.apache.org/jira/browse/FLINK-4326 way? I think no one is active 
on that issue right now...


> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
>Assignee: Jamie Grier
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.
> Here is a PR for this:  https://github.com/apache/flink/pull/3204



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851614#comment-15851614
 ] 

ASF GitHub Bot commented on FLINK-5634:
---

Github user jgrier commented on the issue:

https://github.com/apache/flink/pull/3204
  
Agreed.. If https://issues.apache.org/jira/browse/FLINK-4326 were merged 
this would also work fine. Whether or not Flink runs in the background or 
foreground is orthogonal to where the logs go – as long as Flink can be 
configured to log to stdout we're good.



> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
>Assignee: Jamie Grier
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.
> Here is a PR for this:  https://github.com/apache/flink/pull/3204



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[Jamie Grier (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851609#comment-15851609
 ] 

Jamie Grier commented on FLINK-5634:


Agreed..  If [4326] were merged this would also work fine.  Whether or not 
Flink runs in the background or foreground is orthogonal to where the logs go 
-- as long as Flink can be configured to log to stdout we're good.

> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
>Assignee: Jamie Grier
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.
> Here is a PR for this:  https://github.com/apache/flink/pull/3204



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839649#comment-15839649
 ] 

ASF GitHub Bot commented on FLINK-5634:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3204
  
In regards to FLINK-4326, should the daemon scripts called by the docker 
script run in the foreground or background? It seems that this PR may be 
unnecessary.


> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
>Assignee: Jamie Grier
> Fix For: 1.2.0
>
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.
> Here is a PR for this:  https://github.com/apache/flink/pull/3204



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837691#comment-15837691
 ] 

ASF GitHub Bot commented on FLINK-5634:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3204
  
Looks good to me, +1

@uce the ScriptMeister should probably give his blessing as well...


> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
> Fix For: 1.2.0
>
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.
> Here is a PR for this:  https://github.com/apache/flink/pull/3204



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837250#comment-15837250
 ] 

ASF GitHub Bot commented on FLINK-5634:
---

GitHub user jgrier opened a pull request:

https://github.com/apache/flink/pull/3204

[FLINK-5634] Flink should not always redirect stdout to a file. 

Adding flag to flink-daemon.sh and related scripts so that we can actually 
log to the console -- which is better for Docker environments.  Also modifying 
Docker entrypoint to use this.

There is a follow on PR with many more changes to the Docker scripts and 
tooling based on this one.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jgrier/flink no-stdout-redirect

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3204


commit 5f6a9671816a16b810990a10310f994898e9ba41
Author: Jamie Grier 
Date:   2017-01-21T00:14:27Z

Adding flag to flink-daemon.sh and related scripts so that we can actually 
log to the console -- which is better for Docker environments.




> Flink should not always redirect stdout to a file.
> --
>
> Key: FLINK-5634
> URL: https://issues.apache.org/jira/browse/FLINK-5634
> Project: Flink
>  Issue Type: Bug
>  Components: Docker
>Affects Versions: 1.2.0
>Reporter: Jamie Grier
> Fix For: 1.2.0
>
>
> Flink always redirects stdout to a file.  While often convenient this isn't 
> always what people want.  The most obvious case of this is a Docker 
> deployment.
> It should be possible to have Flink log to stdout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)