[jira] [Commented] (FLINK-5637) Default Flink configuration contains whitespace characters, causing parser WARNings
[
https://issues.apache.org/jira/browse/FLINK-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838325#comment-15838325
]
ASF GitHub Bot commented on FLINK-5637:
---
Github user rmetzger closed the pull request at:
https://github.com/apache/flink/pull/3216
> Default Flink configuration contains whitespace characters, causing parser
> WARNings
> ---
>
> Key: FLINK-5637
> URL: https://issues.apache.org/jira/browse/FLINK-5637
> Project: Flink
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Robert Metzger
>Assignee: Robert Metzger
> Labels: starter
> Fix For: 1.2.0, 1.3.0
>
>
> {code}
> 2017-01-25 09:45:30,670 WARN
> org.apache.flink.configuration.GlobalConfiguration- Error while
> trying to split key and value in configuration file
> /yarn/nm/usercache/robert/appcache/application_1485249546281_0018/container_1485249546281_0018_01_01/flink-conf.yaml:
>
> {code}
> The whitespace is currently in line 67:
> {code}
> #==
>
> # The address under which the web-based runtime monitor listens.
> {code}
> I think we should add a test to the {{GlobalConfigurationTest}} that ensures
> the configuration file we are shipping doesn't produce any WARNings by
> default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5637) Default Flink configuration contains whitespace characters, causing parser WARNings
[
https://issues.apache.org/jira/browse/FLINK-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838109#comment-15838109
]
ASF GitHub Bot commented on FLINK-5637:
---
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3216
Yes. But I think it would be an overkill to add a test to ensure a certain
log level.
I'm going to merge the change now.
> Default Flink configuration contains whitespace characters, causing parser
> WARNings
> ---
>
> Key: FLINK-5637
> URL: https://issues.apache.org/jira/browse/FLINK-5637
> Project: Flink
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Robert Metzger
>Assignee: Robert Metzger
> Labels: starter
>
> {code}
> 2017-01-25 09:45:30,670 WARN
> org.apache.flink.configuration.GlobalConfiguration- Error while
> trying to split key and value in configuration file
> /yarn/nm/usercache/robert/appcache/application_1485249546281_0018/container_1485249546281_0018_01_01/flink-conf.yaml:
>
> {code}
> The whitespace is currently in line 67:
> {code}
> #==
>
> # The address under which the web-based runtime monitor listens.
> {code}
> I think we should add a test to the {{GlobalConfigurationTest}} that ensures
> the configuration file we are shipping doesn't produce any WARNings by
> default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5637) Default Flink configuration contains whitespace characters, causing parser WARNings
[
https://issues.apache.org/jira/browse/FLINK-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837937#comment-15837937
]
ASF GitHub Bot commented on FLINK-5637:
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3216
Looks good, though we don't really test whether it silently ignores the
empty lines, do we?
> Default Flink configuration contains whitespace characters, causing parser
> WARNings
> ---
>
> Key: FLINK-5637
> URL: https://issues.apache.org/jira/browse/FLINK-5637
> Project: Flink
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Robert Metzger
>Assignee: Robert Metzger
> Labels: starter
>
> {code}
> 2017-01-25 09:45:30,670 WARN
> org.apache.flink.configuration.GlobalConfiguration- Error while
> trying to split key and value in configuration file
> /yarn/nm/usercache/robert/appcache/application_1485249546281_0018/container_1485249546281_0018_01_01/flink-conf.yaml:
>
> {code}
> The whitespace is currently in line 67:
> {code}
> #==
>
> # The address under which the web-based runtime monitor listens.
> {code}
> I think we should add a test to the {{GlobalConfigurationTest}} that ensures
> the configuration file we are shipping doesn't produce any WARNings by
> default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5637) Default Flink configuration contains whitespace characters, causing parser WARNings
[
https://issues.apache.org/jira/browse/FLINK-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837915#comment-15837915
]
ASF GitHub Bot commented on FLINK-5637:
---
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/3216
[FLINK-5637] Avoid warning while parsing YAML configuration files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink5637
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3216
commit 81cf4859d87c9912964d60e0faf05ef5c3abb620
Author: Robert Metzger
Date: 2017-01-25T15:31:11Z
[FLINK-5637] Avoid warning while parsing YAML configuration files
> Default Flink configuration contains whitespace characters, causing parser
> WARNings
> ---
>
> Key: FLINK-5637
> URL: https://issues.apache.org/jira/browse/FLINK-5637
> Project: Flink
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Robert Metzger
>Assignee: Robert Metzger
> Labels: starter
>
> {code}
> 2017-01-25 09:45:30,670 WARN
> org.apache.flink.configuration.GlobalConfiguration- Error while
> trying to split key and value in configuration file
> /yarn/nm/usercache/robert/appcache/application_1485249546281_0018/container_1485249546281_0018_01_01/flink-conf.yaml:
>
> {code}
> The whitespace is currently in line 67:
> {code}
> #==
>
> # The address under which the web-based runtime monitor listens.
> {code}
> I think we should add a test to the {{GlobalConfigurationTest}} that ensures
> the configuration file we are shipping doesn't produce any WARNings by
> default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
