[jira] [Commented] (FLINK-5811) Harden YarnClusterDescriptorTest

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870201#comment-15870201
 ] 

ASF GitHub Bot commented on FLINK-5811:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3326


> Harden YarnClusterDescriptorTest
> 
>
> Key: FLINK-5811
> URL: https://issues.apache.org/jira/browse/FLINK-5811
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
> Fix For: 1.3.0
>
>
> The {{YarnClusterDescriptorTest}} is expecting in some test cases an 
> {{Exception}} but does not fail if the exception is not thrown. Moreover it 
> prints the stack trace of the expected exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5811) Harden YarnClusterDescriptorTest

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870196#comment-15870196
 ] 

ASF GitHub Bot commented on FLINK-5811:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/3326
  
Thanks for your review @StephanEwen. Merging this PR.


> Harden YarnClusterDescriptorTest
> 
>
> Key: FLINK-5811
> URL: https://issues.apache.org/jira/browse/FLINK-5811
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> The {{YarnClusterDescriptorTest}} is expecting in some test cases an 
> {{Exception}} but does not fail if the exception is not thrown. Moreover it 
> prints the stack trace of the expected exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5811) Harden YarnClusterDescriptorTest

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869646#comment-15869646
 ] 

ASF GitHub Bot commented on FLINK-5811:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3326
  
I think this looks good!


> Harden YarnClusterDescriptorTest
> 
>
> Key: FLINK-5811
> URL: https://issues.apache.org/jira/browse/FLINK-5811
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> The {{YarnClusterDescriptorTest}} is expecting in some test cases an 
> {{Exception}} but does not fail if the exception is not thrown. Moreover it 
> prints the stack trace of the expected exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5811) Harden YarnClusterDescriptorTest

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868164#comment-15868164
 ] 

ASF GitHub Bot commented on FLINK-5811:
---

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/3326

[FLINK-5811] [tests] Harden YarnClusterDescriptorTest

Add fail call after method which is supposed to fail. Remove stack trace 
printing
to stdout.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink FLINK-5811

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3326


commit 245d28a825782044e1cea3c86240a326e98a5711
Author: Till Rohrmann 
Date:   2017-02-15T16:51:02Z

[FLINK-5811] [tests] Harden YarnClusterDescriptorTest

Add fail call after method which is supposed to fail. Remove stack trace 
printing
to stdout.




> Harden YarnClusterDescriptorTest
> 
>
> Key: FLINK-5811
> URL: https://issues.apache.org/jira/browse/FLINK-5811
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> The {{YarnClusterDescriptorTest}} is expecting in some test cases an 
> {{Exception}} but does not fail if the exception is not thrown. Moreover it 
> prints the stack trace of the expected exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)