[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941013#comment-15941013 ] ASF GitHub Bot commented on FLINK-6089: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3564 I accidentally merged this to `master` not `table-retraction`. Since the changes do not break anything, this is not a problem. > Implement decoration phase for rewriting predicated logical plan after > volcano optimization phase > - > > Key: FLINK-6089 > URL: https://issues.apache.org/jira/browse/FLINK-6089 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL >Reporter: Shaoxuan Wang >Assignee: Hequn Cheng > Fix For: 1.3.0 > > > At present, there is no chance to modify the DataStreamRel tree after the > volcano optimization. We consider to add a decoration phase after volcano > optimization phase. Decoration phase is dedicated for rewriting predicated > logical plan and is independent of cost module. After decoration phase is > added, we get the chance to apply retraction rules at this phase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940989#comment-15940989 ] ASF GitHub Bot commented on FLINK-6089: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3564 > Implement decoration phase for rewriting predicated logical plan after > volcano optimization phase > - > > Key: FLINK-6089 > URL: https://issues.apache.org/jira/browse/FLINK-6089 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL >Reporter: Shaoxuan Wang >Assignee: Hequn Cheng > > At present, there is no chance to modify the DataStreamRel tree after the > volcano optimization. We consider to add a decoration phase after volcano > optimization phase. Decoration phase is dedicated for rewriting predicated > logical plan and is independent of cost module. After decoration phase is > added, we get the chance to apply retraction rules at this phase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939315#comment-15939315 ] ASF GitHub Bot commented on FLINK-6089: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3564 merging > Implement decoration phase for rewriting predicated logical plan after > volcano optimization phase > - > > Key: FLINK-6089 > URL: https://issues.apache.org/jira/browse/FLINK-6089 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL >Reporter: Shaoxuan Wang >Assignee: Hequn Cheng > > At present, there is no chance to modify the DataStreamRel tree after the > volcano optimization. We consider to add a decoration phase after volcano > optimization phase. Decoration phase is dedicated for rewriting predicated > logical plan and is independent of cost module. After decoration phase is > added, we get the chance to apply retraction rules at this phase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938782#comment-15938782 ] ASF GitHub Bot commented on FLINK-6089: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3564 Thanks for the update @hequn8128. I think this PR is good to merge once you addressed @twalthr's comment about extending the method docs. Thank you, Fabian > Implement decoration phase for rewriting predicated logical plan after > volcano optimization phase > - > > Key: FLINK-6089 > URL: https://issues.apache.org/jira/browse/FLINK-6089 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL >Reporter: Shaoxuan Wang >Assignee: Hequn Cheng > > At present, there is no chance to modify the DataStreamRel tree after the > volcano optimization. We consider to add a decoration phase after volcano > optimization phase. Decoration phase is dedicated for rewriting predicated > logical plan and is independent of cost module. After decoration phase is > added, we get the chance to apply retraction rules at this phase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938763#comment-15938763 ] ASF GitHub Bot commented on FLINK-6089: --- Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/3564 hi @fhueske , thanks for the review. I was expecting some other batch use-cases where we may need to rewrite the logical plan after volcano. But you are right, we do not need to add it into BatchTableEnvironment for now. I have updated PR to remove it from BatchTableEnvironment. Please take a look. > Implement decoration phase for rewriting predicated logical plan after > volcano optimization phase > - > > Key: FLINK-6089 > URL: https://issues.apache.org/jira/browse/FLINK-6089 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL >Reporter: Shaoxuan Wang >Assignee: Hequn Cheng > > At present, there is no chance to modify the DataStreamRel tree after the > volcano optimization. We consider to add a decoration phase after volcano > optimization phase. Decoration phase is dedicated for rewriting predicated > logical plan and is independent of cost module. After decoration phase is > added, we get the chance to apply retraction rules at this phase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938284#comment-15938284 ] ASF GitHub Bot commented on FLINK-6089: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3564 Hi @hequn8128, thanks for the PR. I think it looks good, but I have a question. This PR is prepares for adding retractions. Why do we need a decoration phase for batch queries if this is about retractions which only apply for streams? Thanks, Fabian > Implement decoration phase for rewriting predicated logical plan after > volcano optimization phase > - > > Key: FLINK-6089 > URL: https://issues.apache.org/jira/browse/FLINK-6089 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL >Reporter: Shaoxuan Wang >Assignee: Hequn Cheng > > At present, there is no chance to modify the DataStreamRel tree after the > volcano optimization. We consider to add a decoration phase after volcano > optimization phase. Decoration phase is dedicated for rewriting predicated > logical plan and is independent of cost module. After decoration phase is > added, we get the chance to apply retraction rules at this phase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[
https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937868#comment-15937868
]
ASF GitHub Bot commented on FLINK-6089:
---
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3564#discussion_r107603328
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -162,6 +162,27 @@ abstract class TableEnvironment(val config:
TableConfig) {
}
/**
+* Returns the decoration rule set for this environment
+* including a custom RuleSet configuration.
--- End diff --
done, pr has been updated~
> Implement decoration phase for rewriting predicated logical plan after
> volcano optimization phase
> -
>
> Key: FLINK-6089
> URL: https://issues.apache.org/jira/browse/FLINK-6089
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
>Reporter: Shaoxuan Wang
>Assignee: Hequn Cheng
>
> At present, there is no chance to modify the DataStreamRel tree after the
> volcano optimization. We consider to add a decoration phase after volcano
> optimization phase. Decoration phase is dedicated for rewriting predicated
> logical plan and is independent of cost module. After decoration phase is
> added, we get the chance to apply retraction rules at this phase.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[
https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937799#comment-15937799
]
ASF GitHub Bot commented on FLINK-6089:
---
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3564#discussion_r107594707
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -162,6 +162,27 @@ abstract class TableEnvironment(val config:
TableConfig) {
}
/**
+* Returns the decoration rule set for this environment
+* including a custom RuleSet configuration.
--- End diff --
Do not unnecessarily break lines.
> Implement decoration phase for rewriting predicated logical plan after
> volcano optimization phase
> -
>
> Key: FLINK-6089
> URL: https://issues.apache.org/jira/browse/FLINK-6089
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
>Reporter: Shaoxuan Wang
>Assignee: Hequn Cheng
>
> At present, there is no chance to modify the DataStreamRel tree after the
> volcano optimization. We consider to add a decoration phase after volcano
> optimization phase. Decoration phase is dedicated for rewriting predicated
> logical plan and is independent of cost module. After decoration phase is
> added, we get the chance to apply retraction rules at this phase.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934722#comment-15934722 ] ASF GitHub Bot commented on FLINK-6089: --- Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/3564 @twalthr Thanks for the review. I have addressed all your comments and updated the PR > Implement decoration phase for rewriting predicated logical plan after > volcano optimization phase > - > > Key: FLINK-6089 > URL: https://issues.apache.org/jira/browse/FLINK-6089 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL >Reporter: Shaoxuan Wang >Assignee: Hequn Cheng > > At present, there is no chance to modify the DataStreamRel tree after the > volcano optimization. We consider to add a decoration phase after volcano > optimization phase. Decoration phase is dedicated for rewriting predicated > logical plan and is independent of cost module. After decoration phase is > added, we get the chance to apply retraction rules at this phase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934666#comment-15934666 ] ASF GitHub Bot commented on FLINK-6089: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3564 **Please note**: This is the first PR for adding retraction support. It should be merged to the `table-retraction` feature branch, not the `master` branch. > Implement decoration phase for rewriting predicated logical plan after > volcano optimization phase > - > > Key: FLINK-6089 > URL: https://issues.apache.org/jira/browse/FLINK-6089 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL >Reporter: Shaoxuan Wang >Assignee: Hequn Cheng > > At present, there is no chance to modify the DataStreamRel tree after the > volcano optimization. We consider to add a decoration phase after volcano > optimization phase. Decoration phase is dedicated for rewriting predicated > logical plan and is independent of cost module. After decoration phase is > added, we get the chance to apply retraction rules at this phase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931147#comment-15931147 ] ASF GitHub Bot commented on FLINK-6089: --- GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/3564 [FLINK-6089] [table] Implement decoration phase for rewriting predicated logical plan after volcano optimization phase At present, there is no chance to modify the DataStreamRel tree after the volcano optimization. This pr consider to add a decoration phase after volcano optimization phase. Decoration phase is dedicated for rewriting predicated logical plan and is independent of cost module. After decoration phase is added, we get the chance to apply retraction rules at this phase (The next jira[FLINK-6090] will add retraction rules at decorate phase). You can merge this pull request into a Git repository by running: $ git pull https://github.com/hequn8128/flink FLINK-6089 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3564.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3564 commit 0fed825bc3655af9b4fce5e67e66018e194ba6b3 Author: hequn.chq Date: 2017-03-16T03:11:17Z Implement decoration phase for predicated logical plan rewriting after volcano optimization phase > Implement decoration phase for rewriting predicated logical plan after > volcano optimization phase > - > > Key: FLINK-6089 > URL: https://issues.apache.org/jira/browse/FLINK-6089 > Project: Flink > Issue Type: Sub-task >Reporter: Shaoxuan Wang >Assignee: Hequn Cheng > > At present, there is no chance to modify the DataStreamRel tree after the > volcano optimization. We consider to add a decoration phase after volcano > optimization phase. Decoration phase is dedicated for rewriting predicated > logical plan and is independent of cost module. After decoration phase is > added, we get the chance to apply retraction rules at this phase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
