[jira] [Commented] (FLINK-6588) Rename NumberOfFullRestarts metric
[
https://issues.apache.org/jira/browse/FLINK-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106833#comment-16106833
]
ASF GitHub Bot commented on FLINK-6588:
---
Github user zjureel closed the pull request at:
https://github.com/apache/flink/pull/4292
> Rename NumberOfFullRestarts metric
> --
>
> Key: FLINK-6588
> URL: https://issues.apache.org/jira/browse/FLINK-6588
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
>Affects Versions: 1.3.0, 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
> The metric for the number of full restarts is currently called
> {{fullRestarts}}. For clarity and consitency purposes I propose to rename it
> to {{numFullRestarts}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6588) Rename NumberOfFullRestarts metric
[
https://issues.apache.org/jira/browse/FLINK-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091209#comment-16091209
]
ASF GitHub Bot commented on FLINK-6588:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4292
Unfortunately i agree, we already made a release with the current name so
we can't change it.
> Rename NumberOfFullRestarts metric
> --
>
> Key: FLINK-6588
> URL: https://issues.apache.org/jira/browse/FLINK-6588
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
>Affects Versions: 1.3.0, 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
> The metric for the number of full restarts is currently called
> {{fullRestarts}}. For clarity and consitency purposes I propose to rename it
> to {{numFullRestarts}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6588) Rename NumberOfFullRestarts metric
[
https://issues.apache.org/jira/browse/FLINK-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091114#comment-16091114
]
ASF GitHub Bot commented on FLINK-6588:
---
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4292
@zentol What do you think of @StephanEwen 's suggestion? I think this
change does cause some incompatibilities for user, thanks
> Rename NumberOfFullRestarts metric
> --
>
> Key: FLINK-6588
> URL: https://issues.apache.org/jira/browse/FLINK-6588
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
>Affects Versions: 1.3.0, 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
> The metric for the number of full restarts is currently called
> {{fullRestarts}}. For clarity and consitency purposes I propose to rename it
> to {{numFullRestarts}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6588) Rename NumberOfFullRestarts metric
[
https://issues.apache.org/jira/browse/FLINK-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090374#comment-16090374
]
ASF GitHub Bot commented on FLINK-6588:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4292
I am very hesitant to rename such metrics, because there may be production
users that defined monitoring or alterting based on that metric. Those
installations would be broken through this change.
For that reason, I would suggest to not do this change...
> Rename NumberOfFullRestarts metric
> --
>
> Key: FLINK-6588
> URL: https://issues.apache.org/jira/browse/FLINK-6588
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
>Affects Versions: 1.3.0, 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
> The metric for the number of full restarts is currently called
> {{fullRestarts}}. For clarity and consitency purposes I propose to rename it
> to {{numFullRestarts}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6588) Rename NumberOfFullRestarts metric
[
https://issues.apache.org/jira/browse/FLINK-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080082#comment-16080082
]
ASF GitHub Bot commented on FLINK-6588:
---
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4292
[FLINK-6588] Rename NumberOfFullRestarts metric
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-6588
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4292
commit 9f2023a0c93f521330e0bbfadfc6370a70714382
Author: zjureel
Date: 2017-07-10T09:56:04Z
[FLINK-6588] Rename NumberOfFullRestarts metric
> Rename NumberOfFullRestarts metric
> --
>
> Key: FLINK-6588
> URL: https://issues.apache.org/jira/browse/FLINK-6588
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
>Affects Versions: 1.3.0, 1.4.0
>Reporter: Chesnay Schepler
>
> The metric for the number of full restarts is currently called
> {{fullRestarts}}. For clarity and consitency purposes I propose to rename it
> to {{numFullRestarts}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
