[jira] [Commented] (FLINK-7239) GroupWindow and OverWindow aggregates do not check correctly for updating input
[ https://issues.apache.org/jira/browse/FLINK-7239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17336722#comment-17336722 ] Flink Jira Bot commented on FLINK-7239: --- This issue was labeled "stale-major" 7 ago and has not received any updates so it is being deprioritized. If this ticket is actually Major, please raise the priority and ask a committer to assign you the issue or revive the public discussion. > GroupWindow and OverWindow aggregates do not check correctly for updating > input > --- > > Key: FLINK-7239 > URL: https://issues.apache.org/jira/browse/FLINK-7239 > Project: Flink > Issue Type: Bug > Components: Table SQL / API >Affects Versions: 1.3.1, 1.4.0 >Reporter: Fabian Hueske >Priority: Major > Labels: stale-major > > The streaming table operators for group-window and over-window aggregates do > only support append-only input, i.e., no updates. > However, the {{DataStreamGroupWindowAggregate}} {{DataStreamOverAggregate}} > RelNodes do only check that the input does not have retraction messages which > is only one possible encoding of updates. > We should fix the RelNodes to check if the input is append-only using the > {{UpdatingPlanChecker}} similar to {{DataStreamWindowJoin}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-7239) GroupWindow and OverWindow aggregates do not check correctly for updating input
[ https://issues.apache.org/jira/browse/FLINK-7239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17328740#comment-17328740 ] Flink Jira Bot commented on FLINK-7239: --- This major issue is unassigned and itself and all of its Sub-Tasks have not been updated for 30 days. So, it has been labeled "stale-major". If this ticket is indeed "major", please either assign yourself or give an update. Afterwards, please remove the label. In 7 days the issue will be deprioritized. > GroupWindow and OverWindow aggregates do not check correctly for updating > input > --- > > Key: FLINK-7239 > URL: https://issues.apache.org/jira/browse/FLINK-7239 > Project: Flink > Issue Type: Bug > Components: Table SQL / API >Affects Versions: 1.3.1, 1.4.0 >Reporter: Fabian Hueske >Priority: Major > Labels: stale-major > > The streaming table operators for group-window and over-window aggregates do > only support append-only input, i.e., no updates. > However, the {{DataStreamGroupWindowAggregate}} {{DataStreamOverAggregate}} > RelNodes do only check that the input does not have retraction messages which > is only one possible encoding of updates. > We should fix the RelNodes to check if the input is append-only using the > {{UpdatingPlanChecker}} similar to {{DataStreamWindowJoin}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-7239) GroupWindow and OverWindow aggregates do not check correctly for updating input
[ https://issues.apache.org/jira/browse/FLINK-7239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106724#comment-16106724 ] Hequn Cheng commented on FLINK-7239: hi, [~fhueske] RetractionRules will make sure that {{DataStreamGroupWindowAggregate}} and {{DataStreamOverAggregate}} can not receive purely update messages(updates without retraction). If they did, IMO, we may need to fix the RetractionRules, not the other way around. As for the {{DataStreamWindowJoin}}, we need to set needsUpdatesAsRetraction to true considering that it can not handle purely update messages and check that the input does not have retraction messages. : ) > GroupWindow and OverWindow aggregates do not check correctly for updating > input > --- > > Key: FLINK-7239 > URL: https://issues.apache.org/jira/browse/FLINK-7239 > Project: Flink > Issue Type: Bug > Components: Table API & SQL >Affects Versions: 1.3.1, 1.4.0 >Reporter: Fabian Hueske > > The streaming table operators for group-window and over-window aggregates do > only support append-only input, i.e., no updates. > However, the {{DataStreamGroupWindowAggregate}} {{DataStreamOverAggregate}} > RelNodes do only check that the input does not have retraction messages which > is only one possible encoding of updates. > We should fix the RelNodes to check if the input is append-only using the > {{UpdatingPlanChecker}} similar to {{DataStreamWindowJoin}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)