[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134821#comment-16134821
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4415
@EronWright the driving rationale is that the static variable is an anti
pattern which can cause problems which are hard to track and understand. E.g.
it is really hard to find out where the values are actually set which you
retrieve at another position via the static variable. Instead, we should always
pass the respective configuration objects to the respective components.
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134555#comment-16134555
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/4415
There is only one true fix, that is to propagate the configuration instance
everywhere so that only the entrypoint calls loadConfiguration.
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134553#comment-16134553
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/4415
@tillrohrmann @zentol the whole reason for the static field is to allow the
various sites that call GlobalConfiguration.loadConfiguration to obtain the
dynamic properties.Any property could be overridden. Since there are many,
many such sites, this patch causes a potential regression.
Is there a driving rationale for this aside from a general dislike for
statics?
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134511#comment-16134511
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4415
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134148#comment-16134148
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4415
Thanks for your work @zjureel and sorry that it took me so long to get back
to you. Will be merging your PR now.
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108302#comment-16108302
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4415
@tillrohrmann Great, use `loadConfigurationWithDynamicProperties` instead
of `loadConfiguration` and `setDynamicProperties` will be more concise, it
sounds good to me, thanks
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107064#comment-16107064
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4415#discussion_r130312761
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -79,7 +79,15 @@ public Configuration(Configuration other) {
}
//
-
+
+ /**
+* Set the process-wide dynamic properties to be merged with the
configuration.
+* @param dynamicProperties The given dynamic properties
+ */
+ public void setDynamicProperties(Configuration dynamicProperties) {
+ this.addAll(dynamicProperties);
+ }
--- End diff --
Why not using directly `addAll`?
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106783#comment-16106783
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4415
@tillrohrmann Thank you for your suggestion, I have update the PR template
and add test caseļ¼ thanks
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104604#comment-16104604
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4415
Thanks for your contribution @zjureel. Could you please fill out the PR
template? This will speed up review work significantly.
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[
https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104547#comment-16104547
]
ASF GitHub Bot commented on FLINK-7269:
---
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4415
@tillrohrmann @aljoscha I create this PR and try to fix
[https://issues.apache.org/jira/browse/FLINK-7269](https://issues.apache.org/jira/browse/FLINK-7269),
could you please have look when you're free, thanks :)
> Refactor passing of dynamic properties
> --
>
> Key: FLINK-7269
> URL: https://issues.apache.org/jira/browse/FLINK-7269
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.3.1
>Reporter: Till Rohrmann
>Assignee: Fang Yong
>
> In order to set dynamic properties when loading the {{Configuration}} via
> {{GlobalConfiguration.loadConfiguration}}, we currently set a static field in
> {{GlobalConfiguration}} which is read whenever we load the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality.
> Instead we should explicitly add the dynamic properties to the loaded
> {{Configuration}} at start of the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
[ https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104545#comment-16104545 ] ASF GitHub Bot commented on FLINK-7269: --- GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4415 [FLINK-7269] Refactor passing of dynamic properties *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-1234] [component] Title of the pull request", where *FLINK-1234* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)* ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact* - *Deployments RPC transmits only the blob storage reference* - *TaskManagers retrieve the TaskInfo from the blob cache* ## Verifying this change *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (100MB)* - *Extended integration test for recovery after master (JobManager) failure* - *Added test that validates that TaskInfo is transferred only once across recoveries* - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) - The serializers: (yes / no / don't know) - The runtime per-record code paths (performance sensitive): (yes / no / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) You can merge this pull req
